All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH 6/7] sched: Balance RT tasks when forked as well
Date: Tue, 26 Jul 2011 14:25:08 +0200	[thread overview]
Message-ID: <1311683108.24752.33.camel@twins> (raw)
In-Reply-To: <20110617015919.832743148@goodmis.org>

On Thu, 2011-06-16 at 21:55 -0400, Steven Rostedt wrote:
> +       /* For anything but wake ups, just return the task_cpu */
> +       if (sd_flag != SD_BALANCE_WAKE || sd_flag != SD_BALANCE_FORK) 

So we call select_task_rq() with SD_BALANCE_{WAKE,EXEC,FORK}, 

	(WAKE != WAKE -> 0 || WAKE != FORK -> 1) -> 1
	(EXEC != WAKE -> 1 ) -> 1
	(FORK != WAKE -> 1 ) -> 1

IOW, you never end up doing anything now.. surely you didn't mean that?!

  reply	other threads:[~2011-07-26 12:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17  1:55 [RFC][PATCH 0/7] sched: various updates to the scheduler Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 1/7] sched: Fix need_resched() when checking peempt Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 2/7] sched: Remove noop in next_prio() Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 3/7] sched: Remove noop in lowest_flag_domain() Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 4/7] sched, rt: Fix rq->rt.pushable_tasks bug in push_rt_task() Steven Rostedt
2011-06-17  2:33   ` Mike Galbraith
2011-06-17  2:41     ` Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 5/7] sched: Remove resetting exec_start in put_prev_task_rt() Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 6/7] sched: Balance RT tasks when forked as well Steven Rostedt
2011-07-26 12:25   ` Peter Zijlstra [this message]
2011-07-26 12:35     ` Steven Rostedt
2011-07-26 12:36       ` Peter Zijlstra
2011-07-26 12:50         ` Steven Rostedt
2011-08-14 16:05   ` [tip:sched/core] " tip-bot for Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 7/7] sched: Use pushable_tasks to determine next highest prio Steven Rostedt
2011-06-17  2:40 ` [RFC][PATCH 0/7] sched: various updates to the scheduler Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311683108.24752.33.camel@twins \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.