All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Yong Zhang <yong.zhang0@gmail.com>,
	Hillf Danton <dhillf@gmail.com>
Subject: [RFC][PATCH 2/7] sched: Remove noop in next_prio()
Date: Thu, 16 Jun 2011 21:55:18 -0400	[thread overview]
Message-ID: <20110617015918.232117378@goodmis.org> (raw)
In-Reply-To: 20110617015516.301117218@goodmis.org

[-- Attachment #1: 0002-sched-Remove-noop-in-next_prio.patch --]
[-- Type: text/plain, Size: 949 bytes --]

From: Hillf Danton <dhillf@gmail.com>

When computing the next priority for a given run-queue, the check for
RT priority of the task determined by the pick_next_highest_task_rt()
function could be removed, since only RT tasks are returned by the
function.

Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>
Signed-off-by: Hillf Danton <dhillf@gmail.com>
Link: http://lkml.kernel.org/r/BANLkTimxmWiof9s5AvS3v_0X+sMiE=0x5g@mail.gmail.com
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/sched_rt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 9b8d5dc..a6f1f64 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -692,7 +692,7 @@ static inline int next_prio(struct rq *rq)
 {
 	struct task_struct *next = pick_next_highest_task_rt(rq, rq->cpu);
 
-	if (next && rt_prio(next->prio))
+	if (next)
 		return next->prio;
 	else
 		return MAX_RT_PRIO;
-- 
1.7.4.4



  parent reply	other threads:[~2011-06-17  1:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17  1:55 [RFC][PATCH 0/7] sched: various updates to the scheduler Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 1/7] sched: Fix need_resched() when checking peempt Steven Rostedt
2011-06-17  1:55 ` Steven Rostedt [this message]
2011-06-17  1:55 ` [RFC][PATCH 3/7] sched: Remove noop in lowest_flag_domain() Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 4/7] sched, rt: Fix rq->rt.pushable_tasks bug in push_rt_task() Steven Rostedt
2011-06-17  2:33   ` Mike Galbraith
2011-06-17  2:41     ` Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 5/7] sched: Remove resetting exec_start in put_prev_task_rt() Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 6/7] sched: Balance RT tasks when forked as well Steven Rostedt
2011-07-26 12:25   ` Peter Zijlstra
2011-07-26 12:35     ` Steven Rostedt
2011-07-26 12:36       ` Peter Zijlstra
2011-07-26 12:50         ` Steven Rostedt
2011-08-14 16:05   ` [tip:sched/core] " tip-bot for Steven Rostedt
2011-06-17  1:55 ` [RFC][PATCH 7/7] sched: Use pushable_tasks to determine next highest prio Steven Rostedt
2011-06-17  2:40 ` [RFC][PATCH 0/7] sched: various updates to the scheduler Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110617015918.232117378@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhillf@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.