All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: jack@suse.cz, linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write
Date: Tue, 26 Jul 2011 10:21:48 -0500	[thread overview]
Message-ID: <1311693708.2890.5.camel@doink> (raw)
In-Reply-To: <20110724120330.GC1626@x4.trippels.de>

On Sun, 2011-07-24 at 14:03 +0200, Markus Trippelsdorf wrote:
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> 
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Christoph Hellwig <hch@lst.de>

Finally looking at this I noticed the same thing Christoph
did; thanks for fixing both.  Your change got committed
yesterday via Al Viro's VFS tree.

					-Alex

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <aelder@sgi.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Josef Bacik <josef@redhat.com>, <linux-fsdevel@vger.kernel.org>,
	<viro@zeniv.linux.org.uk>, <jack@suse.cz>,
	<linux-kernel@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>, <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write
Date: Tue, 26 Jul 2011 10:21:48 -0500	[thread overview]
Message-ID: <1311693708.2890.5.camel@doink> (raw)
In-Reply-To: <20110724120330.GC1626@x4.trippels.de>

On Sun, 2011-07-24 at 14:03 +0200, Markus Trippelsdorf wrote:
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> 
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Christoph Hellwig <hch@lst.de>

Finally looking at this I noticed the same thing Christoph
did; thanks for fixing both.  Your change got committed
yesterday via Al Viro's VFS tree.

					-Alex


  parent reply	other threads:[~2011-07-26 15:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 18:05 [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Josef Bacik
2011-06-29 18:09 ` Christoph Hellwig
2011-06-29 18:14   ` Josef Bacik
2011-06-29 19:26 ` Jan Kara
2011-07-23 18:09 ` Markus Trippelsdorf
2011-07-23 18:09   ` Markus Trippelsdorf
2011-07-23 19:32   ` Markus Trippelsdorf
2011-07-23 19:32     ` Markus Trippelsdorf
2011-07-23 20:26   ` Josef Bacik
2011-07-23 20:26     ` Josef Bacik
2011-07-23 20:38     ` Markus Trippelsdorf
2011-07-23 20:38       ` Markus Trippelsdorf
2011-07-23 22:02       ` Markus Trippelsdorf
2011-07-23 22:02         ` Markus Trippelsdorf
2011-07-24 11:16         ` Christoph Hellwig
2011-07-24 11:16           ` Christoph Hellwig
2011-07-24 11:42           ` Christoph Hellwig
2011-07-24 11:42             ` Christoph Hellwig
2011-07-24 11:54           ` [PATCH] xfs: Fix wrong return value of xfs_file_aio_write Markus Trippelsdorf
2011-07-24 11:54             ` Markus Trippelsdorf
2011-07-24 11:57             ` Christoph Hellwig
2011-07-24 11:57               ` Christoph Hellwig
2011-07-24 11:58             ` [PATCH v2] " Markus Trippelsdorf
2011-07-24 11:58               ` Markus Trippelsdorf
2011-07-24 12:03               ` [PATCH] " Markus Trippelsdorf
2011-07-24 12:03                 ` Markus Trippelsdorf
2011-07-24 12:11                 ` Christoph Hellwig
2011-07-24 12:11                   ` Christoph Hellwig
2011-07-26 15:21                 ` Alex Elder [this message]
2011-07-26 15:21                   ` Alex Elder
2011-07-25 17:38 ` [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311693708.2890.5.camel@doink \
    --to=aelder@sgi.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=josef@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.