From: Josef Bacik <josef@redhat.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: jack@suse.cz, linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
hch@infradead.org, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
Date: Sat, 23 Jul 2011 16:26:48 -0400 [thread overview]
Message-ID: <4E2B2E88.8080006@redhat.com> (raw)
In-Reply-To: <20110723180942.GA1616@x4.trippels.de>
On 07/23/2011 02:09 PM, Markus Trippelsdorf wrote:
> On 2011.06.29 at 14:05 -0400, Josef Bacik wrote:
>> Btrfs needs to be able to control how filemap_write_and_wait_range() is called
>> in fsync to make it less of a painful operation, so push down taking i_mutex and
>> the calling of filemap_write_and_wait() down into the ->fsync() handlers. Some
>> file systems can drop taking the i_mutex altogether it seems, like ext3 and
>> ocfs2. For correctness sake I just pushed everything down in all cases to make
>> sure that we keep the current behavior the same for everybody, and then each
>> individual fs maintainer can make up their mind about what to do from there.
>
> At least the xfs part of this patch is broken.
> Running the latest git-kernel bogofilter doesn't work anymore on my xfs
> partition. When I run "bogoutil -d wordlist.db" to dump the contents of
> the database, it produces no output at all.
>
Already fixed and sent a patch out earlier this week. Thanks,
Josef
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <josef@redhat.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org,
viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
Date: Sat, 23 Jul 2011 16:26:48 -0400 [thread overview]
Message-ID: <4E2B2E88.8080006@redhat.com> (raw)
In-Reply-To: <20110723180942.GA1616@x4.trippels.de>
On 07/23/2011 02:09 PM, Markus Trippelsdorf wrote:
> On 2011.06.29 at 14:05 -0400, Josef Bacik wrote:
>> Btrfs needs to be able to control how filemap_write_and_wait_range() is called
>> in fsync to make it less of a painful operation, so push down taking i_mutex and
>> the calling of filemap_write_and_wait() down into the ->fsync() handlers. Some
>> file systems can drop taking the i_mutex altogether it seems, like ext3 and
>> ocfs2. For correctness sake I just pushed everything down in all cases to make
>> sure that we keep the current behavior the same for everybody, and then each
>> individual fs maintainer can make up their mind about what to do from there.
>
> At least the xfs part of this patch is broken.
> Running the latest git-kernel bogofilter doesn't work anymore on my xfs
> partition. When I run "bogoutil -d wordlist.db" to dump the contents of
> the database, it produces no output at all.
>
Already fixed and sent a patch out earlier this week. Thanks,
Josef
next prev parent reply other threads:[~2011-07-23 20:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 18:05 [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Josef Bacik
2011-06-29 18:09 ` Christoph Hellwig
2011-06-29 18:14 ` Josef Bacik
2011-06-29 19:26 ` Jan Kara
2011-07-23 18:09 ` Markus Trippelsdorf
2011-07-23 18:09 ` Markus Trippelsdorf
2011-07-23 19:32 ` Markus Trippelsdorf
2011-07-23 19:32 ` Markus Trippelsdorf
2011-07-23 20:26 ` Josef Bacik [this message]
2011-07-23 20:26 ` Josef Bacik
2011-07-23 20:38 ` Markus Trippelsdorf
2011-07-23 20:38 ` Markus Trippelsdorf
2011-07-23 22:02 ` Markus Trippelsdorf
2011-07-23 22:02 ` Markus Trippelsdorf
2011-07-24 11:16 ` Christoph Hellwig
2011-07-24 11:16 ` Christoph Hellwig
2011-07-24 11:42 ` Christoph Hellwig
2011-07-24 11:42 ` Christoph Hellwig
2011-07-24 11:54 ` [PATCH] xfs: Fix wrong return value of xfs_file_aio_write Markus Trippelsdorf
2011-07-24 11:54 ` Markus Trippelsdorf
2011-07-24 11:57 ` Christoph Hellwig
2011-07-24 11:57 ` Christoph Hellwig
2011-07-24 11:58 ` [PATCH v2] " Markus Trippelsdorf
2011-07-24 11:58 ` Markus Trippelsdorf
2011-07-24 12:03 ` [PATCH] " Markus Trippelsdorf
2011-07-24 12:03 ` Markus Trippelsdorf
2011-07-24 12:11 ` Christoph Hellwig
2011-07-24 12:11 ` Christoph Hellwig
2011-07-26 15:21 ` Alex Elder
2011-07-26 15:21 ` Alex Elder
2011-07-25 17:38 ` [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Ted Ts'o
-- strict thread matches above, loose matches on Subject: below --
2011-06-28 15:35 Josef Bacik
2011-06-29 16:38 ` Jan Kara
2011-06-29 17:41 ` Josef Bacik
2011-06-29 17:05 ` richard -rw- weinberger
2011-06-29 17:05 ` richard -rw- weinberger
2011-07-04 8:54 ` Steven Whitehouse
2011-07-19 10:24 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2B2E88.8080006@redhat.com \
--to=josef@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.