All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: jack@suse.cz, linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write
Date: Sun, 24 Jul 2011 07:57:52 -0400	[thread overview]
Message-ID: <20110724115752.GA11048@infradead.org> (raw)
In-Reply-To: <20110724115420.GA1626@x4.trippels.de>

On Sun, Jul 24, 2011 at 01:54:20PM +0200, Markus Trippelsdorf wrote:
> On 2011.07.24 at 07:16 -0400, Christoph Hellwig wrote:
> > On Sun, Jul 24, 2011 at 12:02:12AM +0200, Markus Trippelsdorf wrote:
> > > The following patch fixes the problem for me:
> > 
> > Good catch, can you send it with a proper signoff and description?
> 
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> ---
>  fs/xfs/linux-2.6/xfs_file.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

The Signed-off-by: line is still missing, and you normally shouldn't
quote the previous mail you reply to for patches.  Sorry for beeing
nit-picky, but see this as a training exercise :)

You can also add:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Christoph Hellwig <hch@lst.de>

as I've run this through xfsqa (strictly speaking it's still running,
but it looks good so far)

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Josef Bacik <josef@redhat.com>,
	linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	jack@suse.cz, linux-kernel@vger.kernel.org,
	Dave Chinner <david@fromorbit.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write
Date: Sun, 24 Jul 2011 07:57:52 -0400	[thread overview]
Message-ID: <20110724115752.GA11048@infradead.org> (raw)
In-Reply-To: <20110724115420.GA1626@x4.trippels.de>

On Sun, Jul 24, 2011 at 01:54:20PM +0200, Markus Trippelsdorf wrote:
> On 2011.07.24 at 07:16 -0400, Christoph Hellwig wrote:
> > On Sun, Jul 24, 2011 at 12:02:12AM +0200, Markus Trippelsdorf wrote:
> > > The following patch fixes the problem for me:
> > 
> > Good catch, can you send it with a proper signoff and description?
> 
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> ---
>  fs/xfs/linux-2.6/xfs_file.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

The Signed-off-by: line is still missing, and you normally shouldn't
quote the previous mail you reply to for patches.  Sorry for beeing
nit-picky, but see this as a training exercise :)

You can also add:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Christoph Hellwig <hch@lst.de>

as I've run this through xfsqa (strictly speaking it's still running,
but it looks good so far)


  reply	other threads:[~2011-07-24 11:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 18:05 [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Josef Bacik
2011-06-29 18:09 ` Christoph Hellwig
2011-06-29 18:14   ` Josef Bacik
2011-06-29 19:26 ` Jan Kara
2011-07-23 18:09 ` Markus Trippelsdorf
2011-07-23 18:09   ` Markus Trippelsdorf
2011-07-23 19:32   ` Markus Trippelsdorf
2011-07-23 19:32     ` Markus Trippelsdorf
2011-07-23 20:26   ` Josef Bacik
2011-07-23 20:26     ` Josef Bacik
2011-07-23 20:38     ` Markus Trippelsdorf
2011-07-23 20:38       ` Markus Trippelsdorf
2011-07-23 22:02       ` Markus Trippelsdorf
2011-07-23 22:02         ` Markus Trippelsdorf
2011-07-24 11:16         ` Christoph Hellwig
2011-07-24 11:16           ` Christoph Hellwig
2011-07-24 11:42           ` Christoph Hellwig
2011-07-24 11:42             ` Christoph Hellwig
2011-07-24 11:54           ` [PATCH] xfs: Fix wrong return value of xfs_file_aio_write Markus Trippelsdorf
2011-07-24 11:54             ` Markus Trippelsdorf
2011-07-24 11:57             ` Christoph Hellwig [this message]
2011-07-24 11:57               ` Christoph Hellwig
2011-07-24 11:58             ` [PATCH v2] " Markus Trippelsdorf
2011-07-24 11:58               ` Markus Trippelsdorf
2011-07-24 12:03               ` [PATCH] " Markus Trippelsdorf
2011-07-24 12:03                 ` Markus Trippelsdorf
2011-07-24 12:11                 ` Christoph Hellwig
2011-07-24 12:11                   ` Christoph Hellwig
2011-07-26 15:21                 ` Alex Elder
2011-07-26 15:21                   ` Alex Elder
2011-07-25 17:38 ` [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110724115752.GA11048@infradead.org \
    --to=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=josef@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.