All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-hardening@lists.openwall.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [kernel-hardening] Re: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo
Date: Wed, 14 Sep 2011 11:41:41 -0700	[thread overview]
Message-ID: <1316025701.4478.65.camel@nimitz> (raw)
In-Reply-To: <20110910164134.GA2442@albatros>

On Sat, 2011-09-10 at 20:41 +0400, Vasiliy Kulikov wrote:
> @@ -4584,7 +4584,8 @@ static const struct file_operations proc_slabstats_operations = {
>  
>  static int __init slab_proc_init(void)
>  {
> -       proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> +       proc_create("slabinfo", S_IWUSR | S_IRUSR, NULL,
> +                   &proc_slabinfo_operations);
>  #ifdef CONFIG_DEBUG_SLAB_LEAK
>         proc_create("slab_allocators", 0, NULL, &proc_sla 

If you respin this, please don't muck with the whitespace.  Otherwise,
I'm fine with this.  Distros are already starting to do this anyway in
userspace.

Reviewed-by: Dave Hansen <dave@linux.vnet.ibm.com>

-- Dave

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-hardening@lists.openwall.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo
Date: Wed, 14 Sep 2011 11:41:41 -0700	[thread overview]
Message-ID: <1316025701.4478.65.camel@nimitz> (raw)
In-Reply-To: <20110910164134.GA2442@albatros>

On Sat, 2011-09-10 at 20:41 +0400, Vasiliy Kulikov wrote:
> @@ -4584,7 +4584,8 @@ static const struct file_operations proc_slabstats_operations = {
>  
>  static int __init slab_proc_init(void)
>  {
> -       proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> +       proc_create("slabinfo", S_IWUSR | S_IRUSR, NULL,
> +                   &proc_slabinfo_operations);
>  #ifdef CONFIG_DEBUG_SLAB_LEAK
>         proc_create("slab_allocators", 0, NULL, &proc_sla 

If you respin this, please don't muck with the whitespace.  Otherwise,
I'm fine with this.  Distros are already starting to do this anyway in
userspace.

Reviewed-by: Dave Hansen <dave@linux.vnet.ibm.com>

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-hardening@lists.openwall.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo
Date: Wed, 14 Sep 2011 11:41:41 -0700	[thread overview]
Message-ID: <1316025701.4478.65.camel@nimitz> (raw)
In-Reply-To: <20110910164134.GA2442@albatros>

On Sat, 2011-09-10 at 20:41 +0400, Vasiliy Kulikov wrote:
> @@ -4584,7 +4584,8 @@ static const struct file_operations proc_slabstats_operations = {
>  
>  static int __init slab_proc_init(void)
>  {
> -       proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> +       proc_create("slabinfo", S_IWUSR | S_IRUSR, NULL,
> +                   &proc_slabinfo_operations);
>  #ifdef CONFIG_DEBUG_SLAB_LEAK
>         proc_create("slab_allocators", 0, NULL, &proc_sla 

If you respin this, please don't muck with the whitespace.  Otherwise,
I'm fine with this.  Distros are already starting to do this anyway in
userspace.

Reviewed-by: Dave Hansen <dave@linux.vnet.ibm.com>

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-09-14 18:41 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-10 16:40 [kernel-hardening] [RFC PATCH 1/2] proc: force dcache drop on unauthorized access Vasiliy Kulikov
2011-09-10 16:40 ` Vasiliy Kulikov
2011-09-10 16:41 ` [kernel-hardening] [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo Vasiliy Kulikov
2011-09-10 16:41   ` Vasiliy Kulikov
2011-09-10 16:41   ` Vasiliy Kulikov
2011-09-12 15:06   ` [kernel-hardening] " Cyrill Gorcunov
2011-09-12 15:06     ` Cyrill Gorcunov
2011-09-12 15:06     ` Cyrill Gorcunov
2011-09-13  6:28     ` [kernel-hardening] " Vasiliy Kulikov
2011-09-13  6:28       ` Vasiliy Kulikov
2011-09-13  6:28       ` Vasiliy Kulikov
2011-09-14 13:16   ` [kernel-hardening] " Vasiliy Kulikov
2011-09-14 13:16     ` Vasiliy Kulikov
2011-09-14 13:16     ` Vasiliy Kulikov
2011-09-14 15:18     ` [kernel-hardening] " Dave Hansen
2011-09-14 15:18       ` Dave Hansen
2011-09-14 15:18       ` Dave Hansen
2011-09-14 15:42       ` [kernel-hardening] " Vasiliy Kulikov
2011-09-14 15:42         ` Vasiliy Kulikov
2011-09-14 15:48         ` Vasiliy Kulikov
2011-09-14 15:48           ` Vasiliy Kulikov
2011-09-14 18:24         ` Dave Hansen
2011-09-14 18:24           ` Dave Hansen
2011-09-14 18:41   ` Dave Hansen [this message]
2011-09-14 18:41     ` Dave Hansen
2011-09-14 18:41     ` Dave Hansen
2011-09-14 19:14     ` [kernel-hardening] " Vasiliy Kulikov
2011-09-14 19:14       ` Vasiliy Kulikov
2011-09-14 19:14       ` Vasiliy Kulikov
2011-09-14 19:27   ` [kernel-hardening] " Kees Cook
2011-09-14 19:27     ` Kees Cook
2011-09-14 19:27     ` Kees Cook
2011-09-18 17:05     ` [kernel-hardening] " Vasiliy Kulikov
2011-09-18 17:05       ` Vasiliy Kulikov
2011-09-19 13:42       ` Christoph Lameter
2011-09-19 13:42         ` Christoph Lameter
2011-09-19 14:30       ` Pekka Enberg
2011-09-19 14:30         ` Pekka Enberg
2011-09-19 14:46         ` Vasiliy Kulikov
2011-09-19 14:46           ` Vasiliy Kulikov
2011-09-19 15:13           ` Pekka Enberg
2011-09-19 15:13             ` Pekka Enberg
2011-09-19 15:57             ` Vasiliy Kulikov
2011-09-19 15:57               ` Vasiliy Kulikov
2011-09-19 16:11               ` Pekka Enberg
2011-09-19 16:11                 ` Pekka Enberg
2011-09-19 16:18                 ` Vasiliy Kulikov
2011-09-19 16:18                   ` Vasiliy Kulikov
2011-09-19 17:31                   ` Pekka Enberg
2011-09-19 17:31                     ` Pekka Enberg
2011-09-19 17:35                     ` Vasiliy Kulikov
2011-09-19 17:35                       ` Vasiliy Kulikov
2011-09-19 17:51                       ` Christoph Lameter
2011-09-19 17:51                         ` Christoph Lameter
2011-09-19 19:59                         ` Valdis.Kletnieks
2011-09-19 20:02                           ` Christoph Lameter
2011-09-19 20:02                             ` Christoph Lameter
2011-09-19 20:36                             ` Valdis.Kletnieks
2011-09-19 17:51                       ` Pekka Enberg
2011-09-19 17:51                         ` Pekka Enberg
2011-09-19 17:58                         ` Vasiliy Kulikov
2011-09-19 17:58                           ` Vasiliy Kulikov
2011-09-19 18:46                           ` Pekka Enberg
2011-09-19 18:46                             ` Pekka Enberg
2011-09-19 18:55                             ` Vasiliy Kulikov
2011-09-19 18:55                               ` Vasiliy Kulikov
2011-09-19 19:20                               ` Pekka Enberg
2011-09-19 19:20                                 ` Pekka Enberg
2011-09-19 19:33                               ` Pekka Enberg
2011-09-19 19:33                                 ` Pekka Enberg
2011-09-19 18:55                             ` Linus Torvalds
2011-09-19 18:55                               ` Linus Torvalds
2011-09-19 19:18                               ` Pekka Enberg
2011-09-19 19:18                                 ` Pekka Enberg
2011-09-19 19:45                                 ` Pekka Enberg
2011-09-19 19:45                                   ` Pekka Enberg
2011-09-19 20:59                                 ` David Rientjes
2011-09-19 20:59                                   ` David Rientjes
2011-09-19 18:03                         ` Dave Hansen
2011-09-19 18:03                           ` Dave Hansen
2011-09-19 18:21                           ` Pekka Enberg
2011-09-19 18:21                             ` Pekka Enberg
2011-09-19 19:45           ` Valdis.Kletnieks
2011-09-19 19:55             ` Alan Cox
2011-09-19 19:55               ` Alan Cox
2011-09-21 17:05               ` Vasiliy Kulikov
2011-09-21 17:05                 ` Vasiliy Kulikov
2011-09-22  2:20                 ` Valdis.Kletnieks
2011-09-22 17:57 ` [kernel-hardening] Re: [RFC PATCH 1/2] proc: force dcache drop on unauthorized access Vasiliy Kulikov
2011-09-22 17:57   ` Vasiliy Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316025701.4478.65.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=gorcunov@gmail.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=segoon@openwall.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.