* [PATCH] multipath: get right sysfs value for checker_timeout
@ 2011-10-05 4:15 Benjamin Marzinski
2011-10-05 20:45 ` Christophe Varoqui
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2011-10-05 4:15 UTC (permalink / raw)
To: device-mapper development; +Cc: Christophe Varoqui
sysfs_get_timeout() wasn't looking in the correct directory for the
checker timeout value. It was looking at .../block/<devname>/timeout,
instead of .../block/<devname>/device/timeout
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/discovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: multipath-tools-110916/libmultipath/discovery.c
===================================================================
--- multipath-tools-110916.orig/libmultipath/discovery.c
+++ multipath-tools-110916/libmultipath/discovery.c
@@ -166,7 +166,7 @@ sysfs_get_timeout(struct sysfs_device *d
if (safe_sprintf(attr_path, "%s/device", dev->devpath))
return 1;
- len = sysfs_attr_get_value(dev->devpath, "timeout", attr, NAME_SIZE);
+ len = sysfs_attr_get_value(attr_path, "timeout", attr, NAME_SIZE);
if (!len) {
condlog(3, "%s: No timeout value in sysfs", dev->devpath);
return 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] multipath: get right sysfs value for checker_timeout
2011-10-05 4:15 [PATCH] multipath: get right sysfs value for checker_timeout Benjamin Marzinski
@ 2011-10-05 20:45 ` Christophe Varoqui
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Varoqui @ 2011-10-05 20:45 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: device-mapper development
On mar., 2011-10-04 at 23:15 -0500, Benjamin Marzinski wrote:
> sysfs_get_timeout() wasn't looking in the correct directory for the
> checker timeout value. It was looking at .../block/<devname>/timeout,
> instead of .../block/<devname>/device/timeout
>
Merged.
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/discovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: multipath-tools-110916/libmultipath/discovery.c
> ===================================================================
> --- multipath-tools-110916.orig/libmultipath/discovery.c
> +++ multipath-tools-110916/libmultipath/discovery.c
> @@ -166,7 +166,7 @@ sysfs_get_timeout(struct sysfs_device *d
> if (safe_sprintf(attr_path, "%s/device", dev->devpath))
> return 1;
>
> - len = sysfs_attr_get_value(dev->devpath, "timeout", attr, NAME_SIZE);
> + len = sysfs_attr_get_value(attr_path, "timeout", attr, NAME_SIZE);
> if (!len) {
> condlog(3, "%s: No timeout value in sysfs", dev->devpath);
> return 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-05 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-05 4:15 [PATCH] multipath: get right sysfs value for checker_timeout Benjamin Marzinski
2011-10-05 20:45 ` Christophe Varoqui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.