* [PATCH] nvfx: fix nv3x fallout from state validation changes
@ 2012-01-24 8:54 Lucas Stach
2012-01-26 19:59 ` Patrice Mandin
0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2012-01-24 8:54 UTC (permalink / raw)
To: Patrice Mandin, Marek Olšák; +Cc: Nouveau Dev List
From c998f732d42da5e962fe5da294493132c3e8dc5f Mon Sep 17 00:00:00 2001
From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Date: Tue, 24 Jan 2012 09:46:32 +0100
Subject: [PATCH] nvfx: fix nv3x fallout from state validation changes
Apparently nv3x needs some curde hacks to work properly. This
is clearly not the right fix, but it's the behaviour of the old
code and fixes regressions seen by users.
---
src/gallium/drivers/nvfx/nvfx_state_emit.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/src/gallium/drivers/nvfx/nvfx_state_emit.c b/src/gallium/drivers/nvfx/nvfx_state_emit.c
index a959015..60ed2d0 100644
--- a/src/gallium/drivers/nvfx/nvfx_state_emit.c
+++ b/src/gallium/drivers/nvfx/nvfx_state_emit.c
@@ -244,6 +244,9 @@ nvfx_state_validate_common(struct nvfx_context *nvfx)
}
if(dirty & NVFX_NEW_SAMPLER) {
+ /* XXX: we take the big hammer here, I have no idea why this is needed
+ to make this work properly */
+ nvfx->dirty &= ~NVFX_NEW_SAMPLER;
nvfx_fragtex_validate(nvfx);
// TODO: only set this if really necessary
@@ -303,7 +306,8 @@ nvfx_state_validate_common(struct nvfx_context *nvfx)
if(dirty & NVFX_NEW_SR)
nvfx_state_sr_validate(nvfx);
- if(dirty & NVFX_NEW_VIEWPORT)
+ /* XXX: nv3x needs viewport revalidation after RAST or ZSA change */
+ if(dirty & (NVFX_NEW_VIEWPORT | NVFX_NEW_RAST | NVFX_NEW_ZSA))
{
nvfx_state_viewport_validate(nvfx);
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nvfx: fix nv3x fallout from state validation changes
2012-01-24 8:54 [PATCH] nvfx: fix nv3x fallout from state validation changes Lucas Stach
@ 2012-01-26 19:59 ` Patrice Mandin
[not found] ` <20120126205942.7416fabb.mandin.patrice-1tsiiZ//OF9QFI55V6+gNQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Patrice Mandin @ 2012-01-26 19:59 UTC (permalink / raw)
To: Lucas Stach; +Cc: Nouveau Dev List, Marek Olšák
Le Tue, 24 Jan 2012 09:54:31 +0100
Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> a écrit:
> From c998f732d42da5e962fe5da294493132c3e8dc5f Mon Sep 17 00:00:00 2001
> From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
> Date: Tue, 24 Jan 2012 09:46:32 +0100
> Subject: [PATCH] nvfx: fix nv3x fallout from state validation changes
>
> Apparently nv3x needs some curde hacks to work properly. This
> is clearly not the right fix, but it's the behaviour of the old
> code and fixes regressions seen by users.
Hello,
Sorry Lucas, but I finally found a test case I have forgotten, that
would maybe need reverting your patches.
In mesa-demos/src/demos you'll find fbo_firecube test program that have
the scene misrenderered (the scene part that is rendered and used as
texture on the cube).
As far as I remember now, render temp stuff was used to handle fbo
combinations supported on nv40 but not on nv30, or something like that.
--
Patrice Mandin
WWW: http://pmandin.atari.org/
Programmeur Linux, Atari
Spécialité: Développement, jeux
"who writes the code, decides"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-30 18:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 8:54 [PATCH] nvfx: fix nv3x fallout from state validation changes Lucas Stach
2012-01-26 19:59 ` Patrice Mandin
[not found] ` <20120126205942.7416fabb.mandin.patrice-1tsiiZ//OF9QFI55V6+gNQ@public.gmane.org>
2012-01-30 18:35 ` Lucas Stach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.