Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote:
> Hi Tomi,

> > Benoit, do you think we'll get the MODULEMODE mess cleaned up in the
> > hwmod/clk framework at some point, and the drivers could do without
> > these kinds of hacks? =)
> 
> The best way to fix that for my point of view is to go to device tree 
> or/and to consider the DSS as the parent of all the DSS modules.
> pm_runtime will then always ensure that the parent is enabled before any 
> of the child are used.

Ah, right. Sounds fine to me.

But is that a proper "fix"? Are we sure the MODULEMODE will then always
be handled correctly? Isn't the core problem still there, it just
doesn't happen with the setup anymore?

I mean, if we have these special requirements regarding MODULEMODE, and
the code doesn't really know about it, would it get broken easily with
restructuring/changes?

And no, I don't have any clear idea why/how it would break, but I have
just gotten the impression that the MODULEMODE is not handled quite
properly (and so we have these current problems), and having dss_core as
the parent of other dss modules doesn't really fix that in any way.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]