From: "Cousson, Benoit" <b-cousson@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Kevin Hilman <khilman@ti.com>, Archit Taneja <a0393947@ti.com>,
linux-omap@vger.kernel.org, linux@arm.linux.org.uk,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled
Date: Thu, 16 Feb 2012 10:16:42 +0000 [thread overview]
Message-ID: <4F3CD78A.9000905@ti.com> (raw)
In-Reply-To: <1329380536.1951.26.camel@deskari>
On 2/16/2012 9:22 AM, Tomi Valkeinen wrote:
> On Wed, 2012-02-15 at 11:59 -0800, Kevin Hilman wrote:
>> "Cousson, Benoit"<b-cousson@ti.com> writes:
>
>>> Kevin,
>>>
>>> Do we still need to set the dev.parent to omap_device_parent?
>>
>> Nope.
>>
>>> I guess the default&platform_bus parent is good enough and
>>> potentially the DSS children should be able to overwrite that.
>>
>> Yes, now that we use PM domains, we don't need it. I just sent a patch
>> to remove omap_device_parent.
>
> But it's still not possible to create a custom parent-child hierarchy
> with omap_devices. Or can I change the parent of a platform_device after
> it has been created? (doesn't sound very clean even if I can)
Nope, it has to be done before platform_device_add.
Thanks to Ohad patch [1] that Tony has just resent, you can use the
internal omap_device API and thus will be able to change the parent
before the registration.
Benoit
[1] ARM: OMAP: omap_device: Expose omap_device_{alloc, delete, register}
WARNING: multiple messages have this Message-ID (diff)
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Kevin Hilman <khilman@ti.com>, Archit Taneja <a0393947@ti.com>,
linux-omap@vger.kernel.org, linux@arm.linux.org.uk,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled
Date: Thu, 16 Feb 2012 11:16:42 +0100 [thread overview]
Message-ID: <4F3CD78A.9000905@ti.com> (raw)
In-Reply-To: <1329380536.1951.26.camel@deskari>
On 2/16/2012 9:22 AM, Tomi Valkeinen wrote:
> On Wed, 2012-02-15 at 11:59 -0800, Kevin Hilman wrote:
>> "Cousson, Benoit"<b-cousson@ti.com> writes:
>
>>> Kevin,
>>>
>>> Do we still need to set the dev.parent to omap_device_parent?
>>
>> Nope.
>>
>>> I guess the default&platform_bus parent is good enough and
>>> potentially the DSS children should be able to overwrite that.
>>
>> Yes, now that we use PM domains, we don't need it. I just sent a patch
>> to remove omap_device_parent.
>
> But it's still not possible to create a custom parent-child hierarchy
> with omap_devices. Or can I change the parent of a platform_device after
> it has been created? (doesn't sound very clean even if I can)
Nope, it has to be done before platform_device_add.
Thanks to Ohad patch [1] that Tony has just resent, you can use the
internal omap_device API and thus will be able to change the parent
before the registration.
Benoit
[1] ARM: OMAP: omap_device: Expose omap_device_{alloc, delete, register}
next prev parent reply other threads:[~2012-02-16 10:16 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 6:15 [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled Archit Taneja
2012-02-10 6:27 ` Archit Taneja
2012-02-14 11:57 ` Tomi Valkeinen
2012-02-14 11:57 ` Tomi Valkeinen
2012-02-14 12:58 ` Cousson, Benoit
2012-02-14 12:58 ` Cousson, Benoit
2012-02-14 13:15 ` Tomi Valkeinen
2012-02-14 13:15 ` Tomi Valkeinen
2012-02-14 13:30 ` Archit Taneja
2012-02-14 13:42 ` Archit Taneja
2012-02-14 13:33 ` Tomi Valkeinen
2012-02-14 13:33 ` Tomi Valkeinen
2012-02-14 13:45 ` Archit Taneja
2012-02-14 13:57 ` Archit Taneja
2012-02-14 16:02 ` Cousson, Benoit
2012-02-14 16:02 ` Cousson, Benoit
2012-02-14 16:59 ` Shilimkar, Santosh
2012-02-14 16:59 ` Shilimkar, Santosh
2012-02-14 19:42 ` Archit Taneja
2012-02-14 19:54 ` Archit Taneja
2012-02-14 15:41 ` Cousson, Benoit
2012-02-14 15:41 ` Cousson, Benoit
2012-02-15 12:01 ` Archit Taneja
2012-02-15 12:13 ` Archit Taneja
2012-02-15 12:35 ` Cousson, Benoit
2012-02-15 12:35 ` Cousson, Benoit
2012-02-15 12:51 ` Tomi Valkeinen
2012-02-15 12:51 ` Tomi Valkeinen
2012-02-15 13:04 ` Cousson, Benoit
2012-02-15 13:04 ` Cousson, Benoit
2012-02-15 19:59 ` Kevin Hilman
2012-02-15 19:59 ` Kevin Hilman
2012-02-16 8:22 ` Tomi Valkeinen
2012-02-16 8:22 ` Tomi Valkeinen
2012-02-16 10:16 ` Cousson, Benoit [this message]
2012-02-16 10:16 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3CD78A.9000905@ti.com \
--to=b-cousson@ti.com \
--cc=a0393947@ti.com \
--cc=khilman@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.