From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware
Date: Sat, 24 Mar 2012 12:52:54 +0000 [thread overview]
Message-ID: <1332593574.16159.31.camel@twins> (raw)
In-Reply-To: <20120324103127.GJ29067@lizard>
On Sat, 2012-03-24 at 14:31 +0400, Anton Vorontsov wrote:
> This is needed so that callers would not get 'context imbalance'
> warnings from the sparse tool.
>
> As a side effect, this patch fixes the following sparse warnings:
>
> CHECK mm/oom_kill.c
> mm/oom_kill.c:201:28: warning: context imbalance in 'oom_badness' -
> unexpected unlock
> include/linux/rcupdate.h:249:30: warning: context imbalance in
> 'dump_tasks' - unexpected unlock
> mm/oom_kill.c:453:9: warning: context imbalance in 'oom_kill_task' -
> unexpected unlock
> CHECK mm/memcontrol.c
> ...
> mm/memcontrol.c:1130:17: warning: context imbalance in
> 'task_in_mem_cgroup' - unexpected unlock
>
> p.s. I know Peter Zijlstra detest the __cond_lock() stuff, but untill
> we have anything better in sparse, let's use it. This particular
> patch helped me to detect one bug that I myself made during
> task->mm fixup series. So, it is useful.
Yeah, so Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Also, why didn't lockdep catch it?
Fix sparse already instead of smearing ugly all over.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Richard Weinberger <richard@nod.at>,
Paul Mundt <lethal@linux-sh.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
John Stultz <john.stultz@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware
Date: Sat, 24 Mar 2012 13:52:54 +0100 [thread overview]
Message-ID: <1332593574.16159.31.camel@twins> (raw)
In-Reply-To: <20120324103127.GJ29067@lizard>
On Sat, 2012-03-24 at 14:31 +0400, Anton Vorontsov wrote:
> This is needed so that callers would not get 'context imbalance'
> warnings from the sparse tool.
>
> As a side effect, this patch fixes the following sparse warnings:
>
> CHECK mm/oom_kill.c
> mm/oom_kill.c:201:28: warning: context imbalance in 'oom_badness' -
> unexpected unlock
> include/linux/rcupdate.h:249:30: warning: context imbalance in
> 'dump_tasks' - unexpected unlock
> mm/oom_kill.c:453:9: warning: context imbalance in 'oom_kill_task' -
> unexpected unlock
> CHECK mm/memcontrol.c
> ...
> mm/memcontrol.c:1130:17: warning: context imbalance in
> 'task_in_mem_cgroup' - unexpected unlock
>
> p.s. I know Peter Zijlstra detest the __cond_lock() stuff, but untill
> we have anything better in sparse, let's use it. This particular
> patch helped me to detect one bug that I myself made during
> task->mm fixup series. So, it is useful.
Yeah, so Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Also, why didn't lockdep catch it?
Fix sparse already instead of smearing ugly all over.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
user-mode-linux-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, Richard Weinberger <richard@nod.at>,
linuxppc-dev@lists.ozlabs.org, Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Paul Mundt <lethal@linux-sh.org>,
John Stultz <john.stultz@linaro.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware
Date: Sat, 24 Mar 2012 13:52:54 +0100 [thread overview]
Message-ID: <1332593574.16159.31.camel@twins> (raw)
In-Reply-To: <20120324103127.GJ29067@lizard>
On Sat, 2012-03-24 at 14:31 +0400, Anton Vorontsov wrote:
> This is needed so that callers would not get 'context imbalance'
> warnings from the sparse tool.
>=20
> As a side effect, this patch fixes the following sparse warnings:
>=20
> CHECK mm/oom_kill.c
> mm/oom_kill.c:201:28: warning: context imbalance in 'oom_badness' -
> unexpected unlock
> include/linux/rcupdate.h:249:30: warning: context imbalance in
> 'dump_tasks' - unexpected unlock
> mm/oom_kill.c:453:9: warning: context imbalance in 'oom_kill_task' -
> unexpected unlock
> CHECK mm/memcontrol.c
> ...
> mm/memcontrol.c:1130:17: warning: context imbalance in
> 'task_in_mem_cgroup' - unexpected unlock
>=20
> p.s. I know Peter Zijlstra detest the __cond_lock() stuff, but untill
> we have anything better in sparse, let's use it. This particular
> patch helped me to detect one bug that I myself made during
> task->mm fixup series. So, it is useful.
Yeah, so Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Also, why didn't lockdep catch it?
Fix sparse already instead of smearing ugly all over.
WARNING: multiple messages have this Message-ID (diff)
From: a.p.zijlstra@chello.nl (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware
Date: Sat, 24 Mar 2012 13:52:54 +0100 [thread overview]
Message-ID: <1332593574.16159.31.camel@twins> (raw)
In-Reply-To: <20120324103127.GJ29067@lizard>
On Sat, 2012-03-24 at 14:31 +0400, Anton Vorontsov wrote:
> This is needed so that callers would not get 'context imbalance'
> warnings from the sparse tool.
>
> As a side effect, this patch fixes the following sparse warnings:
>
> CHECK mm/oom_kill.c
> mm/oom_kill.c:201:28: warning: context imbalance in 'oom_badness' -
> unexpected unlock
> include/linux/rcupdate.h:249:30: warning: context imbalance in
> 'dump_tasks' - unexpected unlock
> mm/oom_kill.c:453:9: warning: context imbalance in 'oom_kill_task' -
> unexpected unlock
> CHECK mm/memcontrol.c
> ...
> mm/memcontrol.c:1130:17: warning: context imbalance in
> 'task_in_mem_cgroup' - unexpected unlock
>
> p.s. I know Peter Zijlstra detest the __cond_lock() stuff, but untill
> we have anything better in sparse, let's use it. This particular
> patch helped me to detect one bug that I myself made during
> task->mm fixup series. So, it is useful.
Yeah, so Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Also, why didn't lockdep catch it?
Fix sparse already instead of smearing ugly all over.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Richard Weinberger <richard@nod.at>,
Paul Mundt <lethal@linux-sh.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
John Stultz <john.stultz@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware
Date: Sat, 24 Mar 2012 13:52:54 +0100 [thread overview]
Message-ID: <1332593574.16159.31.camel@twins> (raw)
In-Reply-To: <20120324103127.GJ29067@lizard>
On Sat, 2012-03-24 at 14:31 +0400, Anton Vorontsov wrote:
> This is needed so that callers would not get 'context imbalance'
> warnings from the sparse tool.
>
> As a side effect, this patch fixes the following sparse warnings:
>
> CHECK mm/oom_kill.c
> mm/oom_kill.c:201:28: warning: context imbalance in 'oom_badness' -
> unexpected unlock
> include/linux/rcupdate.h:249:30: warning: context imbalance in
> 'dump_tasks' - unexpected unlock
> mm/oom_kill.c:453:9: warning: context imbalance in 'oom_kill_task' -
> unexpected unlock
> CHECK mm/memcontrol.c
> ...
> mm/memcontrol.c:1130:17: warning: context imbalance in
> 'task_in_mem_cgroup' - unexpected unlock
>
> p.s. I know Peter Zijlstra detest the __cond_lock() stuff, but untill
> we have anything better in sparse, let's use it. This particular
> patch helped me to detect one bug that I myself made during
> task->mm fixup series. So, it is useful.
Yeah, so Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Also, why didn't lockdep catch it?
Fix sparse already instead of smearing ugly all over.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-24 12:52 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 10:26 [PATCH v2 0/10] Fixes for common mistakes w/ for_each_process and task->mm Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:27 ` [PATCH 01/10] cpu: Introduce clear_tasks_mm_cpumask() helper Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 16:43 ` [PATCH v2.1 " Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-24 10:28 ` [PATCH 02/10] arm: Use clear_tasks_mm_cpumask() Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` [PATCH 03/10] powerpc: " Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` [PATCH 04/10] sh: " Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:29 ` [PATCH 05/10] blackfin: A couple of task->mm handling fixes Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:30 ` [PATCH 06/10] blackfin: Fix possible deadlock in decode_address() Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` [PATCH 07/10] um: Should hold tasklist_lock while traversing processes Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 10:30 ` [PATCH 08/10] um: Fix possible race on task->mm Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 10:31 ` [PATCH 09/10] um: Properly check all process' threads for a live mm Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 10:31 ` [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 12:52 ` Peter Zijlstra [this message]
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332593574.16159.31.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.