From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes
Date: Sat, 24 Mar 2012 16:43:35 +0000 [thread overview]
Message-ID: <20120324164335.GA4955@lizard> (raw)
In-Reply-To: <1332593303.16159.28.camel@twins>
On Sat, Mar 24, 2012 at 01:48:23PM +0100, Peter Zijlstra wrote:
> On Sat, 2012-03-24 at 14:30 +0400, Anton Vorontsov wrote:
> > Traversing the tasks requires holding tasklist_lock, otherwise it
> > is unsafe.
>
> No it doesn't, it either requires tasklist_lock or rcu_read_lock().
Well, currently the code does neither. :-)
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Richard Weinberger <richard@nod.at>,
Paul Mundt <lethal@linux-sh.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
John Stultz <john.stultz@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes
Date: Sat, 24 Mar 2012 20:43:35 +0400 [thread overview]
Message-ID: <20120324164335.GA4955@lizard> (raw)
In-Reply-To: <1332593303.16159.28.camel@twins>
On Sat, Mar 24, 2012 at 01:48:23PM +0100, Peter Zijlstra wrote:
> On Sat, 2012-03-24 at 14:30 +0400, Anton Vorontsov wrote:
> > Traversing the tasks requires holding tasklist_lock, otherwise it
> > is unsafe.
>
> No it doesn't, it either requires tasklist_lock or rcu_read_lock().
Well, currently the code does neither. :-)
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Frysinger <vapier@gentoo.org>,
user-mode-linux-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, Richard Weinberger <richard@nod.at>,
linuxppc-dev@lists.ozlabs.org, Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Paul Mundt <lethal@linux-sh.org>,
John Stultz <john.stultz@linaro.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes
Date: Sat, 24 Mar 2012 20:43:35 +0400 [thread overview]
Message-ID: <20120324164335.GA4955@lizard> (raw)
In-Reply-To: <1332593303.16159.28.camel@twins>
On Sat, Mar 24, 2012 at 01:48:23PM +0100, Peter Zijlstra wrote:
> On Sat, 2012-03-24 at 14:30 +0400, Anton Vorontsov wrote:
> > Traversing the tasks requires holding tasklist_lock, otherwise it
> > is unsafe.
>
> No it doesn't, it either requires tasklist_lock or rcu_read_lock().
Well, currently the code does neither. :-)
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: anton.vorontsov@linaro.org (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes
Date: Sat, 24 Mar 2012 20:43:35 +0400 [thread overview]
Message-ID: <20120324164335.GA4955@lizard> (raw)
In-Reply-To: <1332593303.16159.28.camel@twins>
On Sat, Mar 24, 2012 at 01:48:23PM +0100, Peter Zijlstra wrote:
> On Sat, 2012-03-24 at 14:30 +0400, Anton Vorontsov wrote:
> > Traversing the tasks requires holding tasklist_lock, otherwise it
> > is unsafe.
>
> No it doesn't, it either requires tasklist_lock or rcu_read_lock().
Well, currently the code does neither. :-)
--
Anton Vorontsov
Email: cbouatmailru at gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Richard Weinberger <richard@nod.at>,
Paul Mundt <lethal@linux-sh.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
John Stultz <john.stultz@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes
Date: Sat, 24 Mar 2012 20:43:35 +0400 [thread overview]
Message-ID: <20120324164335.GA4955@lizard> (raw)
In-Reply-To: <1332593303.16159.28.camel@twins>
On Sat, Mar 24, 2012 at 01:48:23PM +0100, Peter Zijlstra wrote:
> On Sat, 2012-03-24 at 14:30 +0400, Anton Vorontsov wrote:
> > Traversing the tasks requires holding tasklist_lock, otherwise it
> > is unsafe.
>
> No it doesn't, it either requires tasklist_lock or rcu_read_lock().
Well, currently the code does neither. :-)
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-24 16:43 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 10:26 [PATCH v2 0/10] Fixes for common mistakes w/ for_each_process and task->mm Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:26 ` Anton Vorontsov
2012-03-24 10:27 ` [PATCH 01/10] cpu: Introduce clear_tasks_mm_cpumask() helper Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 10:27 ` Anton Vorontsov
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 12:43 ` Peter Zijlstra
2012-03-24 16:43 ` [PATCH v2.1 " Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-25 17:42 ` Oleg Nesterov
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 7:59 ` Peter Zijlstra
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:04 ` Oleg Nesterov
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-26 17:23 ` Peter Zijlstra
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-28 0:01 ` Benjamin Herrenschmidt
2012-03-24 10:28 ` [PATCH 02/10] arm: Use clear_tasks_mm_cpumask() Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` [PATCH 03/10] powerpc: " Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` [PATCH 04/10] sh: " Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:28 ` Anton Vorontsov
2012-03-24 10:29 ` [PATCH 05/10] blackfin: A couple of task->mm handling fixes Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:29 ` Anton Vorontsov
2012-03-24 10:30 ` [PATCH 06/10] blackfin: Fix possible deadlock in decode_address() Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` [PATCH 07/10] um: Should hold tasklist_lock while traversing processes Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 12:48 ` Peter Zijlstra
2012-03-24 16:43 ` Anton Vorontsov [this message]
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 16:43 ` Anton Vorontsov
2012-03-24 10:30 ` [PATCH 08/10] um: Fix possible race on task->mm Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 10:30 ` Anton Vorontsov
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 10:31 ` [PATCH 09/10] um: Properly check all process' threads for a live mm Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 11:12 ` Richard Weinberger
2012-03-24 10:31 ` [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 10:31 ` Anton Vorontsov
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 12:52 ` Peter Zijlstra
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:21 ` Anton Vorontsov
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-24 16:43 ` Peter Zijlstra
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
2012-03-28 7:20 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324164335.GA4955@lizard \
--to=anton.vorontsov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.