All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Nitin Gupta <ngupta@vflare.org>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Minchan Kim <minchan@kernel.org>
Subject: [PATCH 1/6] zsmalloc: use PageFlag macro instead of [set|test]_bit
Date: Wed, 25 Apr 2012 15:23:09 +0900	[thread overview]
Message-ID: <1335334994-22138-2-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1335334994-22138-1-git-send-email-minchan@kernel.org>

MM code always uses PageXXX to handle page flags.
Let's keep the consistency.

Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 drivers/staging/zsmalloc/zsmalloc-main.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
index 917461c..504b6c2 100644
--- a/drivers/staging/zsmalloc/zsmalloc-main.c
+++ b/drivers/staging/zsmalloc/zsmalloc-main.c
@@ -45,12 +45,12 @@ static DEFINE_PER_CPU(struct mapping_area, zs_map_area);
 
 static int is_first_page(struct page *page)
 {
-	return test_bit(PG_private, &page->flags);
+	return PagePrivate(page);
 }
 
 static int is_last_page(struct page *page)
 {
-	return test_bit(PG_private_2, &page->flags);
+	return PagePrivate2(page);
 }
 
 static void get_zspage_mapping(struct page *page, unsigned int *class_idx,
@@ -377,7 +377,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
 
 		INIT_LIST_HEAD(&page->lru);
 		if (i == 0) {	/* first page */
-			set_bit(PG_private, &page->flags);
+			SetPagePrivate(page);
 			set_page_private(page, 0);
 			first_page = page;
 			first_page->inuse = 0;
@@ -389,8 +389,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
 		if (i >= 2)
 			list_add(&page->lru, &prev_page->lru);
 		if (i == class->zspage_order - 1)	/* last page */
-			set_bit(PG_private_2, &page->flags);
-
+			SetPagePrivate2(page);
 		prev_page = page;
 	}
 
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Nitin Gupta <ngupta@vflare.org>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Minchan Kim <minchan@kernel.org>
Subject: [PATCH 1/6] zsmalloc: use PageFlag macro instead of [set|test]_bit
Date: Wed, 25 Apr 2012 15:23:09 +0900	[thread overview]
Message-ID: <1335334994-22138-2-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1335334994-22138-1-git-send-email-minchan@kernel.org>

MM code always uses PageXXX to handle page flags.
Let's keep the consistency.

Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 drivers/staging/zsmalloc/zsmalloc-main.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
index 917461c..504b6c2 100644
--- a/drivers/staging/zsmalloc/zsmalloc-main.c
+++ b/drivers/staging/zsmalloc/zsmalloc-main.c
@@ -45,12 +45,12 @@ static DEFINE_PER_CPU(struct mapping_area, zs_map_area);
 
 static int is_first_page(struct page *page)
 {
-	return test_bit(PG_private, &page->flags);
+	return PagePrivate(page);
 }
 
 static int is_last_page(struct page *page)
 {
-	return test_bit(PG_private_2, &page->flags);
+	return PagePrivate2(page);
 }
 
 static void get_zspage_mapping(struct page *page, unsigned int *class_idx,
@@ -377,7 +377,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
 
 		INIT_LIST_HEAD(&page->lru);
 		if (i == 0) {	/* first page */
-			set_bit(PG_private, &page->flags);
+			SetPagePrivate(page);
 			set_page_private(page, 0);
 			first_page = page;
 			first_page->inuse = 0;
@@ -389,8 +389,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
 		if (i >= 2)
 			list_add(&page->lru, &prev_page->lru);
 		if (i == class->zspage_order - 1)	/* last page */
-			set_bit(PG_private_2, &page->flags);
-
+			SetPagePrivate2(page);
 		prev_page = page;
 	}
 
-- 
1.7.9.5


  reply	other threads:[~2012-04-25  6:22 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25  6:23 [PATCH 0/6] zsmalloc: clean up and fix arch dependency Minchan Kim
2012-04-25  6:23 ` Minchan Kim
2012-04-25  6:23 ` Minchan Kim [this message]
2012-04-25  6:23   ` [PATCH 1/6] zsmalloc: use PageFlag macro instead of [set|test]_bit Minchan Kim
2012-04-25 12:43   ` Nitin Gupta
2012-04-25 12:43     ` Nitin Gupta
2012-04-25  6:23 ` [PATCH 2/6] zsmalloc: remove unnecessary alignment Minchan Kim
2012-04-25  6:23   ` Minchan Kim
2012-04-25 12:53   ` Nitin Gupta
2012-04-25 12:53     ` Nitin Gupta
2012-04-26  1:42     ` Minchan Kim
2012-04-26  1:42       ` Minchan Kim
2012-05-03  5:16       ` Nitin Gupta
2012-05-03  5:16         ` Nitin Gupta
2012-04-25  6:23 ` [PATCH 3/6] zsmalloc: rename zspage_order with zspage_pages Minchan Kim
2012-04-25  6:23   ` Minchan Kim
2012-04-25 13:03   ` Nitin Gupta
2012-04-25 13:03     ` Nitin Gupta
2012-04-26  1:46     ` Minchan Kim
2012-04-26  1:46       ` Minchan Kim
2012-04-25  6:23 ` [PATCH 4/6] zsmalloc: add/fix function comment Minchan Kim
2012-04-25  6:23   ` Minchan Kim
2012-04-25 13:27   ` Nitin Gupta
2012-04-25 13:27     ` Nitin Gupta
2012-04-26  1:51     ` Minchan Kim
2012-04-26  1:51       ` Minchan Kim
2012-04-25  6:23 ` [PATCH 5/6] zsmalloc: remove unnecessary type casting Minchan Kim
2012-04-25  6:23   ` Minchan Kim
2012-04-25 13:35   ` Nitin Gupta
2012-04-25 13:35     ` Nitin Gupta
2012-04-25 17:56     ` Greg Kroah-Hartman
2012-04-25 17:56       ` Greg Kroah-Hartman
2012-04-25 18:13       ` Nitin Gupta
2012-04-25 18:13         ` Nitin Gupta
2012-04-26  1:58     ` Minchan Kim
2012-04-26  1:58       ` Minchan Kim
2012-04-25  6:23 ` [PATCH 6/6] zsmalloc: make zsmalloc portable Minchan Kim
2012-04-25  6:23   ` Minchan Kim
2012-04-25 14:32   ` Nitin Gupta
2012-04-25 14:32     ` Nitin Gupta
2012-04-25 15:40     ` Dan Magenheimer
2012-04-25 15:40       ` Dan Magenheimer
2012-04-26  2:03       ` Minchan Kim
2012-04-26  2:03         ` Minchan Kim
2012-04-26  5:07         ` Minchan Kim
2012-04-26  5:07           ` Minchan Kim
2012-04-30 16:24           ` Seth Jennings
2012-04-30 16:24             ` Seth Jennings
2012-04-25 16:37     ` Seth Jennings
2012-04-25 16:37       ` Seth Jennings
2012-04-26  2:04       ` Minchan Kim
2012-04-26  2:04         ` Minchan Kim
2012-05-07 15:14       ` Seth Jennings
2012-05-07 15:14         ` Seth Jennings
2012-05-08  0:46         ` Minchan Kim
2012-05-08  0:46           ` Minchan Kim
2012-04-26  2:11   ` Minchan Kim
2012-04-26  2:11     ` Minchan Kim
2012-04-25 12:41 ` [PATCH 0/6] zsmalloc: clean up and fix arch dependency Nitin Gupta
2012-04-25 12:41   ` Nitin Gupta
2012-04-26  1:20   ` Minchan Kim
2012-04-26  1:20     ` Minchan Kim
2012-04-25 18:14 ` Greg Kroah-Hartman
2012-04-25 18:14   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335334994-22138-2-git-send-email-minchan@kernel.org \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.