Re: [PATCH 0/6] zsmalloc: clean up and fix arch dependency

[Minchan Kim <minchan@kernel.org>]

Hi Nitin,

On 04/25/2012 09:41 PM, Nitin Gupta wrote:

> Hi Minchan,
> 
> On 04/25/2012 02:23 AM, Minchan Kim wrote:
> 
>> This patchset has some clean up patches(1-5) and remove 
>> set_bit, flush_tlb for portability in [6/6].
>>
>> Minchan Kim (6):
>>   zsmalloc: use PageFlag macro instead of [set|test]_bit
>>   zsmalloc: remove unnecessary alignment
>>   zsmalloc: rename zspage_order with zspage_pages
>>   zsmalloc: add/fix function comment
>>   zsmalloc: remove unnecessary type casting
>>   zsmalloc: make zsmalloc portable
>>
>>  drivers/staging/zsmalloc/Kconfig         |    4 --
>>  drivers/staging/zsmalloc/zsmalloc-main.c |   73 +++++++++++++++++-------------
>>  drivers/staging/zsmalloc/zsmalloc_int.h  |    3 +-
>>  3 files changed, 43 insertions(+), 37 deletions(-)
>>
> 
> 
> Thanks for the fixes.
> 
> 
> Your description is missing testing notes (especially since patch [6/6]
> is not a cosmetic change). So, can you please add these either here in
> patch 0 or as part of patch 6/6 description?


Will do in later version.
Test is simply done in x86 and ARM qemu environment with zram so test coverage isn't good
but [1-6] is just trivial while [7] is severe. As I see Seth's reply, he could test it enough
and other architecture should work if it works in x86 because we used generic functions.

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>