From: Nitin Gupta <ngupta@vflare.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/6] zsmalloc: clean up and fix arch dependency
Date: Wed, 25 Apr 2012 08:41:21 -0400 [thread overview]
Message-ID: <4F97F0F1.2000506@vflare.org> (raw)
In-Reply-To: <1335334994-22138-1-git-send-email-minchan@kernel.org>
Hi Minchan,
On 04/25/2012 02:23 AM, Minchan Kim wrote:
> This patchset has some clean up patches(1-5) and remove
> set_bit, flush_tlb for portability in [6/6].
>
> Minchan Kim (6):
> zsmalloc: use PageFlag macro instead of [set|test]_bit
> zsmalloc: remove unnecessary alignment
> zsmalloc: rename zspage_order with zspage_pages
> zsmalloc: add/fix function comment
> zsmalloc: remove unnecessary type casting
> zsmalloc: make zsmalloc portable
>
> drivers/staging/zsmalloc/Kconfig | 4 --
> drivers/staging/zsmalloc/zsmalloc-main.c | 73 +++++++++++++++++-------------
> drivers/staging/zsmalloc/zsmalloc_int.h | 3 +-
> 3 files changed, 43 insertions(+), 37 deletions(-)
>
Thanks for the fixes.
Your description is missing testing notes (especially since patch [6/6]
is not a cosmetic change). So, can you please add these either here in
patch 0 or as part of patch 6/6 description?
Thanks,
Nitin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Nitin Gupta <ngupta@vflare.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/6] zsmalloc: clean up and fix arch dependency
Date: Wed, 25 Apr 2012 08:41:21 -0400 [thread overview]
Message-ID: <4F97F0F1.2000506@vflare.org> (raw)
In-Reply-To: <1335334994-22138-1-git-send-email-minchan@kernel.org>
Hi Minchan,
On 04/25/2012 02:23 AM, Minchan Kim wrote:
> This patchset has some clean up patches(1-5) and remove
> set_bit, flush_tlb for portability in [6/6].
>
> Minchan Kim (6):
> zsmalloc: use PageFlag macro instead of [set|test]_bit
> zsmalloc: remove unnecessary alignment
> zsmalloc: rename zspage_order with zspage_pages
> zsmalloc: add/fix function comment
> zsmalloc: remove unnecessary type casting
> zsmalloc: make zsmalloc portable
>
> drivers/staging/zsmalloc/Kconfig | 4 --
> drivers/staging/zsmalloc/zsmalloc-main.c | 73 +++++++++++++++++-------------
> drivers/staging/zsmalloc/zsmalloc_int.h | 3 +-
> 3 files changed, 43 insertions(+), 37 deletions(-)
>
Thanks for the fixes.
Your description is missing testing notes (especially since patch [6/6]
is not a cosmetic change). So, can you please add these either here in
patch 0 or as part of patch 6/6 description?
Thanks,
Nitin
next prev parent reply other threads:[~2012-04-25 12:41 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 6:23 [PATCH 0/6] zsmalloc: clean up and fix arch dependency Minchan Kim
2012-04-25 6:23 ` Minchan Kim
2012-04-25 6:23 ` [PATCH 1/6] zsmalloc: use PageFlag macro instead of [set|test]_bit Minchan Kim
2012-04-25 6:23 ` Minchan Kim
2012-04-25 12:43 ` Nitin Gupta
2012-04-25 12:43 ` Nitin Gupta
2012-04-25 6:23 ` [PATCH 2/6] zsmalloc: remove unnecessary alignment Minchan Kim
2012-04-25 6:23 ` Minchan Kim
2012-04-25 12:53 ` Nitin Gupta
2012-04-25 12:53 ` Nitin Gupta
2012-04-26 1:42 ` Minchan Kim
2012-04-26 1:42 ` Minchan Kim
2012-05-03 5:16 ` Nitin Gupta
2012-05-03 5:16 ` Nitin Gupta
2012-04-25 6:23 ` [PATCH 3/6] zsmalloc: rename zspage_order with zspage_pages Minchan Kim
2012-04-25 6:23 ` Minchan Kim
2012-04-25 13:03 ` Nitin Gupta
2012-04-25 13:03 ` Nitin Gupta
2012-04-26 1:46 ` Minchan Kim
2012-04-26 1:46 ` Minchan Kim
2012-04-25 6:23 ` [PATCH 4/6] zsmalloc: add/fix function comment Minchan Kim
2012-04-25 6:23 ` Minchan Kim
2012-04-25 13:27 ` Nitin Gupta
2012-04-25 13:27 ` Nitin Gupta
2012-04-26 1:51 ` Minchan Kim
2012-04-26 1:51 ` Minchan Kim
2012-04-25 6:23 ` [PATCH 5/6] zsmalloc: remove unnecessary type casting Minchan Kim
2012-04-25 6:23 ` Minchan Kim
2012-04-25 13:35 ` Nitin Gupta
2012-04-25 13:35 ` Nitin Gupta
2012-04-25 17:56 ` Greg Kroah-Hartman
2012-04-25 17:56 ` Greg Kroah-Hartman
2012-04-25 18:13 ` Nitin Gupta
2012-04-25 18:13 ` Nitin Gupta
2012-04-26 1:58 ` Minchan Kim
2012-04-26 1:58 ` Minchan Kim
2012-04-25 6:23 ` [PATCH 6/6] zsmalloc: make zsmalloc portable Minchan Kim
2012-04-25 6:23 ` Minchan Kim
2012-04-25 14:32 ` Nitin Gupta
2012-04-25 14:32 ` Nitin Gupta
2012-04-25 15:40 ` Dan Magenheimer
2012-04-25 15:40 ` Dan Magenheimer
2012-04-26 2:03 ` Minchan Kim
2012-04-26 2:03 ` Minchan Kim
2012-04-26 5:07 ` Minchan Kim
2012-04-26 5:07 ` Minchan Kim
2012-04-30 16:24 ` Seth Jennings
2012-04-30 16:24 ` Seth Jennings
2012-04-25 16:37 ` Seth Jennings
2012-04-25 16:37 ` Seth Jennings
2012-04-26 2:04 ` Minchan Kim
2012-04-26 2:04 ` Minchan Kim
2012-05-07 15:14 ` Seth Jennings
2012-05-07 15:14 ` Seth Jennings
2012-05-08 0:46 ` Minchan Kim
2012-05-08 0:46 ` Minchan Kim
2012-04-26 2:11 ` Minchan Kim
2012-04-26 2:11 ` Minchan Kim
2012-04-25 12:41 ` Nitin Gupta [this message]
2012-04-25 12:41 ` [PATCH 0/6] zsmalloc: clean up and fix arch dependency Nitin Gupta
2012-04-26 1:20 ` Minchan Kim
2012-04-26 1:20 ` Minchan Kim
2012-04-25 18:14 ` Greg Kroah-Hartman
2012-04-25 18:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F97F0F1.2000506@vflare.org \
--to=ngupta@vflare.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.