From: Artem Bityutskiy <dedekind1@gmail.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: hongxu.cn@gmail.com, nicolas.ferre@atmel.com,
linux-mtd@lists.infradead.org, ivan.djelic@parrot.com,
plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 1/3] MTD: at91: extract hw ecc initialization to one function and use relaxed read/write
Date: Sun, 27 May 2012 15:44:28 +0300 [thread overview]
Message-ID: <1338122668.19389.4.camel@koala> (raw)
In-Reply-To: <1338038677-6752-2-git-send-email-josh.wu@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On Sat, 2012-05-26 at 21:24 +0800, Josh Wu wrote:
> use _relaxed read/write in most place. And use writel in operations of Control Register since it needs memory barrier.
>
> Signed-off-by: Hong Xu <hong.xu@atmel.com>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
This should be split on 2 or even 3 parts:
1. You move definitions and things around.
2. You separate out the init stuff into a function
3. You start using _relaxed helpers.
And you should provide better commit messages. You should explain why
you do things - just cleanup? improvement? fix? preparation for
something?
I think this patch is too big, commit message is poor, patch does more
things than documented in the commit message.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 1/3] MTD: at91: extract hw ecc initialization to one function and use relaxed read/write
Date: Sun, 27 May 2012 15:44:28 +0300 [thread overview]
Message-ID: <1338122668.19389.4.camel@koala> (raw)
In-Reply-To: <1338038677-6752-2-git-send-email-josh.wu@atmel.com>
On Sat, 2012-05-26 at 21:24 +0800, Josh Wu wrote:
> use _relaxed read/write in most place. And use writel in operations of Control Register since it needs memory barrier.
>
> Signed-off-by: Hong Xu <hong.xu@atmel.com>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
This should be split on 2 or even 3 parts:
1. You move definitions and things around.
2. You separate out the init stuff into a function
3. You start using _relaxed helpers.
And you should provide better commit messages. You should explain why
you do things - just cleanup? improvement? fix? preparation for
something?
I think this patch is too big, commit message is poor, patch does more
things than documented in the commit message.
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120527/5b38f766/attachment.sig>
next prev parent reply other threads:[~2012-05-27 12:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 13:24 [PATCH v9 0/3] MTD: at91: Add PMECC support for at91 nand flash driver Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-26 13:24 ` [PATCH v9 1/3] MTD: at91: extract hw ecc initialization to one function and use relaxed read/write Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-27 12:44 ` Artem Bityutskiy [this message]
2012-05-27 12:44 ` Artem Bityutskiy
2012-05-28 8:50 ` Josh Wu
2012-05-28 8:50 ` Josh Wu
2012-05-26 13:24 ` [PATCH v9 2/3] MTD: at91: add dt parameters for PMECC Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-26 13:24 ` [PATCH v9 3/3] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-27 12:50 ` Artem Bityutskiy
2012-05-27 12:50 ` Artem Bityutskiy
2012-05-28 8:43 ` Josh Wu
2012-05-28 8:43 ` Josh Wu
2012-05-28 6:58 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 6:58 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 8:34 ` Josh Wu
2012-05-28 8:34 ` Josh Wu
2012-05-29 16:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-29 16:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 6:39 ` [PATCH v9 0/3] MTD: at91: Add PMECC support for at91 nand flash driver Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 6:39 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338122668.19389.4.camel@koala \
--to=dedekind1@gmail.com \
--cc=hongxu.cn@gmail.com \
--cc=ivan.djelic@parrot.com \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.