From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: hongxu.cn@gmail.com, dedekind1@gmail.com,
nicolas.ferre@atmel.com, linux-mtd@lists.infradead.org,
ivan.djelic@parrot.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 3/3] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller
Date: Tue, 29 May 2012 18:01:12 +0200 [thread overview]
Message-ID: <20120529160112.GT3377@game.jcrosoft.org> (raw)
In-Reply-To: <4FC3389C.5050303@atmel.com>
> >>+
> >>+static void __iomem *pmecc_get_index_of(struct atmel_nand_host *host)
> >this is a __dev_init function plese check the other too
> >
> >btw you need to use __dev_init and not __init
>
> Here I use pmecc_get_index_of() function to get a lookup table base
> which is in ROM.
> I'm not clear about how should I need __dev_init here. Can you give
> more information?
it is the section where the function is going to be stored
pmecc_get_index_of is use at probe time so it's __devinit section
as it's supposed to be for the probe function too
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 3/3] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller
Date: Tue, 29 May 2012 18:01:12 +0200 [thread overview]
Message-ID: <20120529160112.GT3377@game.jcrosoft.org> (raw)
In-Reply-To: <4FC3389C.5050303@atmel.com>
> >>+
> >>+static void __iomem *pmecc_get_index_of(struct atmel_nand_host *host)
> >this is a __dev_init function plese check the other too
> >
> >btw you need to use __dev_init and not __init
>
> Here I use pmecc_get_index_of() function to get a lookup table base
> which is in ROM.
> I'm not clear about how should I need __dev_init here. Can you give
> more information?
it is the section where the function is going to be stored
pmecc_get_index_of is use at probe time so it's __devinit section
as it's supposed to be for the probe function too
Best Regards,
J.
next prev parent reply other threads:[~2012-05-29 16:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 13:24 [PATCH v9 0/3] MTD: at91: Add PMECC support for at91 nand flash driver Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-26 13:24 ` [PATCH v9 1/3] MTD: at91: extract hw ecc initialization to one function and use relaxed read/write Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-27 12:44 ` Artem Bityutskiy
2012-05-27 12:44 ` Artem Bityutskiy
2012-05-28 8:50 ` Josh Wu
2012-05-28 8:50 ` Josh Wu
2012-05-26 13:24 ` [PATCH v9 2/3] MTD: at91: add dt parameters for PMECC Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-26 13:24 ` [PATCH v9 3/3] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-05-26 13:24 ` Josh Wu
2012-05-27 12:50 ` Artem Bityutskiy
2012-05-27 12:50 ` Artem Bityutskiy
2012-05-28 8:43 ` Josh Wu
2012-05-28 8:43 ` Josh Wu
2012-05-28 6:58 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 6:58 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 8:34 ` Josh Wu
2012-05-28 8:34 ` Josh Wu
2012-05-29 16:01 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-05-29 16:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 6:39 ` [PATCH v9 0/3] MTD: at91: Add PMECC support for at91 nand flash driver Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 6:39 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529160112.GT3377@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=dedekind1@gmail.com \
--cc=hongxu.cn@gmail.com \
--cc=ivan.djelic@parrot.com \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.