From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors <lm-sensors@lm-sensors.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Jean Delvare <khali@linux-fr.org>,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [lm-sensors] [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
Date: Mon, 31 Dec 2012 08:13:08 +0000 [thread overview]
Message-ID: <1356941588-25249-2-git-send-email-linux@roeck-us.net> (raw)
In-Reply-To: <1356941588-25249-1-git-send-email-linux@roeck-us.net>
Rml4Ogp2ZXhwcmVzcy5jOiBJbiBmdW5jdGlvbiDigJh2ZXhwcmVzc19od21vbl9uYW1lX3Nob3fi
gJk6CnZleHByZXNzLmM6MzQ6MjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0
aW9uCuKAmG9mX2dldF9wcm9wZXJ0eeKAmSBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNs
YXJhdGlvbl0KdmV4cHJlc3MuYzozNDoyNzogd2FybmluZzogaW5pdGlhbGl6YXRpb24gbWFrZXMg
cG9pbnRlciBmcm9tIGludGVnZXIKd2l0aG91dCBhIGNhc3QgW2VuYWJsZWQgYnkgZGVmYXVsdF0K
dmV4cHJlc3MuYzogSW4gZnVuY3Rpb24g4oCYdmV4cHJlc3NfaHdtb25fbGFiZWxfc2hvd+KAmToK
dmV4cHJlc3MuYzo0MzoyMjogd2FybmluZzogaW5pdGlhbGl6YXRpb24gbWFrZXMgcG9pbnRlciBm
cm9tIGludGVnZXIKd2l0aG91dCBhIGNhc3QgW2VuYWJsZWQgYnkgZGVmYXVsdF0KClNlZW4gaWYg
Q09ORklHX09GX0RFVklDRSBpcyBub3QgZGVmaW5lZC4gb2ZfZ2V0X3Byb3BlcnR5IGlzIGRlY2xh
cmVkIGluCm9mLmggd2hpY2ggaXMgb25seSBpbmNsdWRlZCBieSBvZl9kZXZpY2UuaCBpZiBDT05G
SUdfT0ZfREVWSUNFIGlzIGRlZmluZWQuCm9mLmggbmVlZHMgdG8gYmUgaW5jbHVkZWQgZGlyZWN0
bHkuCgpTaWduZWQtb2ZmLWJ5OiBHdWVudGVyIFJvZWNrIDxsaW51eEByb2Vjay11cy5uZXQ+Ci0t
LQogZHJpdmVycy9od21vbi92ZXhwcmVzcy5jIHwgICAgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBp
bnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMgYi9kcml2
ZXJzL2h3bW9uL3ZleHByZXNzLmMKaW5kZXggODZkN2Y2ZC4uZDg2N2U2YiAxMDA2NDQKLS0tIGEv
ZHJpdmVycy9od21vbi92ZXhwcmVzcy5jCisrKyBiL2RyaXZlcnMvaHdtb24vdmV4cHJlc3MuYwpA
QCAtMTksNiArMTksNyBAQAogI2luY2x1ZGUgPGxpbnV4L2h3bW9uLmg+CiAjaW5jbHVkZSA8bGlu
dXgvaHdtb24tc3lzZnMuaD4KICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KKyNpbmNsdWRlIDxs
aW51eC9vZi5oPgogI2luY2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgogI2luY2x1ZGUgPGxpbnV4
L3BsYXRmb3JtX2RldmljZS5oPgogI2luY2x1ZGUgPGxpbnV4L3ZleHByZXNzLmg+Ci0tIAoxLjcu
OS43CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0t
c2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlz
dHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors <lm-sensors@lm-sensors.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Jean Delvare <khali@linux-fr.org>,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
Date: Mon, 31 Dec 2012 00:13:08 -0800 [thread overview]
Message-ID: <1356941588-25249-2-git-send-email-linux@roeck-us.net> (raw)
In-Reply-To: <1356941588-25249-1-git-send-email-linux@roeck-us.net>
Fix:
vexpress.c: In function ‘vexpress_hwmon_name_show’:
vexpress.c:34:2: error: implicit declaration of function
‘of_get_property’ [-Werror=implicit-function-declaration]
vexpress.c:34:27: warning: initialization makes pointer from integer
without a cast [enabled by default]
vexpress.c: In function ‘vexpress_hwmon_label_show’:
vexpress.c:43:22: warning: initialization makes pointer from integer
without a cast [enabled by default]
Seen if CONFIG_OF_DEVICE is not defined. of_get_property is declared in
of.h which is only included by of_device.h if CONFIG_OF_DEVICE is defined.
of.h needs to be included directly.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/vexpress.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/vexpress.c b/drivers/hwmon/vexpress.c
index 86d7f6d..d867e6b 100644
--- a/drivers/hwmon/vexpress.c
+++ b/drivers/hwmon/vexpress.c
@@ -19,6 +19,7 @@
#include <linux/hwmon.h>
#include <linux/hwmon-sysfs.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/vexpress.h>
--
1.7.9.7
next prev parent reply other threads:[~2012-12-31 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 8:13 [lm-sensors] [PATCH 1/2] hwmon: (vexpress) Remove __devexit and __devexit_p Guenter Roeck
2012-12-31 8:13 ` Guenter Roeck
2012-12-31 8:13 ` Guenter Roeck [this message]
2012-12-31 8:13 ` [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set Guenter Roeck
2013-01-21 15:19 ` [lm-sensors] " Pawel Moll
2013-01-21 15:19 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356941588-25249-2-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.