From: Pawel Moll <pawel.moll@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: lm-sensors <lm-sensors@lm-sensors.org>,
Jean Delvare <khali@linux-fr.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
Date: Mon, 21 Jan 2013 15:19:58 +0000 [thread overview]
Message-ID: <1358781598.6590.4.camel@hornet> (raw)
In-Reply-To: <1356941588-25249-2-git-send-email-linux@roeck-us.net>
T24gTW9uLCAyMDEyLTEyLTMxIGF0IDA4OjEzICswMDAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+
IEZpeDoKPiB2ZXhwcmVzcy5jOiBJbiBmdW5jdGlvbiDigJh2ZXhwcmVzc19od21vbl9uYW1lX3No
b3figJk6Cj4gdmV4cHJlc3MuYzozNDoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2Yg
ZnVuY3Rpb24KPiDigJhvZl9nZXRfcHJvcGVydHnigJkgWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rp
b24tZGVjbGFyYXRpb25dCj4gdmV4cHJlc3MuYzozNDoyNzogd2FybmluZzogaW5pdGlhbGl6YXRp
b24gbWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIKPiB3aXRob3V0IGEgY2FzdCBbZW5hYmxlZCBi
eSBkZWZhdWx0XQo+IHZleHByZXNzLmM6IEluIGZ1bmN0aW9uIOKAmHZleHByZXNzX2h3bW9uX2xh
YmVsX3Nob3figJk6Cj4gdmV4cHJlc3MuYzo0MzoyMjogd2FybmluZzogaW5pdGlhbGl6YXRpb24g
bWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIKPiB3aXRob3V0IGEgY2FzdCBbZW5hYmxlZCBieSBk
ZWZhdWx0XQo+IAo+IFNlZW4gaWYgQ09ORklHX09GX0RFVklDRSBpcyBub3QgZGVmaW5lZC4gb2Zf
Z2V0X3Byb3BlcnR5IGlzIGRlY2xhcmVkIGluCj4gb2YuaCB3aGljaCBpcyBvbmx5IGluY2x1ZGVk
IGJ5IG9mX2RldmljZS5oIGlmIENPTkZJR19PRl9ERVZJQ0UgaXMgZGVmaW5lZC4KPiBvZi5oIG5l
ZWRzIHRvIGJlIGluY2x1ZGVkIGRpcmVjdGx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEd1ZW50ZXIg
Um9lY2sgPGxpbnV4QHJvZWNrLXVzLm5ldD4KClRoYW5rcywgR3VlbnRlciEgKG9mIGNvdXJzZSBp
dCdzIHdheSB0b28gbGF0ZSBmb3IgQWNrZWQtYnk6IFBhd2VsIE1vbGwKPHBhd2VsLm1vbGxAYXJt
LmNvbT4pCgpQYXdlbAoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9y
ZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz
WARNING: multiple messages have this Message-ID (diff)
From: Pawel Moll <pawel.moll@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: lm-sensors <lm-sensors@lm-sensors.org>,
Jean Delvare <khali@linux-fr.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
Date: Mon, 21 Jan 2013 15:19:58 +0000 [thread overview]
Message-ID: <1358781598.6590.4.camel@hornet> (raw)
In-Reply-To: <1356941588-25249-2-git-send-email-linux@roeck-us.net>
On Mon, 2012-12-31 at 08:13 +0000, Guenter Roeck wrote:
> Fix:
> vexpress.c: In function ‘vexpress_hwmon_name_show’:
> vexpress.c:34:2: error: implicit declaration of function
> ‘of_get_property’ [-Werror=implicit-function-declaration]
> vexpress.c:34:27: warning: initialization makes pointer from integer
> without a cast [enabled by default]
> vexpress.c: In function ‘vexpress_hwmon_label_show’:
> vexpress.c:43:22: warning: initialization makes pointer from integer
> without a cast [enabled by default]
>
> Seen if CONFIG_OF_DEVICE is not defined. of_get_property is declared in
> of.h which is only included by of_device.h if CONFIG_OF_DEVICE is defined.
> of.h needs to be included directly.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Thanks, Guenter! (of course it's way too late for Acked-by: Pawel Moll
<pawel.moll@arm.com>)
Pawel
next prev parent reply other threads:[~2013-01-21 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 8:13 [lm-sensors] [PATCH 1/2] hwmon: (vexpress) Remove __devexit and __devexit_p Guenter Roeck
2012-12-31 8:13 ` Guenter Roeck
2012-12-31 8:13 ` [lm-sensors] [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set Guenter Roeck
2012-12-31 8:13 ` Guenter Roeck
2013-01-21 15:19 ` Pawel Moll [this message]
2013-01-21 15:19 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358781598.6590.4.camel@hornet \
--to=pawel.moll@arm.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.