* [lm-sensors] [PATCH 1/2] hwmon: (vexpress) Remove __devexit and __devexit_p
@ 2012-12-31 8:13 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2012-12-31 8:13 UTC (permalink / raw)
To: lm-sensors; +Cc: Pawel Moll, Jean Delvare, linux-kernel, Guenter Roeck
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/vexpress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/vexpress.c b/drivers/hwmon/vexpress.c
index 59fd126..86d7f6d 100644
--- a/drivers/hwmon/vexpress.c
+++ b/drivers/hwmon/vexpress.c
@@ -196,7 +196,7 @@ error:
return err;
}
-static int __devexit vexpress_hwmon_remove(struct platform_device *pdev)
+static int vexpress_hwmon_remove(struct platform_device *pdev)
{
struct vexpress_hwmon_data *data = platform_get_drvdata(pdev);
const struct of_device_id *match;
@@ -213,7 +213,7 @@ static int __devexit vexpress_hwmon_remove(struct platform_device *pdev)
static struct platform_driver vexpress_hwmon_driver = {
.probe = vexpress_hwmon_probe,
- .remove = __devexit_p(vexpress_hwmon_remove),
+ .remove = vexpress_hwmon_remove,
.driver = {
.name = DRVNAME,
.owner = THIS_MODULE,
--
1.7.9.7
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] hwmon: (vexpress) Remove __devexit and __devexit_p
@ 2012-12-31 8:13 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2012-12-31 8:13 UTC (permalink / raw)
To: lm-sensors; +Cc: Pawel Moll, Jean Delvare, linux-kernel, Guenter Roeck
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/vexpress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/vexpress.c b/drivers/hwmon/vexpress.c
index 59fd126..86d7f6d 100644
--- a/drivers/hwmon/vexpress.c
+++ b/drivers/hwmon/vexpress.c
@@ -196,7 +196,7 @@ error:
return err;
}
-static int __devexit vexpress_hwmon_remove(struct platform_device *pdev)
+static int vexpress_hwmon_remove(struct platform_device *pdev)
{
struct vexpress_hwmon_data *data = platform_get_drvdata(pdev);
const struct of_device_id *match;
@@ -213,7 +213,7 @@ static int __devexit vexpress_hwmon_remove(struct platform_device *pdev)
static struct platform_driver vexpress_hwmon_driver = {
.probe = vexpress_hwmon_probe,
- .remove = __devexit_p(vexpress_hwmon_remove),
+ .remove = vexpress_hwmon_remove,
.driver = {
.name = DRVNAME,
.owner = THIS_MODULE,
--
1.7.9.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [lm-sensors] [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
2012-12-31 8:13 ` Guenter Roeck
@ 2012-12-31 8:13 ` Guenter Roeck
-1 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2012-12-31 8:13 UTC (permalink / raw)
To: lm-sensors; +Cc: Pawel Moll, Jean Delvare, linux-kernel, Guenter Roeck
Rml4Ogp2ZXhwcmVzcy5jOiBJbiBmdW5jdGlvbiDigJh2ZXhwcmVzc19od21vbl9uYW1lX3Nob3fi
gJk6CnZleHByZXNzLmM6MzQ6MjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0
aW9uCuKAmG9mX2dldF9wcm9wZXJ0eeKAmSBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNs
YXJhdGlvbl0KdmV4cHJlc3MuYzozNDoyNzogd2FybmluZzogaW5pdGlhbGl6YXRpb24gbWFrZXMg
cG9pbnRlciBmcm9tIGludGVnZXIKd2l0aG91dCBhIGNhc3QgW2VuYWJsZWQgYnkgZGVmYXVsdF0K
dmV4cHJlc3MuYzogSW4gZnVuY3Rpb24g4oCYdmV4cHJlc3NfaHdtb25fbGFiZWxfc2hvd+KAmToK
dmV4cHJlc3MuYzo0MzoyMjogd2FybmluZzogaW5pdGlhbGl6YXRpb24gbWFrZXMgcG9pbnRlciBm
cm9tIGludGVnZXIKd2l0aG91dCBhIGNhc3QgW2VuYWJsZWQgYnkgZGVmYXVsdF0KClNlZW4gaWYg
Q09ORklHX09GX0RFVklDRSBpcyBub3QgZGVmaW5lZC4gb2ZfZ2V0X3Byb3BlcnR5IGlzIGRlY2xh
cmVkIGluCm9mLmggd2hpY2ggaXMgb25seSBpbmNsdWRlZCBieSBvZl9kZXZpY2UuaCBpZiBDT05G
SUdfT0ZfREVWSUNFIGlzIGRlZmluZWQuCm9mLmggbmVlZHMgdG8gYmUgaW5jbHVkZWQgZGlyZWN0
bHkuCgpTaWduZWQtb2ZmLWJ5OiBHdWVudGVyIFJvZWNrIDxsaW51eEByb2Vjay11cy5uZXQ+Ci0t
LQogZHJpdmVycy9od21vbi92ZXhwcmVzcy5jIHwgICAgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBp
bnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL3ZleHByZXNzLmMgYi9kcml2
ZXJzL2h3bW9uL3ZleHByZXNzLmMKaW5kZXggODZkN2Y2ZC4uZDg2N2U2YiAxMDA2NDQKLS0tIGEv
ZHJpdmVycy9od21vbi92ZXhwcmVzcy5jCisrKyBiL2RyaXZlcnMvaHdtb24vdmV4cHJlc3MuYwpA
QCAtMTksNiArMTksNyBAQAogI2luY2x1ZGUgPGxpbnV4L2h3bW9uLmg+CiAjaW5jbHVkZSA8bGlu
dXgvaHdtb24tc3lzZnMuaD4KICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KKyNpbmNsdWRlIDxs
aW51eC9vZi5oPgogI2luY2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgogI2luY2x1ZGUgPGxpbnV4
L3BsYXRmb3JtX2RldmljZS5oPgogI2luY2x1ZGUgPGxpbnV4L3ZleHByZXNzLmg+Ci0tIAoxLjcu
OS43CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0t
c2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlz
dHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
@ 2012-12-31 8:13 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2012-12-31 8:13 UTC (permalink / raw)
To: lm-sensors; +Cc: Pawel Moll, Jean Delvare, linux-kernel, Guenter Roeck
Fix:
vexpress.c: In function ‘vexpress_hwmon_name_show’:
vexpress.c:34:2: error: implicit declaration of function
‘of_get_property’ [-Werror=implicit-function-declaration]
vexpress.c:34:27: warning: initialization makes pointer from integer
without a cast [enabled by default]
vexpress.c: In function ‘vexpress_hwmon_label_show’:
vexpress.c:43:22: warning: initialization makes pointer from integer
without a cast [enabled by default]
Seen if CONFIG_OF_DEVICE is not defined. of_get_property is declared in
of.h which is only included by of_device.h if CONFIG_OF_DEVICE is defined.
of.h needs to be included directly.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/vexpress.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/vexpress.c b/drivers/hwmon/vexpress.c
index 86d7f6d..d867e6b 100644
--- a/drivers/hwmon/vexpress.c
+++ b/drivers/hwmon/vexpress.c
@@ -19,6 +19,7 @@
#include <linux/hwmon.h>
#include <linux/hwmon-sysfs.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/vexpress.h>
--
1.7.9.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
2012-12-31 8:13 ` Guenter Roeck
@ 2013-01-21 15:19 ` Pawel Moll
-1 siblings, 0 replies; 6+ messages in thread
From: Pawel Moll @ 2013-01-21 15:19 UTC (permalink / raw)
To: Guenter Roeck; +Cc: lm-sensors, Jean Delvare, linux-kernel@vger.kernel.org
T24gTW9uLCAyMDEyLTEyLTMxIGF0IDA4OjEzICswMDAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+
IEZpeDoKPiB2ZXhwcmVzcy5jOiBJbiBmdW5jdGlvbiDigJh2ZXhwcmVzc19od21vbl9uYW1lX3No
b3figJk6Cj4gdmV4cHJlc3MuYzozNDoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2Yg
ZnVuY3Rpb24KPiDigJhvZl9nZXRfcHJvcGVydHnigJkgWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rp
b24tZGVjbGFyYXRpb25dCj4gdmV4cHJlc3MuYzozNDoyNzogd2FybmluZzogaW5pdGlhbGl6YXRp
b24gbWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIKPiB3aXRob3V0IGEgY2FzdCBbZW5hYmxlZCBi
eSBkZWZhdWx0XQo+IHZleHByZXNzLmM6IEluIGZ1bmN0aW9uIOKAmHZleHByZXNzX2h3bW9uX2xh
YmVsX3Nob3figJk6Cj4gdmV4cHJlc3MuYzo0MzoyMjogd2FybmluZzogaW5pdGlhbGl6YXRpb24g
bWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIKPiB3aXRob3V0IGEgY2FzdCBbZW5hYmxlZCBieSBk
ZWZhdWx0XQo+IAo+IFNlZW4gaWYgQ09ORklHX09GX0RFVklDRSBpcyBub3QgZGVmaW5lZC4gb2Zf
Z2V0X3Byb3BlcnR5IGlzIGRlY2xhcmVkIGluCj4gb2YuaCB3aGljaCBpcyBvbmx5IGluY2x1ZGVk
IGJ5IG9mX2RldmljZS5oIGlmIENPTkZJR19PRl9ERVZJQ0UgaXMgZGVmaW5lZC4KPiBvZi5oIG5l
ZWRzIHRvIGJlIGluY2x1ZGVkIGRpcmVjdGx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEd1ZW50ZXIg
Um9lY2sgPGxpbnV4QHJvZWNrLXVzLm5ldD4KClRoYW5rcywgR3VlbnRlciEgKG9mIGNvdXJzZSBp
dCdzIHdheSB0b28gbGF0ZSBmb3IgQWNrZWQtYnk6IFBhd2VsIE1vbGwKPHBhd2VsLm1vbGxAYXJt
LmNvbT4pCgpQYXdlbAoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9y
ZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set
@ 2013-01-21 15:19 ` Pawel Moll
0 siblings, 0 replies; 6+ messages in thread
From: Pawel Moll @ 2013-01-21 15:19 UTC (permalink / raw)
To: Guenter Roeck; +Cc: lm-sensors, Jean Delvare, linux-kernel@vger.kernel.org
On Mon, 2012-12-31 at 08:13 +0000, Guenter Roeck wrote:
> Fix:
> vexpress.c: In function ‘vexpress_hwmon_name_show’:
> vexpress.c:34:2: error: implicit declaration of function
> ‘of_get_property’ [-Werror=implicit-function-declaration]
> vexpress.c:34:27: warning: initialization makes pointer from integer
> without a cast [enabled by default]
> vexpress.c: In function ‘vexpress_hwmon_label_show’:
> vexpress.c:43:22: warning: initialization makes pointer from integer
> without a cast [enabled by default]
>
> Seen if CONFIG_OF_DEVICE is not defined. of_get_property is declared in
> of.h which is only included by of_device.h if CONFIG_OF_DEVICE is defined.
> of.h needs to be included directly.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Thanks, Guenter! (of course it's way too late for Acked-by: Pawel Moll
<pawel.moll@arm.com>)
Pawel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-21 15:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-31 8:13 [lm-sensors] [PATCH 1/2] hwmon: (vexpress) Remove __devexit and __devexit_p Guenter Roeck
2012-12-31 8:13 ` Guenter Roeck
2012-12-31 8:13 ` [lm-sensors] [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set Guenter Roeck
2012-12-31 8:13 ` Guenter Roeck
2013-01-21 15:19 ` [lm-sensors] " Pawel Moll
2013-01-21 15:19 ` Pawel Moll
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.