From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR
Date: Fri, 04 Jan 2013 19:50:19 +0000 [thread overview]
Message-ID: <1357329019.666.14@snotra> (raw)
In-Reply-To: <1357321000-31008-3-git-send-email-agraf@suse.de> (from agraf@suse.de on Fri Jan 4 11:36:38 2013)
On 01/04/2013 11:36:38 AM, Alexander Graf wrote:
> The EPR register is potentially valid for PR KVM as well, so we need
> to emulate accesses to it. It's only defined for reading, so only
> handle the mfspr case.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> arch/powerpc/kvm/booke_emulate.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kvm/booke_emulate.c
> b/arch/powerpc/kvm/booke_emulate.c
> index 4685b8c..27a4b28 100644
> --- a/arch/powerpc/kvm/booke_emulate.c
> +++ b/arch/powerpc/kvm/booke_emulate.c
> @@ -269,6 +269,9 @@ int kvmppc_booke_emulate_mfspr(struct kvm_vcpu
> *vcpu, int sprn, ulong *spr_val)
> case SPRN_ESR:
> *spr_val = vcpu->arch.shared->esr;
> break;
> + case SPRN_EPR:
> + *spr_val = vcpu->arch.epr;
> + break;
It's not just potentially valid -- in our internal tree we do paravirt
EPR on e500v2 even though the hardware doesn't implement it.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: <kvm-ppc@vger.kernel.org>, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR
Date: Fri, 4 Jan 2013 13:50:19 -0600 [thread overview]
Message-ID: <1357329019.666.14@snotra> (raw)
In-Reply-To: <1357321000-31008-3-git-send-email-agraf@suse.de> (from agraf@suse.de on Fri Jan 4 11:36:38 2013)
On 01/04/2013 11:36:38 AM, Alexander Graf wrote:
> The EPR register is potentially valid for PR KVM as well, so we need
> to emulate accesses to it. It's only defined for reading, so only
> handle the mfspr case.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> arch/powerpc/kvm/booke_emulate.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kvm/booke_emulate.c
> b/arch/powerpc/kvm/booke_emulate.c
> index 4685b8c..27a4b28 100644
> --- a/arch/powerpc/kvm/booke_emulate.c
> +++ b/arch/powerpc/kvm/booke_emulate.c
> @@ -269,6 +269,9 @@ int kvmppc_booke_emulate_mfspr(struct kvm_vcpu
> *vcpu, int sprn, ulong *spr_val)
> case SPRN_ESR:
> *spr_val = vcpu->arch.shared->esr;
> break;
> + case SPRN_EPR:
> + *spr_val = vcpu->arch.epr;
> + break;
It's not just potentially valid -- in our internal tree we do paravirt
EPR on e500v2 even though the hardware doesn't implement it.
-Scott
next prev parent reply other threads:[~2013-01-04 19:50 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 17:36 [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 17:36 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 19:40 ` Scott Wood
2013-01-04 19:40 ` Scott Wood
2013-01-04 23:02 ` Alexander Graf
2013-01-04 23:02 ` Alexander Graf
2013-01-04 17:36 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 19:50 ` Scott Wood [this message]
2013-01-04 19:50 ` Scott Wood
2013-01-04 23:11 ` Alexander Graf
2013-01-04 23:11 ` Alexander Graf
2013-01-04 17:36 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 20:19 ` Scott Wood
2013-01-04 20:19 ` Scott Wood
2013-01-04 17:36 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 20:08 ` Scott Wood
2013-01-04 20:08 ` Scott Wood
2013-01-04 22:55 ` Alexander Graf
2013-01-04 22:55 ` Alexander Graf
2013-01-04 23:03 ` Scott Wood
2013-01-04 23:03 ` Scott Wood
2013-01-04 23:06 ` Alexander Graf
2013-01-04 23:06 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v2 Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-07 17:47 ` Scott Wood
2013-01-07 17:47 ` Scott Wood
2013-01-07 17:50 ` Alexander Graf
2013-01-07 17:50 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v3 Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:39 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-07 19:39 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357329019.666.14@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.