From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit
Date: Fri, 04 Jan 2013 20:19:22 +0000 [thread overview]
Message-ID: <1357330762.666.16@snotra> (raw)
In-Reply-To: <1357321000-31008-4-git-send-email-agraf@suse.de> (from agraf@suse.de on Fri Jan 4 11:36:39 2013)
On 01/04/2013 11:36:39 AM, Alexander Graf wrote:
> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
> index 4ae83f9..363301f 100644
> --- a/arch/powerpc/kvm/booke.c
> +++ b/arch/powerpc/kvm/booke.c
> @@ -306,7 +306,7 @@ static int kvmppc_booke_irqprio_deliver(struct
> kvm_vcpu *vcpu,
> {
> int allowed = 0;
> ulong msr_mask = 0;
> - bool update_esr = false, update_dear = false;
> + bool update_esr = false, update_dear = false, update_epr =
> false;
> ulong crit_raw = vcpu->arch.shared->critical;
> ulong crit_r1 = kvmppc_get_gpr(vcpu, 1);
> bool crit;
> @@ -369,6 +369,8 @@ static int kvmppc_booke_irqprio_deliver(struct
> kvm_vcpu *vcpu,
> keep_irq = true;
> /* fall through */
> case BOOKE_IRQPRIO_EXTERNAL:
> + if (vcpu->arch.epr_enabled)
> + update_epr = true;
> case BOOKE_IRQPRIO_DBELL:
We don't want to update EPR on decrementer/FIT. Also, missing
fall-through comment.
> @@ -762,6 +768,10 @@ static int kvm_vcpu_ioctl_enable_cap(struct
> kvm_vcpu *vcpu,
> r = 0;
> vcpu->arch.papr_enabled = true;
> break;
> + case KVM_CAP_PPC_EPR:
> + r = 0;
> + vcpu->arch.epr_enabled = cap->args[0];
> + break;
I don't see where the docs say that this capability uses args[0] as an
enable/disable flag.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: <kvm-ppc@vger.kernel.org>, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit
Date: Fri, 4 Jan 2013 14:19:22 -0600 [thread overview]
Message-ID: <1357330762.666.16@snotra> (raw)
In-Reply-To: <1357321000-31008-4-git-send-email-agraf@suse.de> (from agraf@suse.de on Fri Jan 4 11:36:39 2013)
On 01/04/2013 11:36:39 AM, Alexander Graf wrote:
> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
> index 4ae83f9..363301f 100644
> --- a/arch/powerpc/kvm/booke.c
> +++ b/arch/powerpc/kvm/booke.c
> @@ -306,7 +306,7 @@ static int kvmppc_booke_irqprio_deliver(struct
> kvm_vcpu *vcpu,
> {
> int allowed = 0;
> ulong msr_mask = 0;
> - bool update_esr = false, update_dear = false;
> + bool update_esr = false, update_dear = false, update_epr =
> false;
> ulong crit_raw = vcpu->arch.shared->critical;
> ulong crit_r1 = kvmppc_get_gpr(vcpu, 1);
> bool crit;
> @@ -369,6 +369,8 @@ static int kvmppc_booke_irqprio_deliver(struct
> kvm_vcpu *vcpu,
> keep_irq = true;
> /* fall through */
> case BOOKE_IRQPRIO_EXTERNAL:
> + if (vcpu->arch.epr_enabled)
> + update_epr = true;
> case BOOKE_IRQPRIO_DBELL:
We don't want to update EPR on decrementer/FIT. Also, missing
fall-through comment.
> @@ -762,6 +768,10 @@ static int kvm_vcpu_ioctl_enable_cap(struct
> kvm_vcpu *vcpu,
> r = 0;
> vcpu->arch.papr_enabled = true;
> break;
> + case KVM_CAP_PPC_EPR:
> + r = 0;
> + vcpu->arch.epr_enabled = cap->args[0];
> + break;
I don't see where the docs say that this capability uses args[0] as an
enable/disable flag.
-Scott
next prev parent reply other threads:[~2013-01-04 20:19 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 17:36 [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 17:36 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 19:40 ` Scott Wood
2013-01-04 19:40 ` Scott Wood
2013-01-04 23:02 ` Alexander Graf
2013-01-04 23:02 ` Alexander Graf
2013-01-04 17:36 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 19:50 ` Scott Wood
2013-01-04 19:50 ` Scott Wood
2013-01-04 23:11 ` Alexander Graf
2013-01-04 23:11 ` Alexander Graf
2013-01-04 17:36 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 20:19 ` Scott Wood [this message]
2013-01-04 20:19 ` Scott Wood
2013-01-04 17:36 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 20:08 ` Scott Wood
2013-01-04 20:08 ` Scott Wood
2013-01-04 22:55 ` Alexander Graf
2013-01-04 22:55 ` Alexander Graf
2013-01-04 23:03 ` Scott Wood
2013-01-04 23:03 ` Scott Wood
2013-01-04 23:06 ` Alexander Graf
2013-01-04 23:06 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v2 Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-07 17:47 ` Scott Wood
2013-01-07 17:47 ` Scott Wood
2013-01-07 17:50 ` Alexander Graf
2013-01-07 17:50 ` Alexander Graf
2013-01-04 23:41 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-04 23:41 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v3 Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:38 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-07 19:38 ` Alexander Graf
2013-01-07 19:39 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-07 19:39 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357330762.666.16@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.