All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync
Date: Fri, 04 Jan 2013 23:03:03 +0000	[thread overview]
Message-ID: <1357340583.666.21@snotra> (raw)
In-Reply-To: <FBE9532C-773C-4F47-AF7D-68C33A6DCEB1@suse.de> (from agraf@suse.de on Fri Jan  4 16:55:34 2013)

On 01/04/2013 04:55:34 PM, Alexander Graf wrote:
> 
> On 04.01.2013, at 21:08, Scott Wood wrote:
> 
> > On 01/04/2013 11:36:40 AM, Alexander Graf wrote:
> >> We need to be able to read and write the contents of the EPR  
> register
> >> from user space.
> >> This patch implements that logic through the ONE_REG API and  
> declares
> >> its (never implemented) SREGS counterpart as deprecated.
> >
> > QEMU already uses SREGS to read this...  I'm not sure what happened  
> on the KVM side.
> 
> Since it's never been implemented on the KVM side, I don't see why  
> it'd be an issue to force ONE_REG on any user :). In the long run,  
> I'd like to move as much of the state synchronization to ONE_REG.

That's fine -- but we should make sure not to forget to update QEMU.

-Scott

WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: <kvm-ppc@vger.kernel.org>, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync
Date: Fri, 4 Jan 2013 17:03:03 -0600	[thread overview]
Message-ID: <1357340583.666.21@snotra> (raw)
In-Reply-To: <FBE9532C-773C-4F47-AF7D-68C33A6DCEB1@suse.de> (from agraf@suse.de on Fri Jan  4 16:55:34 2013)

On 01/04/2013 04:55:34 PM, Alexander Graf wrote:
> 
> On 04.01.2013, at 21:08, Scott Wood wrote:
> 
> > On 01/04/2013 11:36:40 AM, Alexander Graf wrote:
> >> We need to be able to read and write the contents of the EPR  
> register
> >> from user space.
> >> This patch implements that logic through the ONE_REG API and  
> declares
> >> its (never implemented) SREGS counterpart as deprecated.
> >
> > QEMU already uses SREGS to read this...  I'm not sure what happened  
> on the KVM side.
> 
> Since it's never been implemented on the KVM side, I don't see why  
> it'd be an issue to force ONE_REG on any user :). In the long run,  
> I'd like to move as much of the state synchronization to ONE_REG.

That's fine -- but we should make sure not to forget to update QEMU.

-Scott

  reply	other threads:[~2013-01-04 23:03 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 17:36 [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support Alexander Graf
2013-01-04 17:36 ` Alexander Graf
2013-01-04 17:36 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-04 17:36   ` Alexander Graf
2013-01-04 19:40   ` Scott Wood
2013-01-04 19:40     ` Scott Wood
2013-01-04 23:02     ` Alexander Graf
2013-01-04 23:02       ` Alexander Graf
2013-01-04 17:36 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-04 17:36   ` Alexander Graf
2013-01-04 19:50   ` Scott Wood
2013-01-04 19:50     ` Scott Wood
2013-01-04 23:11     ` Alexander Graf
2013-01-04 23:11       ` Alexander Graf
2013-01-04 17:36 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-04 17:36   ` Alexander Graf
2013-01-04 20:19   ` Scott Wood
2013-01-04 20:19     ` Scott Wood
2013-01-04 17:36 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-04 17:36   ` Alexander Graf
2013-01-04 20:08   ` Scott Wood
2013-01-04 20:08     ` Scott Wood
2013-01-04 22:55     ` Alexander Graf
2013-01-04 22:55       ` Alexander Graf
2013-01-04 23:03       ` Scott Wood [this message]
2013-01-04 23:03         ` Scott Wood
2013-01-04 23:06         ` Alexander Graf
2013-01-04 23:06           ` Alexander Graf
2013-01-04 23:41 ` [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v2 Alexander Graf
2013-01-04 23:41   ` Alexander Graf
2013-01-04 23:41   ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-04 23:41     ` Alexander Graf
2013-01-04 23:41   ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-04 23:41     ` Alexander Graf
2013-01-04 23:41   ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-04 23:41     ` Alexander Graf
2013-01-07 17:47     ` Scott Wood
2013-01-07 17:47       ` Scott Wood
2013-01-07 17:50       ` Alexander Graf
2013-01-07 17:50         ` Alexander Graf
2013-01-04 23:41   ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-04 23:41     ` Alexander Graf
2013-01-07 19:38 ` [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v3 Alexander Graf
2013-01-07 19:38   ` Alexander Graf
2013-01-07 19:38   ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-07 19:38     ` Alexander Graf
2013-01-07 19:38   ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-07 19:38     ` Alexander Graf
2013-01-07 19:38   ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-07 19:38     ` Alexander Graf
2013-01-07 19:39   ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-07 19:39     ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357340583.666.21@snotra \
    --to=scottwood@freescale.com \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.