From: Daniel Mack <zonque@gmail.com>
To: netdev@vger.kernel.org
Cc: bcousson@baylibre.com, nsekhar@ti.com,
sergei.shtylyov@cogentembedded.com, davem@davemloft.net,
ujhelyi.m@gmail.com, mugunthanvnm@ti.com, vaibhav.bedia@ti.com,
d-gerlach@ti.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
Daniel Mack <zonque@gmail.com>
Subject: [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module
Date: Fri, 23 Aug 2013 21:32:07 +0200 [thread overview]
Message-ID: <1377286330-29663-3-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1377286330-29663-1-git-send-email-zonque@gmail.com>
At least the AM33xx SoC has a control module register to configure
details such as the hardware ethernet interface mode.
I'm not sure whether all SoCs which feature the cpsw block have such a
register, so that third memory region is considered optional for now.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
---
Documentation/devicetree/bindings/net/cpsw.txt | 5 ++++-
drivers/net/ethernet/ti/cpsw.c | 11 +++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt
index 05d660e..4e5ca54 100644
--- a/Documentation/devicetree/bindings/net/cpsw.txt
+++ b/Documentation/devicetree/bindings/net/cpsw.txt
@@ -4,7 +4,10 @@ TI SoC Ethernet Switch Controller Device Tree Bindings
Required properties:
- compatible : Should be "ti,cpsw"
- reg : physical base address and size of the cpsw
- registers map
+ registers map.
+ An optional third memory region can be supplied if
+ the platform has a control module register to
+ configure phy interface details
- interrupts : property with a value describing the interrupt
number
- interrupt-parent : The parent interrupt controller
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index fc3263f..485df80 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -372,6 +372,7 @@ struct cpsw_priv {
struct cpsw_platform_data data;
struct cpsw_ss_regs __iomem *regs;
struct cpsw_wr_regs __iomem *wr_regs;
+ u32 __iomem *gmii_sel_reg;
u8 __iomem *hw_stats;
struct cpsw_host_regs __iomem *host_port_regs;
u32 msg_enable;
@@ -1989,6 +1990,16 @@ static int cpsw_probe(struct platform_device *pdev)
goto clean_runtime_disable_ret;
}
+ /* Don't fail hard if the optional control memory region is missing */
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
+ if (res) {
+ priv->gmii_sel_reg = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(priv->gmii_sel_reg)) {
+ ret = PTR_ERR(priv->gmii_sel_reg);
+ goto clean_runtime_disable_ret;
+ }
+ }
+
memset(&dma_params, 0, sizeof(dma_params));
memset(&ale_params, 0, sizeof(ale_params));
--
1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module
Date: Fri, 23 Aug 2013 21:32:07 +0200 [thread overview]
Message-ID: <1377286330-29663-3-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1377286330-29663-1-git-send-email-zonque@gmail.com>
At least the AM33xx SoC has a control module register to configure
details such as the hardware ethernet interface mode.
I'm not sure whether all SoCs which feature the cpsw block have such a
register, so that third memory region is considered optional for now.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
---
Documentation/devicetree/bindings/net/cpsw.txt | 5 ++++-
drivers/net/ethernet/ti/cpsw.c | 11 +++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt
index 05d660e..4e5ca54 100644
--- a/Documentation/devicetree/bindings/net/cpsw.txt
+++ b/Documentation/devicetree/bindings/net/cpsw.txt
@@ -4,7 +4,10 @@ TI SoC Ethernet Switch Controller Device Tree Bindings
Required properties:
- compatible : Should be "ti,cpsw"
- reg : physical base address and size of the cpsw
- registers map
+ registers map.
+ An optional third memory region can be supplied if
+ the platform has a control module register to
+ configure phy interface details
- interrupts : property with a value describing the interrupt
number
- interrupt-parent : The parent interrupt controller
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index fc3263f..485df80 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -372,6 +372,7 @@ struct cpsw_priv {
struct cpsw_platform_data data;
struct cpsw_ss_regs __iomem *regs;
struct cpsw_wr_regs __iomem *wr_regs;
+ u32 __iomem *gmii_sel_reg;
u8 __iomem *hw_stats;
struct cpsw_host_regs __iomem *host_port_regs;
u32 msg_enable;
@@ -1989,6 +1990,16 @@ static int cpsw_probe(struct platform_device *pdev)
goto clean_runtime_disable_ret;
}
+ /* Don't fail hard if the optional control memory region is missing */
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
+ if (res) {
+ priv->gmii_sel_reg = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(priv->gmii_sel_reg)) {
+ ret = PTR_ERR(priv->gmii_sel_reg);
+ goto clean_runtime_disable_ret;
+ }
+ }
+
memset(&dma_params, 0, sizeof(dma_params));
memset(&ale_params, 0, sizeof(ale_params));
--
1.8.3.1
next prev parent reply other threads:[~2013-08-23 19:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 19:32 [PATCH v6 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:32 ` [PATCH v6 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:32 ` Daniel Mack [this message]
2013-08-23 19:32 ` [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-26 9:04 ` Tony Lindgren
2013-08-26 9:04 ` Tony Lindgren
2013-08-26 18:49 ` Mugunthan V N
2013-08-26 18:49 ` Mugunthan V N
2013-08-26 18:49 ` Mugunthan V N
2013-08-23 19:32 ` [PATCH v6 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string Daniel Mack
2013-08-23 19:32 ` [PATCH v6 3/5] net: ethernet: cpsw: introduce ti, am3352-cpsw " Daniel Mack
2013-08-23 19:32 ` [PATCH v6 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:32 ` [PATCH v6 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:38 ` [PATCH v6 0/5] cpsw: support for control module register Mugunthan V N
2013-08-23 19:38 ` Mugunthan V N
2013-08-23 19:41 ` Daniel Mack
2013-08-23 19:41 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377286330-29663-3-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ujhelyi.m@gmail.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.