From: Mugunthan V N <mugunthanvnm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Daniel Mack <zonque@gmail.com>,
netdev@vger.kernel.org, bcousson@baylibre.com, nsekhar@ti.com,
sergei.shtylyov@cogentembedded.com, davem@davemloft.net,
ujhelyi.m@gmail.com, vaibhav.bedia@ti.com, d-gerlach@ti.com,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module
Date: Tue, 27 Aug 2013 00:19:00 +0530 [thread overview]
Message-ID: <521BA31C.1010504@ti.com> (raw)
In-Reply-To: <20130826090422.GB7656@atomide.com>
On Monday 26 August 2013 02:34 PM, Tony Lindgren wrote:
> * Daniel Mack <zonque@gmail.com> [130823 12:39]:
>> At least the AM33xx SoC has a control module register to configure
>> details such as the hardware ethernet interface mode.
>>
>> I'm not sure whether all SoCs which feature the cpsw block have such a
>> register, so that third memory region is considered optional for now.
> Assuming you're talking about omap SCM registers here..
>
> This should be in a separate driver module so the control module
> parts can eventually be children of the SCM driver as they are
> really separate devices on the bus. See how the USB PHY parts were done
> for example.
>
> What do these control module registers do? If it's just multiplexing
> and pinconf, then you can use pinctrl-single,bits most likely for it and
> access it using the named modes.
>
> However, if the register also contains comparators and control for
> regulators, you should only use pinctrl-single for the multiplexing
> and pinconf parts.
>
I will take a look into usb control module driver and will try to adopt
the driver here also.
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module
Date: Tue, 27 Aug 2013 00:19:00 +0530 [thread overview]
Message-ID: <521BA31C.1010504@ti.com> (raw)
In-Reply-To: <20130826090422.GB7656@atomide.com>
On Monday 26 August 2013 02:34 PM, Tony Lindgren wrote:
> * Daniel Mack <zonque@gmail.com> [130823 12:39]:
>> At least the AM33xx SoC has a control module register to configure
>> details such as the hardware ethernet interface mode.
>>
>> I'm not sure whether all SoCs which feature the cpsw block have such a
>> register, so that third memory region is considered optional for now.
> Assuming you're talking about omap SCM registers here..
>
> This should be in a separate driver module so the control module
> parts can eventually be children of the SCM driver as they are
> really separate devices on the bus. See how the USB PHY parts were done
> for example.
>
> What do these control module registers do? If it's just multiplexing
> and pinconf, then you can use pinctrl-single,bits most likely for it and
> access it using the named modes.
>
> However, if the register also contains comparators and control for
> regulators, you should only use pinctrl-single for the multiplexing
> and pinconf parts.
>
I will take a look into usb control module driver and will try to adopt
the driver here also.
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: Mugunthan V N <mugunthanvnm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Daniel Mack <zonque@gmail.com>, <netdev@vger.kernel.org>,
<bcousson@baylibre.com>, <nsekhar@ti.com>,
<sergei.shtylyov@cogentembedded.com>, <davem@davemloft.net>,
<ujhelyi.m@gmail.com>, <vaibhav.bedia@ti.com>, <d-gerlach@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module
Date: Tue, 27 Aug 2013 00:19:00 +0530 [thread overview]
Message-ID: <521BA31C.1010504@ti.com> (raw)
In-Reply-To: <20130826090422.GB7656@atomide.com>
On Monday 26 August 2013 02:34 PM, Tony Lindgren wrote:
> * Daniel Mack <zonque@gmail.com> [130823 12:39]:
>> At least the AM33xx SoC has a control module register to configure
>> details such as the hardware ethernet interface mode.
>>
>> I'm not sure whether all SoCs which feature the cpsw block have such a
>> register, so that third memory region is considered optional for now.
> Assuming you're talking about omap SCM registers here..
>
> This should be in a separate driver module so the control module
> parts can eventually be children of the SCM driver as they are
> really separate devices on the bus. See how the USB PHY parts were done
> for example.
>
> What do these control module registers do? If it's just multiplexing
> and pinconf, then you can use pinctrl-single,bits most likely for it and
> access it using the named modes.
>
> However, if the register also contains comparators and control for
> regulators, you should only use pinctrl-single for the multiplexing
> and pinconf parts.
>
I will take a look into usb control module driver and will try to adopt
the driver here also.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-08-26 18:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 19:32 [PATCH v6 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:32 ` [PATCH v6 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:32 ` [PATCH v6 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-26 9:04 ` Tony Lindgren
2013-08-26 9:04 ` Tony Lindgren
2013-08-26 18:49 ` Mugunthan V N [this message]
2013-08-26 18:49 ` Mugunthan V N
2013-08-26 18:49 ` Mugunthan V N
2013-08-23 19:32 ` [PATCH v6 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string Daniel Mack
2013-08-23 19:32 ` [PATCH v6 3/5] net: ethernet: cpsw: introduce ti, am3352-cpsw " Daniel Mack
2013-08-23 19:32 ` [PATCH v6 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:32 ` [PATCH v6 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
2013-08-23 19:32 ` Daniel Mack
2013-08-23 19:38 ` [PATCH v6 0/5] cpsw: support for control module register Mugunthan V N
2013-08-23 19:38 ` Mugunthan V N
2013-08-23 19:41 ` Daniel Mack
2013-08-23 19:41 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521BA31C.1010504@ti.com \
--to=mugunthanvnm@ti.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
--cc=ujhelyi.m@gmail.com \
--cc=vaibhav.bedia@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.