From: Geoff Levand <geoff@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Paul Mundt <lethal@linux-sh.org>,
kexec@lists.infradead.org, Eric Biederman <ebiederm@xmission.com>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 4/4] sh/kexec: Fix kexec build warning
Date: Thu, 12 Dec 2013 11:30:01 -0800 [thread overview]
Message-ID: <1386876601.1002.0.camel@smoke> (raw)
In-Reply-To: <CAMuHMdUVfY5UO2tZEzSML9Bhx64VobDdyJQwOgfQ5=2wzxbONQ@mail.gmail.com>
Hi,
On Thu, 2013-12-12 at 15:48 +0100, Geert Uytterhoeven wrote:
> On Thu, Dec 12, 2013 at 1:18 AM, Geoff Levand <geoff@infradead.org> wrote:
> > - image->segment[i].memsz,
> > + (unsigned int)image->segment[i].memsz,e->start);
>
> Wouldn't it be better to remove all casts and correct the printf-style
> format specifiers instead?
That would be better, I'll make a new patch.
Thanks Geert!
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoff@infradead.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/4] sh/kexec: Fix kexec build warning
Date: Thu, 12 Dec 2013 19:30:01 +0000 [thread overview]
Message-ID: <1386876601.1002.0.camel@smoke> (raw)
In-Reply-To: <594a3d26aac66e9668edc81d7bfb4e801575514f.1386807069.git.geoff@infradead.org>
Hi,
On Thu, 2013-12-12 at 15:48 +0100, Geert Uytterhoeven wrote:
> On Thu, Dec 12, 2013 at 1:18 AM, Geoff Levand <geoff@infradead.org> wrote:
> > - image->segment[i].memsz,
> > + (unsigned int)image->segment[i].memsz,e->start);
>
> Wouldn't it be better to remove all casts and correct the printf-style
> format specifiers instead?
That would be better, I'll make a new patch.
Thanks Geert!
next prev parent reply other threads:[~2013-12-12 19:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 0:18 [PATCH 0/4] Minor fixes and improvements for kexec Geoff Levand
2013-12-12 0:18 ` Geoff Levand
2013-12-12 0:18 ` [PATCH 2/4] kexec: Add IND_FLAGS macro Geoff Levand
2013-12-12 0:18 ` Geoff Levand
2013-12-12 1:35 ` Zhang Yanfei
2013-12-12 1:35 ` Zhang Yanfei
2013-12-12 19:33 ` Geoff Levand
2013-12-12 19:33 ` Geoff Levand
2013-12-12 0:18 ` [PATCH 4/4] sh/kexec: Fix kexec build warning Geoff Levand
2013-12-12 0:18 ` Geoff Levand
2013-12-12 14:48 ` Geert Uytterhoeven
2013-12-12 14:48 ` Geert Uytterhoeven
2013-12-12 19:30 ` Geoff Levand [this message]
2013-12-12 19:30 ` Geoff Levand
2013-12-12 0:18 ` [PATCH 1/4] kexec: Simplify conditional Geoff Levand
2013-12-12 1:32 ` Zhang Yanfei
2013-12-17 0:45 ` Andrew Morton
2013-12-12 0:18 ` [PATCH 3/4] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2013-12-12 0:18 ` Geoff Levand
2013-12-12 5:11 ` [PATCH 0/4] Minor fixes and improvements for kexec Simon Horman
2013-12-12 5:11 ` Simon Horman
2013-12-12 5:11 ` Simon Horman
2013-12-12 19:51 ` [PATCH v2 4/4] sh/kexec: Fix kexec build warning Geoff Levand
2013-12-12 19:51 ` Geoff Levand
2013-12-17 5:37 ` [PATCH 0/4] Minor fixes and improvements for kexec WANG Chao
2013-12-17 5:37 ` WANG Chao
2013-12-17 5:37 ` WANG Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386876601.1002.0.camel@smoke \
--to=geoff@infradead.org \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=kexec@lists.infradead.org \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.