All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Geoff Levand <geoff@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
	Eric Biederman <ebiederm@xmission.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/4] kexec: Add IND_FLAGS macro
Date: Thu, 12 Dec 2013 09:35:31 +0800	[thread overview]
Message-ID: <52A912E3.1060802@cn.fujitsu.com> (raw)
In-Reply-To: <3d9d024551c3c0e560d77f81926cb5774dda7067.1386807069.git.geoff@infradead.org>

Hello

On 12/12/2013 08:18 AM, Geoff Levand wrote:
> Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of
> all the possible kexec IND_ kimage_entry indirection flags.
> 
> Having this macro allows for simplified code in the prosessing of the
> kexec kimage_entry items.

Where? I didn't see any place you use this macro to help simplification.

Thanks
Zhang

> 
> Signed-off-by: Geoff Levand <geoff@infradead.org> for Huawei, Linaro
> ---
>  include/linux/kexec.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index d78d28a..f755ec3 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -67,6 +67,7 @@ typedef unsigned long kimage_entry_t;
>  #define IND_INDIRECTION  0x2
>  #define IND_DONE         0x4
>  #define IND_SOURCE       0x8
> +#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
>  
>  struct kexec_segment {
>  	void __user *buf;
> 


-- 
Thanks.
Zhang Yanfei

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Geoff Levand <geoff@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
	Eric Biederman <ebiederm@xmission.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/4] kexec: Add IND_FLAGS macro
Date: Thu, 12 Dec 2013 09:35:31 +0800	[thread overview]
Message-ID: <52A912E3.1060802@cn.fujitsu.com> (raw)
In-Reply-To: <3d9d024551c3c0e560d77f81926cb5774dda7067.1386807069.git.geoff@infradead.org>

Hello

On 12/12/2013 08:18 AM, Geoff Levand wrote:
> Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of
> all the possible kexec IND_ kimage_entry indirection flags.
> 
> Having this macro allows for simplified code in the prosessing of the
> kexec kimage_entry items.

Where? I didn't see any place you use this macro to help simplification.

Thanks
Zhang

> 
> Signed-off-by: Geoff Levand <geoff@infradead.org> for Huawei, Linaro
> ---
>  include/linux/kexec.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index d78d28a..f755ec3 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -67,6 +67,7 @@ typedef unsigned long kimage_entry_t;
>  #define IND_INDIRECTION  0x2
>  #define IND_DONE         0x4
>  #define IND_SOURCE       0x8
> +#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
>  
>  struct kexec_segment {
>  	void __user *buf;
> 


-- 
Thanks.
Zhang Yanfei

  reply	other threads:[~2013-12-12  1:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  0:18 [PATCH 0/4] Minor fixes and improvements for kexec Geoff Levand
2013-12-12  0:18 ` Geoff Levand
2013-12-12  0:18 ` [PATCH 1/4] kexec: Simplify conditional Geoff Levand
2013-12-12  1:32   ` Zhang Yanfei
2013-12-17  0:45     ` Andrew Morton
2013-12-12  0:18 ` [PATCH 3/4] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2013-12-12  0:18   ` Geoff Levand
2013-12-12  0:18 ` [PATCH 2/4] kexec: Add " Geoff Levand
2013-12-12  0:18   ` Geoff Levand
2013-12-12  1:35   ` Zhang Yanfei [this message]
2013-12-12  1:35     ` Zhang Yanfei
2013-12-12 19:33     ` Geoff Levand
2013-12-12 19:33       ` Geoff Levand
2013-12-12  0:18 ` [PATCH 4/4] sh/kexec: Fix kexec build warning Geoff Levand
2013-12-12  0:18   ` Geoff Levand
2013-12-12 14:48   ` Geert Uytterhoeven
2013-12-12 14:48     ` Geert Uytterhoeven
2013-12-12 19:30     ` Geoff Levand
2013-12-12 19:30       ` Geoff Levand
2013-12-12  5:11 ` [PATCH 0/4] Minor fixes and improvements for kexec Simon Horman
2013-12-12  5:11   ` Simon Horman
2013-12-12  5:11   ` Simon Horman
2013-12-12 19:51 ` [PATCH v2 4/4] sh/kexec: Fix kexec build warning Geoff Levand
2013-12-12 19:51   ` Geoff Levand
2013-12-17  5:37 ` [PATCH 0/4] Minor fixes and improvements for kexec WANG Chao
2013-12-17  5:37   ` WANG Chao
2013-12-17  5:37   ` WANG Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A912E3.1060802@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=benh@kernel.crashing.org \
    --cc=ebiederm@xmission.com \
    --cc=geoff@infradead.org \
    --cc=kexec@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.