All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: Eric Biederman <ebiederm@xmission.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Paul Mundt <lethal@linux-sh.org>,
	kexec@lists.infradead.org, linux-sh@vger.kernel.org
Subject: [PATCH v2 4/4] sh/kexec: Fix kexec build warning
Date: Thu, 12 Dec 2013 11:51:29 -0800	[thread overview]
Message-ID: <1386877889.1002.6.camel@smoke> (raw)
In-Reply-To: <cover.1386807069.git.geoff@infradead.org>

Change the format specifiers in the kexec_info routine to match the data
types.  Eliminates the need for type casts and fixes a type mismatch
compiler warning.  Also replace indenting spaces with a tab character.

Signed-off-by: Geoff Levand <geoff@infradead.org> for Huawei, Linaro
---

V2:
  Change from type cast fix to format specifier fix.
  
 arch/sh/kernel/machine_kexec.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/sh/kernel/machine_kexec.c b/arch/sh/kernel/machine_kexec.c
index 9fea49f..8195c35 100644
--- a/arch/sh/kernel/machine_kexec.c
+++ b/arch/sh/kernel/machine_kexec.c
@@ -53,17 +53,17 @@ void machine_kexec_cleanup(struct kimage *image)
 
 static void kexec_info(struct kimage *image)
 {
-        int i;
+	int i;
 	printk("kexec information\n");
 	for (i = 0; i < image->nr_segments; i++) {
-	        printk("  segment[%d]: 0x%08x - 0x%08x (0x%08x)\n",
+	        printk("  segment[%d]: 0x%08lx - 0x%08lx (0x%08zx)\n",
 		       i,
-		       (unsigned int)image->segment[i].mem,
-		       (unsigned int)image->segment[i].mem +
-				     image->segment[i].memsz,
-		       (unsigned int)image->segment[i].memsz);
+		       image->segment[i].mem,
+		       image->segment[i].mem +
+		       image->segment[i].memsz,
+		       image->segment[i].memsz);
 	}
-	printk("  start     : 0x%08x\n\n", (unsigned int)image->start);
+	printk("  start     : 0x%08lx\n\n", image->start);
 }
 
 /*
-- 
1.8.1.2




_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoff@infradead.org>
To: linux-sh@vger.kernel.org
Subject: [PATCH v2 4/4] sh/kexec: Fix kexec build warning
Date: Thu, 12 Dec 2013 19:51:29 +0000	[thread overview]
Message-ID: <1386877889.1002.6.camel@smoke> (raw)

Change the format specifiers in the kexec_info routine to match the data
types.  Eliminates the need for type casts and fixes a type mismatch
compiler warning.  Also replace indenting spaces with a tab character.

Signed-off-by: Geoff Levand <geoff@infradead.org> for Huawei, Linaro
---

V2:
  Change from type cast fix to format specifier fix.
  
 arch/sh/kernel/machine_kexec.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/sh/kernel/machine_kexec.c b/arch/sh/kernel/machine_kexec.c
index 9fea49f..8195c35 100644
--- a/arch/sh/kernel/machine_kexec.c
+++ b/arch/sh/kernel/machine_kexec.c
@@ -53,17 +53,17 @@ void machine_kexec_cleanup(struct kimage *image)
 
 static void kexec_info(struct kimage *image)
 {
-        int i;
+	int i;
 	printk("kexec information\n");
 	for (i = 0; i < image->nr_segments; i++) {
-	        printk("  segment[%d]: 0x%08x - 0x%08x (0x%08x)\n",
+	        printk("  segment[%d]: 0x%08lx - 0x%08lx (0x%08zx)\n",
 		       i,
-		       (unsigned int)image->segment[i].mem,
-		       (unsigned int)image->segment[i].mem +
-				     image->segment[i].memsz,
-		       (unsigned int)image->segment[i].memsz);
+		       image->segment[i].mem,
+		       image->segment[i].mem +
+		       image->segment[i].memsz,
+		       image->segment[i].memsz);
 	}
-	printk("  start     : 0x%08x\n\n", (unsigned int)image->start);
+	printk("  start     : 0x%08lx\n\n", image->start);
 }
 
 /*
-- 
1.8.1.2




  parent reply	other threads:[~2013-12-12 19:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  0:18 [PATCH 0/4] Minor fixes and improvements for kexec Geoff Levand
2013-12-12  0:18 ` Geoff Levand
2013-12-12  0:18 ` [PATCH 1/4] kexec: Simplify conditional Geoff Levand
2013-12-12  1:32   ` Zhang Yanfei
2013-12-17  0:45     ` Andrew Morton
2013-12-12  0:18 ` [PATCH 3/4] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2013-12-12  0:18   ` Geoff Levand
2013-12-12  0:18 ` [PATCH 2/4] kexec: Add " Geoff Levand
2013-12-12  0:18   ` Geoff Levand
2013-12-12  1:35   ` Zhang Yanfei
2013-12-12  1:35     ` Zhang Yanfei
2013-12-12 19:33     ` Geoff Levand
2013-12-12 19:33       ` Geoff Levand
2013-12-12  0:18 ` [PATCH 4/4] sh/kexec: Fix kexec build warning Geoff Levand
2013-12-12  0:18   ` Geoff Levand
2013-12-12 14:48   ` Geert Uytterhoeven
2013-12-12 14:48     ` Geert Uytterhoeven
2013-12-12 19:30     ` Geoff Levand
2013-12-12 19:30       ` Geoff Levand
2013-12-12  5:11 ` [PATCH 0/4] Minor fixes and improvements for kexec Simon Horman
2013-12-12  5:11   ` Simon Horman
2013-12-12  5:11   ` Simon Horman
2013-12-12 19:51 ` Geoff Levand [this message]
2013-12-12 19:51   ` [PATCH v2 4/4] sh/kexec: Fix kexec build warning Geoff Levand
2013-12-17  5:37 ` [PATCH 0/4] Minor fixes and improvements for kexec WANG Chao
2013-12-17  5:37   ` WANG Chao
2013-12-17  5:37   ` WANG Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386877889.1002.6.camel@smoke \
    --to=geoff@infradead.org \
    --cc=ebiederm@xmission.com \
    --cc=geert@linux-m68k.org \
    --cc=kexec@lists.infradead.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.