All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: "James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"lsf-pc@lists.linux-foundation.org"
	<lsf-pc@lists.linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"rwheeler@redhat.com" <rwheeler@redhat.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"mgorman@suse.de" <mgorman@suse.de>
Subject: Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes
Date: Wed, 22 Jan 2014 18:02:09 +0000	[thread overview]
Message-ID: <1390413819.1198.20.camel@ret.masoncoding.com> (raw)
In-Reply-To: <1390411300.2372.33.camel@dabdike.int.hansenpartnership.com>

On Wed, 2014-01-22 at 09:21 -0800, James Bottomley wrote:
> On Wed, 2014-01-22 at 17:02 +0000, Chris Mason wrote:

[ I like big sectors and I cannot lie ]

>  
> > I really think that if we want to make progress on this one, we need
> > code and someone that owns it.  Nick's work was impressive, but it was
> > mostly there for getting rid of buffer heads.  If we have a device that
> > needs it and someone working to enable that device, we'll go forward
> > much faster.
> 
> Do we even need to do that (eliminate buffer heads)?  We cope with 4k
> sector only devices just fine today because the bh mechanisms now
> operate on top of the page cache and can do the RMW necessary to update
> a bh in the page cache itself which allows us to do only 4k chunked
> writes, so we could keep the bh system and just alter the granularity of
> the page cache.
> 

We're likely to have people mixing 4K drives and <fill in some other
size here> on the same box.  We could just go with the biggest size and
use the existing bh code for the sub-pagesized blocks, but I really
hesitate to change VM fundamentals for this.

>From a pure code point of view, it may be less work to change it once in
the VM.  But from an overall system impact point of view, it's a big
change in how the system behaves just for filesystem metadata.

> The other question is if the drive does RMW between 4k and whatever its
> physical sector size, do we need to do anything to take advantage of
> it ... as in what would altering the granularity of the page cache buy
> us?

The real benefit is when and how the reads get scheduled.  We're able to
do a much better job pipelining the reads, controlling our caches and
reducing write latency by having the reads done up in the OS instead of
the drive.

-chris

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <clm@fb.com>
To: "James.Bottomley@HansenPartnership.com" 
	<James.Bottomley@HansenPartnership.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"lsf-pc@lists.linux-foundation.org" 
	<lsf-pc@lists.linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"rwheeler@redhat.com" <rwheeler@redhat.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"mgorman@suse.de" <mgorman@suse.de>
Subject: Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes
Date: Wed, 22 Jan 2014 18:02:09 +0000	[thread overview]
Message-ID: <1390413819.1198.20.camel@ret.masoncoding.com> (raw)
In-Reply-To: <1390411300.2372.33.camel@dabdike.int.hansenpartnership.com>

On Wed, 2014-01-22 at 09:21 -0800, James Bottomley wrote:
> On Wed, 2014-01-22 at 17:02 +0000, Chris Mason wrote:

[ I like big sectors and I cannot lie ]

>  
> > I really think that if we want to make progress on this one, we need
> > code and someone that owns it.  Nick's work was impressive, but it was
> > mostly there for getting rid of buffer heads.  If we have a device that
> > needs it and someone working to enable that device, we'll go forward
> > much faster.
> 
> Do we even need to do that (eliminate buffer heads)?  We cope with 4k
> sector only devices just fine today because the bh mechanisms now
> operate on top of the page cache and can do the RMW necessary to update
> a bh in the page cache itself which allows us to do only 4k chunked
> writes, so we could keep the bh system and just alter the granularity of
> the page cache.
> 

We're likely to have people mixing 4K drives and <fill in some other
size here> on the same box.  We could just go with the biggest size and
use the existing bh code for the sub-pagesized blocks, but I really
hesitate to change VM fundamentals for this.

>From a pure code point of view, it may be less work to change it once in
the VM.  But from an overall system impact point of view, it's a big
change in how the system behaves just for filesystem metadata.

> The other question is if the drive does RMW between 4k and whatever its
> physical sector size, do we need to do anything to take advantage of
> it ... as in what would altering the granularity of the page cache buy
> us?

The real benefit is when and how the reads get scheduled.  We're able to
do a much better job pipelining the reads, controlling our caches and
reducing write latency by having the reads done up in the OS instead of
the drive.

-chris


  reply	other threads:[~2014-01-22 18:02 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20  9:30 LSF/MM 2014 Call For Proposals Mel Gorman
2013-12-20  9:30 ` Mel Gorman
2013-12-20  9:30 ` [Lsf-pc] " Mel Gorman
2014-01-06 22:20 ` [LSF/MM TOPIC] [ATTEND] persistent memory progress, management of storage & file systems Ric Wheeler
2014-01-06 22:20   ` Ric Wheeler
2014-01-06 22:32   ` faibish, sorin
2014-01-06 22:32     ` faibish, sorin
2014-01-07 19:44     ` Joel Becker
2014-01-07 19:44       ` Joel Becker
2014-01-21  7:00 ` LSF/MM 2014 Call For Proposals Michel Lespinasse
2014-01-21  7:00   ` Michel Lespinasse
2014-01-22  3:04 ` [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes Ric Wheeler
2014-01-22  3:04   ` Ric Wheeler
2014-01-22  5:20   ` Joel Becker
2014-01-22  5:20     ` Joel Becker
2014-01-22  7:14     ` Hannes Reinecke
2014-01-22  7:14       ` Hannes Reinecke
2014-01-22  7:14       ` Hannes Reinecke
2014-01-22  9:34   ` [Lsf-pc] " Mel Gorman
2014-01-22  9:34     ` Mel Gorman
2014-01-22 14:10     ` Ric Wheeler
2014-01-22 14:10       ` Ric Wheeler
2014-01-22 14:34       ` Mel Gorman
2014-01-22 14:34         ` Mel Gorman
2014-01-22 14:58         ` Ric Wheeler
2014-01-22 14:58           ` Ric Wheeler
2014-01-22 15:19           ` Mel Gorman
2014-01-22 15:19             ` Mel Gorman
2014-01-22 17:02             ` Chris Mason
2014-01-22 17:02               ` Chris Mason
2014-01-22 17:21               ` James Bottomley
2014-01-22 17:21                 ` James Bottomley
2014-01-22 18:02                 ` Chris Mason [this message]
2014-01-22 18:02                   ` Chris Mason
2014-01-22 18:13                   ` James Bottomley
2014-01-22 18:13                     ` James Bottomley
2014-01-22 18:17                     ` Ric Wheeler
2014-01-22 18:17                       ` Ric Wheeler
2014-01-22 18:35                       ` James Bottomley
2014-01-22 18:35                         ` James Bottomley
2014-01-22 18:39                         ` Ric Wheeler
2014-01-22 18:39                           ` Ric Wheeler
2014-01-22 19:30                           ` James Bottomley
2014-01-22 19:30                             ` James Bottomley
2014-01-22 19:50                             ` Andrew Morton
2014-01-22 19:50                               ` Andrew Morton
2014-01-22 20:13                               ` Chris Mason
2014-01-22 20:13                                 ` Chris Mason
2014-01-23  2:46                                 ` David Lang
2014-01-23  2:46                                   ` David Lang
2014-01-23  5:21                                   ` Theodore Ts'o
2014-01-23  5:21                                     ` Theodore Ts'o
2014-01-23  8:35                               ` Dave Chinner
2014-01-23  8:35                                 ` Dave Chinner
2014-01-23 12:55                                 ` Theodore Ts'o
2014-01-23 12:55                                   ` Theodore Ts'o
2014-01-23 19:49                                   ` Dave Chinner
2014-01-23 19:49                                     ` Dave Chinner
2014-01-23 21:21                                   ` Joel Becker
2014-01-23 21:21                                     ` Joel Becker
2014-01-22 20:57                             ` Martin K. Petersen
2014-01-22 20:57                               ` Martin K. Petersen
2014-01-22 20:57                               ` Martin K. Petersen
2014-01-22 18:37                     ` Chris Mason
2014-01-22 18:37                       ` Chris Mason
2014-01-22 18:40                       ` Ric Wheeler
2014-01-22 18:40                         ` Ric Wheeler
2014-01-22 18:47                       ` James Bottomley
2014-01-22 18:47                         ` James Bottomley
2014-01-23 21:27                         ` Joel Becker
2014-01-23 21:27                           ` Joel Becker
2014-01-23 21:34                           ` Chris Mason
2014-01-23 21:34                             ` Chris Mason
2014-01-23  8:27                     ` Dave Chinner
2014-01-23  8:27                       ` Dave Chinner
2014-01-23 15:47                       ` James Bottomley
2014-01-23 15:47                         ` James Bottomley
2014-01-23 16:44                         ` Mel Gorman
2014-01-23 16:44                           ` Mel Gorman
2014-01-23 19:55                           ` James Bottomley
2014-01-23 19:55                             ` James Bottomley
2014-01-24 10:57                             ` Mel Gorman
2014-01-24 10:57                               ` Mel Gorman
2014-01-30  4:52                               ` Matthew Wilcox
2014-01-30  4:52                                 ` Matthew Wilcox
2014-01-30  6:01                                 ` Dave Chinner
2014-01-30  6:01                                   ` Dave Chinner
2014-01-30 10:50                                 ` Mel Gorman
2014-01-30 10:50                                   ` Mel Gorman
2014-01-23 20:34                           ` Dave Chinner
2014-01-23 20:34                             ` Dave Chinner
2014-01-23 20:54                         ` Christoph Lameter
2014-01-23 20:54                           ` Christoph Lameter
2014-01-23  8:24                 ` Dave Chinner
2014-01-23  8:24                   ` Dave Chinner
2014-01-23 20:48             ` Christoph Lameter
2014-01-23 20:48               ` Christoph Lameter
2014-01-22 20:47           ` Martin K. Petersen
2014-01-22 20:47             ` Martin K. Petersen
2014-01-23  8:21         ` Dave Chinner
2014-01-23  8:21           ` Dave Chinner
2014-01-22 15:14     ` Chris Mason
2014-01-22 15:14       ` Chris Mason
2014-01-22 16:03       ` James Bottomley
2014-01-22 16:03         ` James Bottomley
2014-01-22 16:45         ` Ric Wheeler
2014-01-22 16:45           ` Ric Wheeler
2014-01-22 17:00           ` James Bottomley
2014-01-22 17:00             ` James Bottomley
2014-01-22 21:05             ` Jan Kara
2014-01-22 21:05               ` Jan Kara
2014-01-23 20:47     ` Christoph Lameter
2014-01-23 20:47       ` Christoph Lameter
2014-01-24 11:09       ` Mel Gorman
2014-01-24 11:09         ` Mel Gorman
2014-01-24 15:44         ` Christoph Lameter
2014-01-24 15:44           ` Christoph Lameter
2014-01-22 15:54   ` James Bottomley
2014-01-22 15:54     ` James Bottomley
2014-03-14  9:02 ` Update on LSF/MM [was Re: LSF/MM 2014 Call For Proposals] James Bottomley
2014-03-14  9:02   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390413819.1198.20.camel@ret.masoncoding.com \
    --to=clm@fb.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    --cc=mgorman@suse.de \
    --cc=rwheeler@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.