From: "Ivan T. Ivanov" <iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
To: Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bjorn Andersson
<bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
Subject: Re: [PATCH 2/4] spi: qup: Correct selection of FIFO/Block mode
Date: Mon, 19 May 2014 10:31:44 +0300 [thread overview]
Message-ID: <1400484704.1464.4.camel@iivanov-dev> (raw)
In-Reply-To: <1400016884-9568-3-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Tue, 2014-05-13 at 16:34 -0500, Andy Gross wrote:
> This patch fixes the calculation for determining whether to use FIFO or BLOCK
> mode.
<snip>
> @@ -368,7 +368,7 @@ static int spi_qup_io_config(struct spi_device *spi, struct spi_transfer *xfer)
> n_words = xfer->len / w_size;
> controller->w_size = w_size;
>
> - if (n_words <= controller->in_fifo_sz) {
> + if (n_words <= (controller->in_fifo_sz / sizeof(u32))) {
Wouldn't be better to divide by w_size? Probably will not make
too much difference, but..
> mode = QUP_IO_M_MODE_FIFO;
Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] spi: qup: Correct selection of FIFO/Block mode
Date: Mon, 19 May 2014 10:31:44 +0300 [thread overview]
Message-ID: <1400484704.1464.4.camel@iivanov-dev> (raw)
In-Reply-To: <1400016884-9568-3-git-send-email-agross@codeaurora.org>
On Tue, 2014-05-13 at 16:34 -0500, Andy Gross wrote:
> This patch fixes the calculation for determining whether to use FIFO or BLOCK
> mode.
<snip>
> @@ -368,7 +368,7 @@ static int spi_qup_io_config(struct spi_device *spi, struct spi_transfer *xfer)
> n_words = xfer->len / w_size;
> controller->w_size = w_size;
>
> - if (n_words <= controller->in_fifo_sz) {
> + if (n_words <= (controller->in_fifo_sz / sizeof(u32))) {
Wouldn't be better to divide by w_size? Probably will not make
too much difference, but..
> mode = QUP_IO_M_MODE_FIFO;
Regards,
Ivan
WARNING: multiple messages have this Message-ID (diff)
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Andy Gross <agross@codeaurora.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH 2/4] spi: qup: Correct selection of FIFO/Block mode
Date: Mon, 19 May 2014 10:31:44 +0300 [thread overview]
Message-ID: <1400484704.1464.4.camel@iivanov-dev> (raw)
In-Reply-To: <1400016884-9568-3-git-send-email-agross@codeaurora.org>
On Tue, 2014-05-13 at 16:34 -0500, Andy Gross wrote:
> This patch fixes the calculation for determining whether to use FIFO or BLOCK
> mode.
<snip>
> @@ -368,7 +368,7 @@ static int spi_qup_io_config(struct spi_device *spi, struct spi_transfer *xfer)
> n_words = xfer->len / w_size;
> controller->w_size = w_size;
>
> - if (n_words <= controller->in_fifo_sz) {
> + if (n_words <= (controller->in_fifo_sz / sizeof(u32))) {
Wouldn't be better to divide by w_size? Probably will not make
too much difference, but..
> mode = QUP_IO_M_MODE_FIFO;
Regards,
Ivan
next prev parent reply other threads:[~2014-05-19 7:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 21:34 [PATCH 0/4] spi: qup: Fixes and new version support Andy Gross
2014-05-13 21:34 ` Andy Gross
[not found] ` <1400016884-9568-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-13 21:34 ` [PATCH 1/4] spi: qup: Remove chip select function Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-19 8:07 ` Ivan T. Ivanov
2014-05-19 8:07 ` Ivan T. Ivanov
2014-06-12 4:02 ` Andy Gross
2014-06-12 4:02 ` Andy Gross
2014-06-12 4:02 ` Andy Gross
2014-05-13 21:34 ` [PATCH 2/4] spi: qup: Correct selection of FIFO/Block mode Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-14 15:17 ` Mark Brown
2014-05-14 15:17 ` Mark Brown
[not found] ` <1400016884-9568-3-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-19 7:31 ` Ivan T. Ivanov [this message]
2014-05-19 7:31 ` Ivan T. Ivanov
2014-05-19 7:31 ` Ivan T. Ivanov
2014-05-13 21:34 ` [PATCH 4/4] spi: qup: Add support for v1.1.1 Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-13 21:34 ` Andy Gross
[not found] ` <1400016884-9568-5-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-13 22:08 ` Stephen Boyd
2014-05-13 22:08 ` Stephen Boyd
2014-05-13 22:08 ` Stephen Boyd
[not found] ` <20140513220845.GH20486-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-13 22:20 ` Andy Gross
2014-05-13 22:20 ` Andy Gross
2014-05-13 22:20 ` Andy Gross
2014-05-19 8:10 ` Ivan T. Ivanov
2014-05-19 8:10 ` Ivan T. Ivanov
2014-05-13 21:34 ` [PATCH 3/4] spi: qup: Fix order of spi_register_master Andy Gross
2014-05-13 21:34 ` Andy Gross
[not found] ` <1400016884-9568-4-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-19 8:51 ` Ivan T. Ivanov
2014-05-19 8:51 ` Ivan T. Ivanov
2014-05-19 8:51 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400484704.1464.4.camel@iivanov-dev \
--to=iivanov-neyub+7iv8pqt0dzr+alfa@public.gmane.org \
--cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.