From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Andy Gross <agross@codeaurora.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH 1/4] spi: qup: Remove chip select function
Date: Mon, 19 May 2014 11:07:38 +0300 [thread overview]
Message-ID: <1400486858.1464.11.camel@iivanov-dev> (raw)
In-Reply-To: <1400016884-9568-2-git-send-email-agross@codeaurora.org>
Hi Andy,
On Tue, 2014-05-13 at 16:34 -0500, Andy Gross wrote:
> This patch removes the chip select function. Chip select should instead be
> supported using GPIOs, defining the DT entry "cs-gpios", and letting the SPI
> core assert/deassert the chip select as it sees fit.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
<snip>
> +- num-cs: total number of chipselects
My understanding is that "num-cs" have to be parsed by
master driver, not by core SPI driver.
> -
> - /* Disable auto CS toggle and use manual */
> - iocontol &= ~SPI_IO_C_MX_CS_MODE;
Probably we should keep this?
Regards,
Ivan
WARNING: multiple messages have this Message-ID (diff)
From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] spi: qup: Remove chip select function
Date: Mon, 19 May 2014 11:07:38 +0300 [thread overview]
Message-ID: <1400486858.1464.11.camel@iivanov-dev> (raw)
In-Reply-To: <1400016884-9568-2-git-send-email-agross@codeaurora.org>
Hi Andy,
On Tue, 2014-05-13 at 16:34 -0500, Andy Gross wrote:
> This patch removes the chip select function. Chip select should instead be
> supported using GPIOs, defining the DT entry "cs-gpios", and letting the SPI
> core assert/deassert the chip select as it sees fit.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
<snip>
> +- num-cs: total number of chipselects
My understanding is that "num-cs" have to be parsed by
master driver, not by core SPI driver.
> -
> - /* Disable auto CS toggle and use manual */
> - iocontol &= ~SPI_IO_C_MX_CS_MODE;
Probably we should keep this?
Regards,
Ivan
next prev parent reply other threads:[~2014-05-19 8:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 21:34 [PATCH 0/4] spi: qup: Fixes and new version support Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-13 21:34 ` [PATCH 3/4] spi: qup: Fix order of spi_register_master Andy Gross
2014-05-13 21:34 ` Andy Gross
[not found] ` <1400016884-9568-4-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-19 8:51 ` Ivan T. Ivanov
2014-05-19 8:51 ` Ivan T. Ivanov
2014-05-19 8:51 ` Ivan T. Ivanov
[not found] ` <1400016884-9568-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-13 21:34 ` [PATCH 1/4] spi: qup: Remove chip select function Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-19 8:07 ` Ivan T. Ivanov [this message]
2014-05-19 8:07 ` Ivan T. Ivanov
2014-06-12 4:02 ` Andy Gross
2014-06-12 4:02 ` Andy Gross
2014-06-12 4:02 ` Andy Gross
2014-05-13 21:34 ` [PATCH 2/4] spi: qup: Correct selection of FIFO/Block mode Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-14 15:17 ` Mark Brown
2014-05-14 15:17 ` Mark Brown
[not found] ` <1400016884-9568-3-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-19 7:31 ` Ivan T. Ivanov
2014-05-19 7:31 ` Ivan T. Ivanov
2014-05-19 7:31 ` Ivan T. Ivanov
2014-05-13 21:34 ` [PATCH 4/4] spi: qup: Add support for v1.1.1 Andy Gross
2014-05-13 21:34 ` Andy Gross
2014-05-13 21:34 ` Andy Gross
[not found] ` <1400016884-9568-5-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-13 22:08 ` Stephen Boyd
2014-05-13 22:08 ` Stephen Boyd
2014-05-13 22:08 ` Stephen Boyd
[not found] ` <20140513220845.GH20486-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-05-13 22:20 ` Andy Gross
2014-05-13 22:20 ` Andy Gross
2014-05-13 22:20 ` Andy Gross
2014-05-19 8:10 ` Ivan T. Ivanov
2014-05-19 8:10 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400486858.1464.11.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.