From: Ian Campbell <Ian.Campbell@citrix.com>
To: Alexandra Sandulescu <alecsandra.sandulescu@gmail.com>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse network device options
Date: Fri, 24 Oct 2014 10:02:15 +0100 [thread overview]
Message-ID: <1414141335.15687.15.camel@citrix.com> (raw)
In-Reply-To: <CAAcqHeh8cFDa-dP_2Znt0J3-iZhSamZrGrmfxfEyF_rT4Dj_Dw@mail.gmail.com>
On Fri, 2014-10-24 at 11:58 +0300, Alexandra Sandulescu wrote:
Please don't top post on the xen-devel list.
> I have tested stuff by hand (I took the code and created some
> structures - a bit of workaround let's say).
What do you mean here? Have you run the xl command on a real Xen system
with these patch applied?
> Should I test it with OSSTest too?
If you've tested manually on a real Xen system I don't think this is
necessary, although if you are interested in getting osstest going then
I am quite happy to offer guidance where necessary.
> What I understood from Wei is that he tested my patch. Maybe I got it
> wrong.
That's not how I understood his comment, but I'll let him clarify.
Ian.
next prev parent reply other threads:[~2014-10-24 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 21:36 [OPW PATCH V4] tools: xl: refactor code to parse network device options Alexandra Sandulescu
2014-10-22 11:35 ` Ian Campbell
2014-10-22 20:21 ` Konrad Rzeszutek Wilk
2014-10-23 7:56 ` Ian Campbell
2014-10-23 20:08 ` Konrad Rzeszutek Wilk
2014-10-23 21:20 ` Ian Campbell
2014-10-23 23:08 ` Konrad Rzeszutek Wilk
2014-10-24 8:01 ` Ian Campbell
2014-10-24 8:58 ` Alexandra Sandulescu
2014-10-24 9:02 ` Ian Campbell [this message]
2014-10-24 9:12 ` Alexandra Sandulescu
2014-10-24 9:14 ` Ian Campbell
2014-10-24 9:17 ` Alexandra Sandulescu
2014-10-24 17:16 ` Konrad Rzeszutek Wilk
2014-10-24 17:17 ` Konrad Rzeszutek Wilk
2014-10-28 8:54 ` Alexandra Sandulescu
2014-10-24 9:32 ` Wei Liu
2015-01-12 17:58 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414141335.15687.15.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=alecsandra.sandulescu@gmail.com \
--cc=konrad@darnok.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.