All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Alexandra Sandulescu <alecsandra.sandulescu@gmail.com>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>,
	Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse network device options
Date: Fri, 24 Oct 2014 10:14:02 +0100	[thread overview]
Message-ID: <1414142042.15687.19.camel@citrix.com> (raw)
In-Reply-To: <CAAcqHei3SkfDy=diXSJXjqf+Sbhe66BA2HG3ZozkaOfgUhniYA@mail.gmail.com>

On Fri, 2014-10-24 at 12:12 +0300, Alexandra Sandulescu wrote:
> No I did not. I was easier to test the functions. I used the expected
> arguments from .cfg and for networkattach command.
> 
> If you want to test using the xl command, I will.
> 
> It looked a bit too much for me because  my patch does not really
> introduce new code.

Part of the purpose of this stage of the application process is not just
to change the code but also to start to gain familiarity with the Xen
system and set on up etc.

Although testing the functions in isolation can sometimes be OK I think
given the above it would preferred to setup an actual Xen system and run
the code in a real environment.

Ian.

  reply	other threads:[~2014-10-24  9:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21 21:36 [OPW PATCH V4] tools: xl: refactor code to parse network device options Alexandra Sandulescu
2014-10-22 11:35 ` Ian Campbell
2014-10-22 20:21   ` Konrad Rzeszutek Wilk
2014-10-23  7:56     ` Ian Campbell
2014-10-23 20:08       ` Konrad Rzeszutek Wilk
2014-10-23 21:20         ` Ian Campbell
2014-10-23 23:08           ` Konrad Rzeszutek Wilk
2014-10-24  8:01             ` Ian Campbell
2014-10-24  8:58               ` Alexandra Sandulescu
2014-10-24  9:02                 ` Ian Campbell
2014-10-24  9:12                   ` Alexandra Sandulescu
2014-10-24  9:14                     ` Ian Campbell [this message]
2014-10-24  9:17                       ` Alexandra Sandulescu
2014-10-24 17:16                 ` Konrad Rzeszutek Wilk
2014-10-24 17:17               ` Konrad Rzeszutek Wilk
2014-10-28  8:54                 ` Alexandra Sandulescu
2014-10-24  9:32         ` Wei Liu
2015-01-12 17:58   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414142042.15687.19.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=alecsandra.sandulescu@gmail.com \
    --cc=konrad@darnok.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.