From: Ian Campbell <Ian.Campbell@citrix.com>
To: Alexandra Sandulescu <alecsandra.sandulescu@gmail.com>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com, konrad@darnok.org
Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse network device options
Date: Mon, 12 Jan 2015 17:58:55 +0000 [thread overview]
Message-ID: <1421085535.28776.45.camel@citrix.com> (raw)
In-Reply-To: <1413977758.19198.12.camel@citrix.com>
On Wed, 2014-10-22 at 12:35 +0100, Ian Campbell wrote:
> On Wed, 2014-10-22 at 00:36 +0300, Alexandra Sandulescu wrote:
> > This patch removes duplicate code in /tools/libxl/xl_cmdimpl.c by
> > adding parse_nic_config function. This function parses configuration
> > data and adds the information into libxl_device_nic struct. It is
> > called in both main_networkattach and parse_config_data functions
> > to replace duplicate code.
> >
> > Signed-off-by: Alexandra Sandulescu <alecsandra.sandulescu@gmail.com>
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> This looks good to me, thanks.
I've now applied this since the freeze is over.
Ian.
prev parent reply other threads:[~2015-01-12 18:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 21:36 [OPW PATCH V4] tools: xl: refactor code to parse network device options Alexandra Sandulescu
2014-10-22 11:35 ` Ian Campbell
2014-10-22 20:21 ` Konrad Rzeszutek Wilk
2014-10-23 7:56 ` Ian Campbell
2014-10-23 20:08 ` Konrad Rzeszutek Wilk
2014-10-23 21:20 ` Ian Campbell
2014-10-23 23:08 ` Konrad Rzeszutek Wilk
2014-10-24 8:01 ` Ian Campbell
2014-10-24 8:58 ` Alexandra Sandulescu
2014-10-24 9:02 ` Ian Campbell
2014-10-24 9:12 ` Alexandra Sandulescu
2014-10-24 9:14 ` Ian Campbell
2014-10-24 9:17 ` Alexandra Sandulescu
2014-10-24 17:16 ` Konrad Rzeszutek Wilk
2014-10-24 17:17 ` Konrad Rzeszutek Wilk
2014-10-28 8:54 ` Alexandra Sandulescu
2014-10-24 9:32 ` Wei Liu
2015-01-12 17:58 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421085535.28776.45.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=alecsandra.sandulescu@gmail.com \
--cc=konrad@darnok.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.