From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST v3 04/11] overlay: update overlay/etc/grub.d/20_linux_xen
Date: Wed, 10 Dec 2014 13:52:47 +0000 [thread overview]
Message-ID: <1418219567.3505.55.camel@citrix.com> (raw)
In-Reply-To: <20141210135042.GE19059@zion.uk.xensource.com>
On Wed, 2014-12-10 at 13:50 +0000, Wei Liu wrote:
> On Wed, Dec 10, 2014 at 01:47:06PM +0000, Ian Campbell wrote:
> > On Wed, 2014-12-10 at 13:41 +0000, Wei Liu wrote:
> > > On Wed, Dec 10, 2014 at 12:54:05PM +0000, Ian Campbell wrote:
> > > > #690538 relates to providing an option to remove the submenus. Please
> > > > can the changelog explain why that is relevant to us.
> > > >
> > >
> > > Because somebody else thought not making submenu optional is a bug. So
> > > do I.
> >
> > I meant: why is this important to osstest? does using submenus break
> > something? if so then what? if not then there is no reason to be
> > diverging from the baseline.
> >
>
> Submenu breaks OSSTest's grub menu parser, causing test step to fail.
Great, that's a good reason to diverge, but please say it somewhere like
in the commit log.
I think the parser should also gain a comment with a reference to either
the bug or this discussion saying that it relies on grub not using
submenus.
Ian.
next prev parent reply other threads:[~2014-12-10 13:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 21:50 [PATCH OSSTEST v3 00/11] XSM test case for OSSTest Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 01/11] README: list chiark-utils-bin as requirement Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 02/11] gitignore: ignore images directory Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 03/11] ts-debian-install: rename cfg_xend to cfg Wei Liu
2014-12-10 12:44 ` Ian Campbell
2014-10-14 21:50 ` [PATCH OSSTEST v3 04/11] overlay: update overlay/etc/grub.d/20_linux_xen Wei Liu
2014-12-10 12:54 ` Ian Campbell
2014-12-10 13:41 ` Wei Liu
2014-12-10 13:47 ` Ian Campbell
2014-12-10 13:50 ` Wei Liu
2014-12-10 13:52 ` Ian Campbell [this message]
2014-10-14 21:50 ` [PATCH OSSTEST v3 05/11] ts-xen-build-prep: install checkpolicy Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 06/11] ts-xen-build: build with XSM support if requested Wei Liu
2014-12-10 13:05 ` Ian Campbell
2014-12-10 13:47 ` Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 07/11] mfi-common: create build-$arch-xsm job Wei Liu
2014-12-10 13:12 ` Ian Campbell
2014-12-10 13:32 ` Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 08/11] Debian.pm: pass in XSM configuration to bootloader setup routines Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 09/11] Debian.pm: load flask policy in uboot Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 10/11] ts-xen-install: install Xen with XSM support if requested Wei Liu
2014-12-10 13:15 ` Ian Campbell
2014-12-10 13:34 ` Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 11/11] mfi-common, make-flight: create XSM test jobs Wei Liu
2014-12-10 13:28 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418219567.3505.55.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.