Re: [PATCH OSSTEST v3 07/11] mfi-common: create build-$arch-xsm job

[Ian Campbell <Ian.Campbell@citrix.com>]

On Tue, 2014-10-14 at 22:50 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  mfi-common |   23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/mfi-common b/mfi-common
> index 5c4f5d5..e772086 100644
> --- a/mfi-common
> +++ b/mfi-common
> @@ -41,6 +41,19 @@ branch_wants_rumpkernel_tests () {
>    esac
>  }
>  
> +xenbranch_wants_xsm_tests () {
> +    # Test XSM from 4.5 onwards
> +    case "$xenbranch" in
> +    xen-3.*-testing) echo "n";;
> +    xen-4.0-testing) echo "n";;
> +    xen-4.1-testing) echo "n";;
> +    xen-4.2-testing) echo "n";;
> +    xen-4.3-testing) echo "n";;
> +    xen-4.4-testing) echo "n";;
> +    *) echo "n y";

Did you mean just "y" here, or is something very subtle going on?

Oh I see, you run over the result of this as a list with for. Sneaky!

I think you should name it something like xenbranch_xsm_variants or
something else which doesn't make the reader expect it to return a
boolean.

Ian.