From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST v3 04/11] overlay: update overlay/etc/grub.d/20_linux_xen
Date: Wed, 10 Dec 2014 12:54:05 +0000 [thread overview]
Message-ID: <1418216045.3505.28.camel@citrix.com> (raw)
In-Reply-To: <1413323416-21778-5-git-send-email-wei.liu2@citrix.com>
On Tue, 2014-10-14 at 22:50 +0100, Wei Liu wrote:
> This file was created to work around Debian bug #633127.
>
> According to Debian bug tracker [0], this bug is fixed in Wheezy. As
> we're now using Wheezy in OSSTest we can safely remove this overlay
> file.
>
> Also add a note to reference #633127 above grub2 setup function, in case
> someone trips over #633127.
>
> As we're now using Wheezy in production, update this file to Wheezy's
> version and take care of Debian bug #690538 and GRUB bug #43420.
When reference bugs it would be useful to include the bug title here so
the reader doesn't have to go and look it up.
#690538 relates to providing an option to remove the submenus. Please
can the changelog explain why that is relevant to us.
Did you fix it by removing/reverting the submenu support altogether, as
opposed to e.g. importing the patch from Eric Fischer in the bug report?
I don't see stuff which I'd expect if you had applied the patch. I think
it would be worth spelling out in a bit more detail what the changes
you've made to the baseline for each bug were.
I suppose constructing overlay/etc/grub.d/20_linux_xen from a baseline
unmodified version (checked in, not retrieved from the host) and a
mini-patch-series (also checked in) on the fly is over complexifying
things?
Ian.
next prev parent reply other threads:[~2014-12-10 12:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 21:50 [PATCH OSSTEST v3 00/11] XSM test case for OSSTest Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 01/11] README: list chiark-utils-bin as requirement Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 02/11] gitignore: ignore images directory Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 03/11] ts-debian-install: rename cfg_xend to cfg Wei Liu
2014-12-10 12:44 ` Ian Campbell
2014-10-14 21:50 ` [PATCH OSSTEST v3 04/11] overlay: update overlay/etc/grub.d/20_linux_xen Wei Liu
2014-12-10 12:54 ` Ian Campbell [this message]
2014-12-10 13:41 ` Wei Liu
2014-12-10 13:47 ` Ian Campbell
2014-12-10 13:50 ` Wei Liu
2014-12-10 13:52 ` Ian Campbell
2014-10-14 21:50 ` [PATCH OSSTEST v3 05/11] ts-xen-build-prep: install checkpolicy Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 06/11] ts-xen-build: build with XSM support if requested Wei Liu
2014-12-10 13:05 ` Ian Campbell
2014-12-10 13:47 ` Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 07/11] mfi-common: create build-$arch-xsm job Wei Liu
2014-12-10 13:12 ` Ian Campbell
2014-12-10 13:32 ` Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 08/11] Debian.pm: pass in XSM configuration to bootloader setup routines Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 09/11] Debian.pm: load flask policy in uboot Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 10/11] ts-xen-install: install Xen with XSM support if requested Wei Liu
2014-12-10 13:15 ` Ian Campbell
2014-12-10 13:34 ` Wei Liu
2014-10-14 21:50 ` [PATCH OSSTEST v3 11/11] mfi-common, make-flight: create XSM test jobs Wei Liu
2014-12-10 13:28 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418216045.3505.28.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.