Re: [PATCH v3 3/4] docs: add pvscsi.txt

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-03-06 at 16:11 +0100, Olaf Hering wrote:
> On Fri, Mar 06, Wei Liu wrote:
> 
> > On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote:
> > > +== TODO ===
> > > +
> > > +How to do live migration?
> > > + - pdev will likely be evaluated again on the target host if it came from
> > > +   domU.cfg. But what about pdev from 'xl scsi-attach pdev vdev'? Its required
> > > +   to adjust h:c:t:l on the target host.
> > > +
> > > +How to handle FIXME in libxl_retrieve_domain_configuration?
> > > + - "MERGE(vscsi, vscsis, COMPARE_DEVID, {});", when does this code run?
> > > + 
> > 
> > I don't think this kind of information that relates to libxl internal
> > belongs here.
> 
> Its the overall TODO list, it has to go somewhere. And it will be
> removed once its empty.

I'm not convinced it needs to go anywhere other than perhaps the cover
letter or your own ledger.

There doesn't seem to be very much in this document which actually
belongs, almost everything should be somewhere else IMHO.

"== Config Format ==" certainly belongs in xl.cfg(5) and not here as do
"== Configuring FOO backend ==" (or perhaps a relevant "host setup" wiki
page).

"== Xenstore Format ==" belongs in either
docs/misc/xenstore-paths.markdown or (more likely) in vscsiif.h. So does
"== Backend - Frontend Protocol ==".

"== Interface in xl ==" belongs in the xl manpages.

"== Interface in libxl ==" is a waste of time as it stands, but if it
contained useful information it should go in libxl.h.

"== Interface in libvirt ==" should go in the libvirt docs.

Ian.