From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 4/4] libxl: add support for vscsi
Date: Wed, 11 Mar 2015 15:24:22 +0000 [thread overview]
Message-ID: <1426087462.21353.275.camel@citrix.com> (raw)
In-Reply-To: <20150306143125.GX12103@zion.uk.xensource.com>
On Fri, 2015-03-06 at 14:31 +0000, Wei Liu wrote:
> > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst,
> > + libxl_vscsi_dev *dev)
> > +{
>
> Can this only be an internal function? I.e. use libxl__ namespace.
And take a libxl__gc *gc not a libxl_ctx, except in very exception
circumstances.
>
> Same comment applies to similar functions.
>
> Wei.
next prev parent reply other threads:[~2015-03-11 15:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 9:45 [PATCH v3 0/4] libbxl: add support for pvscsi, iteration 3 Olaf Hering
2015-03-06 9:45 ` [PATCH v3 1/4] vscsiif.h: fix WWN notation for p-dev property Olaf Hering
2015-03-06 9:45 ` [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown Olaf Hering
2015-03-06 13:55 ` Wei Liu
2015-03-06 15:07 ` Olaf Hering
2015-03-06 9:45 ` [PATCH v3 3/4] docs: add pvscsi.txt Olaf Hering
2015-03-06 13:55 ` Wei Liu
2015-03-06 15:11 ` Olaf Hering
2015-03-06 15:37 ` Wei Liu
2015-03-11 15:23 ` Ian Campbell
2015-03-06 9:45 ` [PATCH v3 4/4] libxl: add support for vscsi Olaf Hering
2015-03-06 14:31 ` Wei Liu
2015-03-06 15:25 ` Olaf Hering
2015-03-06 15:53 ` Wei Liu
2015-03-09 16:08 ` Olaf Hering
2015-03-09 16:46 ` Wei Liu
2015-03-11 15:24 ` Ian Campbell [this message]
2015-03-11 15:33 ` Ian Campbell
2015-03-11 16:02 ` Olaf Hering
2015-03-11 16:09 ` Ian Campbell
2015-03-13 13:49 ` Olaf Hering
2015-03-11 16:06 ` Olaf Hering
2015-03-12 16:07 ` Olaf Hering
2015-03-12 16:47 ` Ian Campbell
2015-03-13 13:45 ` Olaf Hering
2015-03-13 15:10 ` Wei Liu
2015-03-16 8:16 ` Olaf Hering
2015-03-16 11:30 ` Wei Liu
2015-03-12 16:20 ` Olaf Hering
2015-03-12 16:46 ` Ian Campbell
2015-03-13 13:44 ` Olaf Hering
2015-03-13 14:18 ` Ian Campbell
2015-03-26 12:55 ` Olaf Hering
2015-03-26 13:46 ` Ian Campbell
2015-03-27 7:38 ` Olaf Hering
2015-04-10 9:23 ` wating for backend changes (was Re: [PATCH v3 4/4] libxl: add support for vscsi) Olaf Hering
2015-04-14 15:55 ` Olaf Hering
2015-04-15 11:50 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426087462.21353.275.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.