Re: [PATCH v3 4/4] libxl: add support for vscsi

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-03-11 at 17:02 +0100, Olaf Hering wrote:
> On Wed, Mar 11, Ian Campbell wrote:
> 
> > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst,
> > > +                                   libxl_vscsi_dev *dev);
> > > +int libxl_device_vscsi_get_host(libxl_ctx *ctx,
> > > +                                uint32_t domid,
> > > +                                const char *cfg,
> > > +                                libxl_device_vscsi **vscsi_host);
> > What do these two non-standard functions do?
> > 
> > In general the caller would be expected to provide a libxl_device_vscsi,
> > which will be filled in, rather than having the function allocate one.
> > 
> > > +int libxl_device_vscsi_parse(libxl_ctx *ctx, const char *cfg,
> > > +                             libxl_device_vscsi *vscsi_host,
> > > +                             libxl_vscsi_dev *vscsi_dev);
> > 
> > Like with disk, this is xend/xl specific but might be of use to other
> > toolstacks, therefore it belongs in libxlu not in libxl proper.
> > (this might apply to get_host too, depending on what it does)
> 
> libvirt for example will do the very same what xl currently does. But so
> far I did not get to libvirt yet. The interface is not finished yet.

That sort of "libvirt uses some xm/xl style syntax" is exactly why
libxlu exists.