From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 4/4] libxl: add support for vscsi
Date: Mon, 9 Mar 2015 17:08:31 +0100 [thread overview]
Message-ID: <20150309160831.GA1755@aepfle.de> (raw)
In-Reply-To: <20150306143125.GX12103@zion.uk.xensource.com>
On Fri, Mar 06, Wei Liu wrote:
> > +void libxl__device_vscsi_add(libxl__egc *egc, uint32_t domid,
> > + libxl_device_vscsi *vscsi,
> > + libxl__ao_device *aodev)
> You need to update this domain's JSON configuration. Cf.
> libxl__device_vtpm_add and friends. Also look at libxl_internal.h L2310.
Its not clear to me why every libxl__device_<type>_add copies the passed
in libxl_device_<type> into a local named <type>_saved. Why is it not
enough to work directly with the input? Its not obvious what the purpose
of that copy is, nothing seems to alter the input.
Olaf
next prev parent reply other threads:[~2015-03-09 16:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 9:45 [PATCH v3 0/4] libbxl: add support for pvscsi, iteration 3 Olaf Hering
2015-03-06 9:45 ` [PATCH v3 1/4] vscsiif.h: fix WWN notation for p-dev property Olaf Hering
2015-03-06 9:45 ` [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown Olaf Hering
2015-03-06 13:55 ` Wei Liu
2015-03-06 15:07 ` Olaf Hering
2015-03-06 9:45 ` [PATCH v3 3/4] docs: add pvscsi.txt Olaf Hering
2015-03-06 13:55 ` Wei Liu
2015-03-06 15:11 ` Olaf Hering
2015-03-06 15:37 ` Wei Liu
2015-03-11 15:23 ` Ian Campbell
2015-03-06 9:45 ` [PATCH v3 4/4] libxl: add support for vscsi Olaf Hering
2015-03-06 14:31 ` Wei Liu
2015-03-06 15:25 ` Olaf Hering
2015-03-06 15:53 ` Wei Liu
2015-03-09 16:08 ` Olaf Hering [this message]
2015-03-09 16:46 ` Wei Liu
2015-03-11 15:24 ` Ian Campbell
2015-03-11 15:33 ` Ian Campbell
2015-03-11 16:02 ` Olaf Hering
2015-03-11 16:09 ` Ian Campbell
2015-03-13 13:49 ` Olaf Hering
2015-03-11 16:06 ` Olaf Hering
2015-03-12 16:07 ` Olaf Hering
2015-03-12 16:47 ` Ian Campbell
2015-03-13 13:45 ` Olaf Hering
2015-03-13 15:10 ` Wei Liu
2015-03-16 8:16 ` Olaf Hering
2015-03-16 11:30 ` Wei Liu
2015-03-12 16:20 ` Olaf Hering
2015-03-12 16:46 ` Ian Campbell
2015-03-13 13:44 ` Olaf Hering
2015-03-13 14:18 ` Ian Campbell
2015-03-26 12:55 ` Olaf Hering
2015-03-26 13:46 ` Ian Campbell
2015-03-27 7:38 ` Olaf Hering
2015-04-10 9:23 ` wating for backend changes (was Re: [PATCH v3 4/4] libxl: add support for vscsi) Olaf Hering
2015-04-14 15:55 ` Olaf Hering
2015-04-15 11:50 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309160831.GA1755@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.