From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support
Date: Thu, 07 May 2015 10:10:47 +0200 [thread overview]
Message-ID: <1430986247.8171.37.camel@x220> (raw)
In-Reply-To: <1430904693-1404-4-git-send-email-jenskuske@gmail.com>
On Wed, 2015-05-06 at 11:31 +0200, Jens Kuske wrote:
> --- a/drivers/pinctrl/sunxi/Kconfig
> +++ b/drivers/pinctrl/sunxi/Kconfig
> +config PINCTRL_SUN8I_H3
> + def_bool MACH_SUN8I
> + select PINCTRL_SUNXI_COMMON
> --- a/drivers/pinctrl/sunxi/Makefile
> +++ b/drivers/pinctrl/sunxi/Makefile
> +obj-$(CONFIG_PINCTRL_SUN8I_H3) += pinctrl-sun8i-h3.o
PINCTRL_SUN8I_H3 is a bool symbol, so pinctrl-sun8i-h3.o will never be
part of a module, right?
(Note that PINCTRL_SUN8I_H3 appears to be an alias for MACH_SUN8I. Ie,
these two symbols operate in lockstep.)
> --- /dev/null
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
> +#include <linux/module.h>
> +MODULE_DEVICE_TABLE(of, sun8i_h3_pinctrl_match);
> +MODULE_AUTHOR("Jens Kuske <jenskuske@gmail.com>");
> +MODULE_DESCRIPTION("Allwinner H3 pinctrl driver");
> +MODULE_LICENSE("GPL");
This adds some module specific boilerplate. Was it perhaps your
intention to make PINCTRL_SUN8I_H3 a tristate symbol?
Thanks,
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
To: Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Maxime Ripard"
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
"Mike Turquette"
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Vinod Koul" <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support
Date: Thu, 07 May 2015 10:10:47 +0200 [thread overview]
Message-ID: <1430986247.8171.37.camel@x220> (raw)
In-Reply-To: <1430904693-1404-4-git-send-email-jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, 2015-05-06 at 11:31 +0200, Jens Kuske wrote:
> --- a/drivers/pinctrl/sunxi/Kconfig
> +++ b/drivers/pinctrl/sunxi/Kconfig
> +config PINCTRL_SUN8I_H3
> + def_bool MACH_SUN8I
> + select PINCTRL_SUNXI_COMMON
> --- a/drivers/pinctrl/sunxi/Makefile
> +++ b/drivers/pinctrl/sunxi/Makefile
> +obj-$(CONFIG_PINCTRL_SUN8I_H3) += pinctrl-sun8i-h3.o
PINCTRL_SUN8I_H3 is a bool symbol, so pinctrl-sun8i-h3.o will never be
part of a module, right?
(Note that PINCTRL_SUN8I_H3 appears to be an alias for MACH_SUN8I. Ie,
these two symbols operate in lockstep.)
> --- /dev/null
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
> +#include <linux/module.h>
> +MODULE_DEVICE_TABLE(of, sun8i_h3_pinctrl_match);
> +MODULE_AUTHOR("Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>");
> +MODULE_DESCRIPTION("Allwinner H3 pinctrl driver");
> +MODULE_LICENSE("GPL");
This adds some module specific boilerplate. Was it perhaps your
intention to make PINCTRL_SUN8I_H3 a tristate symbol?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Jens Kuske <jenskuske@gmail.com>
Cc: "Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Mike Turquette" <mturquette@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Vinod Koul" <vinod.koul@intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support
Date: Thu, 07 May 2015 10:10:47 +0200 [thread overview]
Message-ID: <1430986247.8171.37.camel@x220> (raw)
In-Reply-To: <1430904693-1404-4-git-send-email-jenskuske@gmail.com>
On Wed, 2015-05-06 at 11:31 +0200, Jens Kuske wrote:
> --- a/drivers/pinctrl/sunxi/Kconfig
> +++ b/drivers/pinctrl/sunxi/Kconfig
> +config PINCTRL_SUN8I_H3
> + def_bool MACH_SUN8I
> + select PINCTRL_SUNXI_COMMON
> --- a/drivers/pinctrl/sunxi/Makefile
> +++ b/drivers/pinctrl/sunxi/Makefile
> +obj-$(CONFIG_PINCTRL_SUN8I_H3) += pinctrl-sun8i-h3.o
PINCTRL_SUN8I_H3 is a bool symbol, so pinctrl-sun8i-h3.o will never be
part of a module, right?
(Note that PINCTRL_SUN8I_H3 appears to be an alias for MACH_SUN8I. Ie,
these two symbols operate in lockstep.)
> --- /dev/null
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
> +#include <linux/module.h>
> +MODULE_DEVICE_TABLE(of, sun8i_h3_pinctrl_match);
> +MODULE_AUTHOR("Jens Kuske <jenskuske@gmail.com>");
> +MODULE_DESCRIPTION("Allwinner H3 pinctrl driver");
> +MODULE_LICENSE("GPL");
This adds some module specific boilerplate. Was it perhaps your
intention to make PINCTRL_SUN8I_H3 a tristate symbol?
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-05-07 8:10 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 9:31 [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` [PATCH 1/6] " Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 10:04 ` Maxime Ripard
2015-05-06 10:04 ` Maxime Ripard
2015-05-06 10:23 ` Jens Kuske
2015-05-06 10:23 ` Jens Kuske
2015-05-06 10:23 ` Jens Kuske
2015-05-06 12:22 ` Maxime Ripard
2015-05-06 12:22 ` Maxime Ripard
2015-05-06 12:22 ` Maxime Ripard
2015-05-06 9:31 ` [PATCH 2/6] clk: sunxi: Add H3 clocks support Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:47 ` Chen-Yu Tsai
2015-05-06 9:47 ` Chen-Yu Tsai
2015-05-06 9:47 ` Chen-Yu Tsai
2015-05-06 10:18 ` Jens Kuske
2015-05-06 10:18 ` Jens Kuske
2015-05-06 10:18 ` Jens Kuske
2015-05-09 11:29 ` Maxime Ripard
2015-05-09 11:29 ` Maxime Ripard
2015-05-09 11:29 ` Maxime Ripard
2015-05-09 11:27 ` Maxime Ripard
2015-05-09 11:27 ` Maxime Ripard
2015-05-09 11:27 ` Maxime Ripard
2015-05-10 10:54 ` Jens Kuske
2015-05-10 10:54 ` Jens Kuske
2015-05-10 10:54 ` Jens Kuske
2015-05-12 14:44 ` Maxime Ripard
2015-05-12 14:44 ` Maxime Ripard
2015-05-12 14:44 ` Maxime Ripard
2015-05-14 5:14 ` Chen-Yu Tsai
2015-05-14 5:14 ` Chen-Yu Tsai
2015-05-14 5:14 ` Chen-Yu Tsai
2015-05-15 12:49 ` Maxime Ripard
2015-05-15 12:49 ` Maxime Ripard
2015-05-15 12:49 ` Maxime Ripard
2015-05-06 9:31 ` [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 10:11 ` Maxime Ripard
2015-05-06 10:11 ` Maxime Ripard
2015-05-06 10:34 ` Jens Kuske
2015-05-06 10:34 ` Jens Kuske
2015-05-06 10:34 ` Jens Kuske
2015-05-06 12:23 ` Maxime Ripard
2015-05-06 12:23 ` Maxime Ripard
2015-05-06 12:23 ` Maxime Ripard
2015-05-07 8:10 ` Paul Bolle [this message]
2015-05-07 8:10 ` Paul Bolle
2015-05-07 8:10 ` Paul Bolle
2015-05-09 9:17 ` Jens Kuske
2015-05-09 9:17 ` Jens Kuske
2015-05-09 9:17 ` Jens Kuske
2015-05-09 12:19 ` Maxime Ripard
2015-05-09 12:19 ` Maxime Ripard
2015-05-09 12:19 ` Maxime Ripard
2015-05-06 9:31 ` [PATCH 4/6] dmaengine: sun6i: Add support for Allwinner H3 (sun8i) variant Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 10:13 ` Maxime Ripard
2015-05-06 10:13 ` Maxime Ripard
2015-05-06 10:13 ` Maxime Ripard
2015-05-08 3:44 ` Vinod Koul
2015-05-08 3:44 ` Vinod Koul
2015-05-08 3:44 ` Vinod Koul
2015-05-08 7:19 ` Maxime Ripard
2015-05-08 7:19 ` Maxime Ripard
2015-05-08 7:19 ` Maxime Ripard
2015-05-08 9:26 ` Vinod Koul
2015-05-08 9:26 ` Vinod Koul
2015-05-08 9:26 ` Vinod Koul
2015-05-06 9:31 ` [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 12:19 ` Maxime Ripard
2015-05-06 12:19 ` Maxime Ripard
2015-05-06 12:19 ` Maxime Ripard
2015-05-06 20:47 ` Jens Kuske
2015-05-06 20:47 ` Jens Kuske
2015-05-06 20:47 ` Jens Kuske
2015-05-09 11:44 ` Maxime Ripard
2015-05-09 11:44 ` Maxime Ripard
2015-05-09 11:44 ` Maxime Ripard
2015-05-11 8:11 ` Chen-Yu Tsai
2015-05-11 8:11 ` Chen-Yu Tsai
2015-05-11 8:11 ` Chen-Yu Tsai
2015-05-06 9:31 ` [PATCH 6/6] ARM: dts: sun8i: Add Orange Pi Plus support Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-06 9:31 ` Jens Kuske
2015-05-09 15:58 ` [linux-sunxi] [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support Hans de Goede
2015-05-09 15:58 ` Hans de Goede
2015-05-09 15:58 ` Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2015-10-21 16:30 [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support Jens Kuske
2015-10-21 16:30 ` Jens Kuske
2015-10-21 16:30 ` Jens Kuske
2015-10-22 8:16 ` Maxime Ripard
2015-10-22 8:16 ` Maxime Ripard
2015-10-22 8:21 ` josef.gajdusek at gmail.com
2015-10-22 8:21 ` josef.gajdusek
2015-10-22 8:21 ` josef.gajdusek
2015-10-22 8:30 ` Maxime Ripard
2015-10-22 8:30 ` Maxime Ripard
2015-10-22 8:30 ` Maxime Ripard
2015-10-23 8:21 ` Linus Walleij
2015-10-23 8:21 ` Linus Walleij
2015-10-23 8:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430986247.8171.37.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.