All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] clk: sunxi: Add H3 clocks support
Date: Sat, 9 May 2015 13:29:36 +0200	[thread overview]
Message-ID: <20150509112936.GU11057@lukather> (raw)
In-Reply-To: <5549EA63.5060602@gmail.com>

On Wed, May 06, 2015 at 12:18:11PM +0200, Jens Kuske wrote:
> >>  /**
> >>   * sunxi_divs_clk_setup() - Setup function for leaf divisors on clocks
> >>   *
> >> @@ -1252,6 +1288,7 @@ static const struct of_device_id clk_factors_match[] __initconst = {
> >>         {.compatible = "allwinner,sun5i-a13-ahb-clk", .data = &sun5i_a13_ahb_data,},
> >>         {.compatible = "allwinner,sun4i-a10-apb1-clk", .data = &sun4i_apb1_data,},
> >>         {.compatible = "allwinner,sun7i-a20-out-clk", .data = &sun7i_a20_out_data,},
> >> +       {.compatible = "allwinner,sun8i-h3-pll8-clk", .data = &sun8i_h3_pll8_data,},
> > 
> > Matching comment above, no need to add a new compatible for something that's
> > the same.
> 
> PLL8 doesn't have a x2 output according to User Manual, but I did it
> wrong anyway, see first comment.

Don't worry too much about that output.

It's not really an output, it's a pre-multiplier on a single
child. We're discussing with Chen-Yu about refactoring this anyway, so
it will probably go away in a near future.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150509/ef264412/attachment-0001.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>,
	"Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
	"Mike Turquette"
	<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Linus Walleij"
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Vinod Koul" <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH 2/6] clk: sunxi: Add H3 clocks support
Date: Sat, 9 May 2015 13:29:36 +0200	[thread overview]
Message-ID: <20150509112936.GU11057@lukather> (raw)
In-Reply-To: <5549EA63.5060602-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On Wed, May 06, 2015 at 12:18:11PM +0200, Jens Kuske wrote:
> >>  /**
> >>   * sunxi_divs_clk_setup() - Setup function for leaf divisors on clocks
> >>   *
> >> @@ -1252,6 +1288,7 @@ static const struct of_device_id clk_factors_match[] __initconst = {
> >>         {.compatible = "allwinner,sun5i-a13-ahb-clk", .data = &sun5i_a13_ahb_data,},
> >>         {.compatible = "allwinner,sun4i-a10-apb1-clk", .data = &sun4i_apb1_data,},
> >>         {.compatible = "allwinner,sun7i-a20-out-clk", .data = &sun7i_a20_out_data,},
> >> +       {.compatible = "allwinner,sun8i-h3-pll8-clk", .data = &sun8i_h3_pll8_data,},
> > 
> > Matching comment above, no need to add a new compatible for something that's
> > the same.
> 
> PLL8 doesn't have a x2 output according to User Manual, but I did it
> wrong anyway, see first comment.

Don't worry too much about that output.

It's not really an output, it's a pre-multiplier on a single
child. We're discussing with Chen-Yu about refactoring this anyway, so
it will probably go away in a near future.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jens Kuske <jenskuske@gmail.com>
Cc: "Chen-Yu Tsai" <wens@csie.org>,
	"Emilio López" <emilio@elopez.com.ar>,
	"Mike Turquette" <mturquette@linaro.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Vinod Koul" <vinod.koul@intel.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH 2/6] clk: sunxi: Add H3 clocks support
Date: Sat, 9 May 2015 13:29:36 +0200	[thread overview]
Message-ID: <20150509112936.GU11057@lukather> (raw)
In-Reply-To: <5549EA63.5060602@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

On Wed, May 06, 2015 at 12:18:11PM +0200, Jens Kuske wrote:
> >>  /**
> >>   * sunxi_divs_clk_setup() - Setup function for leaf divisors on clocks
> >>   *
> >> @@ -1252,6 +1288,7 @@ static const struct of_device_id clk_factors_match[] __initconst = {
> >>         {.compatible = "allwinner,sun5i-a13-ahb-clk", .data = &sun5i_a13_ahb_data,},
> >>         {.compatible = "allwinner,sun4i-a10-apb1-clk", .data = &sun4i_apb1_data,},
> >>         {.compatible = "allwinner,sun7i-a20-out-clk", .data = &sun7i_a20_out_data,},
> >> +       {.compatible = "allwinner,sun8i-h3-pll8-clk", .data = &sun8i_h3_pll8_data,},
> > 
> > Matching comment above, no need to add a new compatible for something that's
> > the same.
> 
> PLL8 doesn't have a x2 output according to User Manual, but I did it
> wrong anyway, see first comment.

Don't worry too much about that output.

It's not really an output, it's a pre-multiplier on a single
child. We're discussing with Chen-Yu about refactoring this anyway, so
it will probably go away in a near future.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-05-09 11:29 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  9:31 [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support Jens Kuske
2015-05-06  9:31 ` Jens Kuske
2015-05-06  9:31 ` Jens Kuske
2015-05-06  9:31 ` [PATCH 1/6] " Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06 10:04   ` Maxime Ripard
2015-05-06 10:04     ` Maxime Ripard
2015-05-06 10:23     ` Jens Kuske
2015-05-06 10:23       ` Jens Kuske
2015-05-06 10:23       ` Jens Kuske
2015-05-06 12:22       ` Maxime Ripard
2015-05-06 12:22         ` Maxime Ripard
2015-05-06 12:22         ` Maxime Ripard
2015-05-06  9:31 ` [PATCH 2/6] clk: sunxi: Add H3 clocks support Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06  9:47   ` Chen-Yu Tsai
2015-05-06  9:47     ` Chen-Yu Tsai
2015-05-06  9:47     ` Chen-Yu Tsai
2015-05-06 10:18     ` Jens Kuske
2015-05-06 10:18       ` Jens Kuske
2015-05-06 10:18       ` Jens Kuske
2015-05-09 11:29       ` Maxime Ripard [this message]
2015-05-09 11:29         ` Maxime Ripard
2015-05-09 11:29         ` Maxime Ripard
2015-05-09 11:27   ` Maxime Ripard
2015-05-09 11:27     ` Maxime Ripard
2015-05-09 11:27     ` Maxime Ripard
2015-05-10 10:54     ` Jens Kuske
2015-05-10 10:54       ` Jens Kuske
2015-05-10 10:54       ` Jens Kuske
2015-05-12 14:44       ` Maxime Ripard
2015-05-12 14:44         ` Maxime Ripard
2015-05-12 14:44         ` Maxime Ripard
2015-05-14  5:14         ` Chen-Yu Tsai
2015-05-14  5:14           ` Chen-Yu Tsai
2015-05-14  5:14           ` Chen-Yu Tsai
2015-05-15 12:49           ` Maxime Ripard
2015-05-15 12:49             ` Maxime Ripard
2015-05-15 12:49             ` Maxime Ripard
2015-05-06  9:31 ` [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06 10:11   ` Maxime Ripard
2015-05-06 10:11     ` Maxime Ripard
2015-05-06 10:34     ` Jens Kuske
2015-05-06 10:34       ` Jens Kuske
2015-05-06 10:34       ` Jens Kuske
2015-05-06 12:23       ` Maxime Ripard
2015-05-06 12:23         ` Maxime Ripard
2015-05-06 12:23         ` Maxime Ripard
2015-05-07  8:10   ` Paul Bolle
2015-05-07  8:10     ` Paul Bolle
2015-05-07  8:10     ` Paul Bolle
2015-05-09  9:17     ` Jens Kuske
2015-05-09  9:17       ` Jens Kuske
2015-05-09  9:17       ` Jens Kuske
2015-05-09 12:19       ` Maxime Ripard
2015-05-09 12:19         ` Maxime Ripard
2015-05-09 12:19         ` Maxime Ripard
2015-05-06  9:31 ` [PATCH 4/6] dmaengine: sun6i: Add support for Allwinner H3 (sun8i) variant Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06 10:13   ` Maxime Ripard
2015-05-06 10:13     ` Maxime Ripard
2015-05-06 10:13     ` Maxime Ripard
2015-05-08  3:44     ` Vinod Koul
2015-05-08  3:44       ` Vinod Koul
2015-05-08  3:44       ` Vinod Koul
2015-05-08  7:19       ` Maxime Ripard
2015-05-08  7:19         ` Maxime Ripard
2015-05-08  7:19         ` Maxime Ripard
2015-05-08  9:26   ` Vinod Koul
2015-05-08  9:26     ` Vinod Koul
2015-05-08  9:26     ` Vinod Koul
2015-05-06  9:31 ` [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06 12:19   ` Maxime Ripard
2015-05-06 12:19     ` Maxime Ripard
2015-05-06 12:19     ` Maxime Ripard
2015-05-06 20:47     ` Jens Kuske
2015-05-06 20:47       ` Jens Kuske
2015-05-06 20:47       ` Jens Kuske
2015-05-09 11:44       ` Maxime Ripard
2015-05-09 11:44         ` Maxime Ripard
2015-05-09 11:44         ` Maxime Ripard
2015-05-11  8:11         ` Chen-Yu Tsai
2015-05-11  8:11           ` Chen-Yu Tsai
2015-05-11  8:11           ` Chen-Yu Tsai
2015-05-06  9:31 ` [PATCH 6/6] ARM: dts: sun8i: Add Orange Pi Plus support Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-06  9:31   ` Jens Kuske
2015-05-09 15:58 ` [linux-sunxi] [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support Hans de Goede
2015-05-09 15:58   ` Hans de Goede
2015-05-09 15:58   ` Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2015-10-21 16:13 Jens Kuske
2015-10-21 16:13 ` [PATCH 2/6] clk: sunxi: Add H3 clocks support Jens Kuske
2015-10-21 16:13   ` Jens Kuske
2015-10-21 16:13   ` Jens Kuske
     [not found]   ` <1445444007-4260-3-git-send-email-jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-22  0:15     ` Julian Calaby
     [not found]       ` <CAGRGNgWyNEOMVxeDFTAp_wJoaXL471spFjBTn+2s7YuKeJf71g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-22  7:32         ` Jens Kuske

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150509112936.GU11057@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.