From: Joe Perches <joe@perches.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: add phy.c
Date: Fri, 15 May 2015 22:36:20 -0700 [thread overview]
Message-ID: <1431754580.15709.55.camel@perches.com> (raw)
In-Reply-To: <5556D546.6010703@rempel-privat.de>
On Sat, 2015-05-16 at 07:27 +0200, Oleksij Rempel wrote:
> Am 15.05.2015 um 20:35 schrieb Joe Perches:
> > On Fri, 2015-05-15 at 14:35 +0200, Oleksij Rempel wrote:
> >> ... and move dup code from ar5008_phy.c and ar9002_phy.c to phy.c
> > []
> >> diff --git a/drivers/net/wireless/ath/ath9k/phy.c b/drivers/net/wireless/ath/ath9k/phy.c
> >
> >> +void phy_hw_spur_mitigate(struct ath_hw *ah,
> >> + struct ath9k_channel *chan, int bin)
> >> +{
[]
> >> + static int inc[4] = { 0, 100, 0, 0 };
> >
> > static const
> This is cleanup patch, no fixes optimisations
> or regressions should be introduced.
Hello Oleksij.
One of the old compilation units (ar9002_phy.c) had const on
all those arrays, the other did not.
const should be used here.
> If you see some problems in this
> code, you are welcome to provide a patch on top of this one :)
I think you should take comments on the patches you submit.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: ath9k-devel@qca.qualcomm.com, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: add phy.c
Date: Fri, 15 May 2015 22:36:20 -0700 [thread overview]
Message-ID: <1431754580.15709.55.camel@perches.com> (raw)
In-Reply-To: <5556D546.6010703@rempel-privat.de>
On Sat, 2015-05-16 at 07:27 +0200, Oleksij Rempel wrote:
> Am 15.05.2015 um 20:35 schrieb Joe Perches:
> > On Fri, 2015-05-15 at 14:35 +0200, Oleksij Rempel wrote:
> >> ... and move dup code from ar5008_phy.c and ar9002_phy.c to phy.c
> > []
> >> diff --git a/drivers/net/wireless/ath/ath9k/phy.c b/drivers/net/wireless/ath/ath9k/phy.c
> >
> >> +void phy_hw_spur_mitigate(struct ath_hw *ah,
> >> + struct ath9k_channel *chan, int bin)
> >> +{
[]
> >> + static int inc[4] = { 0, 100, 0, 0 };
> >
> > static const
> This is cleanup patch, no fixes optimisations
> or regressions should be introduced.
Hello Oleksij.
One of the old compilation units (ar9002_phy.c) had const on
all those arrays, the other did not.
const should be used here.
> If you see some problems in this
> code, you are welcome to provide a patch on top of this one :)
I think you should take comments on the patches you submit.
next prev parent reply other threads:[~2015-05-16 5:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 12:35 [ath9k-devel] [PATCH] ath9k: add phy.c Oleksij Rempel
2015-05-15 12:35 ` Oleksij Rempel
2015-05-15 14:38 ` [ath9k-devel] " Julian Calaby
2015-05-15 14:38 ` Julian Calaby
2015-05-15 14:44 ` [ath9k-devel] " Sedat Dilek
2015-05-15 14:44 ` Sedat Dilek
2015-05-15 18:35 ` [ath9k-devel] " Joe Perches
2015-05-15 18:35 ` Joe Perches
2015-05-16 5:27 ` [ath9k-devel] " Oleksij Rempel
2015-05-16 5:27 ` Oleksij Rempel
2015-05-16 5:36 ` Joe Perches [this message]
2015-05-16 5:36 ` Joe Perches
2015-05-16 5:43 ` [ath9k-devel] " Oleksij Rempel
2015-05-16 5:43 ` Oleksij Rempel
2015-05-15 19:34 ` [ath9k-devel] " Felix Fietkau
2015-05-15 19:34 ` Felix Fietkau
2015-05-16 5:24 ` [ath9k-devel] " Oleksij Rempel
2015-05-16 5:24 ` Oleksij Rempel
2015-05-16 5:45 ` [ath9k-devel] " Felix Fietkau
2015-05-16 5:45 ` Felix Fietkau
2015-05-17 19:49 ` [PATCH] ath9k: split ar5008_hw_spur_mitigate and reuse common code in ar9002_hw_spur_mitigate Oleksij Rempel
2015-05-26 11:03 ` ath9k: split ar5008_hw_spur_mitigate and reuse common code inar9002_hw_spur_mitigate Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431754580.15709.55.camel@perches.com \
--to=joe@perches.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.