From: Oleksij Rempel <linux@rempel-privat.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: add phy.c
Date: Sat, 16 May 2015 07:24:27 +0200 [thread overview]
Message-ID: <5556D48B.3090708@rempel-privat.de> (raw)
In-Reply-To: <55564A50.2050004@openwrt.org>
Am 15.05.2015 um 21:34 schrieb Felix Fietkau:
> On 2015-05-15 14:35, Oleksij Rempel wrote:
>> ... and move dup code from ar5008_phy.c and ar9002_phy.c to phy.c
>>
>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> We already have base functionality for AR5008-AR9002 provided in some
> ar5008_phy.c, and ar5008_hw_attach_phy_ops is called for those chipsets
> as well. Please keep the de-duplicated code there instead of adding a
> new phy.c, because AR9003+ uses a completely different codepath.
>
> - Felix
>
ok, thanks.
Currently i celled this function phy_hw_spur_mitigate(), is it ok or
there is some better name for this code?
--
Regards,
Oleksij
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <linux@rempel-privat.de>
To: Felix Fietkau <nbd@openwrt.org>,
ath9k-devel@qca.qualcomm.com, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: add phy.c
Date: Sat, 16 May 2015 07:24:27 +0200 [thread overview]
Message-ID: <5556D48B.3090708@rempel-privat.de> (raw)
In-Reply-To: <55564A50.2050004@openwrt.org>
Am 15.05.2015 um 21:34 schrieb Felix Fietkau:
> On 2015-05-15 14:35, Oleksij Rempel wrote:
>> ... and move dup code from ar5008_phy.c and ar9002_phy.c to phy.c
>>
>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> We already have base functionality for AR5008-AR9002 provided in some
> ar5008_phy.c, and ar5008_hw_attach_phy_ops is called for those chipsets
> as well. Please keep the de-duplicated code there instead of adding a
> new phy.c, because AR9003+ uses a completely different codepath.
>
> - Felix
>
ok, thanks.
Currently i celled this function phy_hw_spur_mitigate(), is it ok or
there is some better name for this code?
--
Regards,
Oleksij
next prev parent reply other threads:[~2015-05-16 5:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 12:35 [ath9k-devel] [PATCH] ath9k: add phy.c Oleksij Rempel
2015-05-15 12:35 ` Oleksij Rempel
2015-05-15 14:38 ` [ath9k-devel] " Julian Calaby
2015-05-15 14:38 ` Julian Calaby
2015-05-15 14:44 ` [ath9k-devel] " Sedat Dilek
2015-05-15 14:44 ` Sedat Dilek
2015-05-15 18:35 ` [ath9k-devel] " Joe Perches
2015-05-15 18:35 ` Joe Perches
2015-05-16 5:27 ` [ath9k-devel] " Oleksij Rempel
2015-05-16 5:27 ` Oleksij Rempel
2015-05-16 5:36 ` [ath9k-devel] " Joe Perches
2015-05-16 5:36 ` Joe Perches
2015-05-16 5:43 ` [ath9k-devel] " Oleksij Rempel
2015-05-16 5:43 ` Oleksij Rempel
2015-05-15 19:34 ` [ath9k-devel] " Felix Fietkau
2015-05-15 19:34 ` Felix Fietkau
2015-05-16 5:24 ` Oleksij Rempel [this message]
2015-05-16 5:24 ` Oleksij Rempel
2015-05-16 5:45 ` [ath9k-devel] " Felix Fietkau
2015-05-16 5:45 ` Felix Fietkau
2015-05-17 19:49 ` [PATCH] ath9k: split ar5008_hw_spur_mitigate and reuse common code in ar9002_hw_spur_mitigate Oleksij Rempel
2015-05-26 11:03 ` ath9k: split ar5008_hw_spur_mitigate and reuse common code inar9002_hw_spur_mitigate Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5556D48B.3090708@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.