* [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
@ 2015-05-18 14:44 DHANAPAL, GNANACHANDRAN (G.)
2015-05-18 16:05 ` Sudip Mukherjee
2015-05-18 17:49 ` Julia Lawall
0 siblings, 2 replies; 6+ messages in thread
From: DHANAPAL, GNANACHANDRAN (G.) @ 2015-05-18 14:44 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: lambert.quentin@gmail.com, mdcasey@chabloom.com,
julia.lawall@lip6.fr, kolbeinnkarls@gmail.com,
himangi774@gmail.com, joe@perches.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Babu, Viswanathan (V.)
setup_timer is used for timer parameter setup rather than direct
assignment
Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
---
drivers/staging/rtl8192e/rtllib_module.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c
index 32cc8df..7ad1541 100644
--- a/drivers/staging/rtl8192e/rtllib_module.c
+++ b/drivers/staging/rtl8192e/rtllib_module.c
@@ -59,9 +59,8 @@ EXPORT_SYMBOL(rt_global_debug_component);
void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
{
- ptimer->function = fun;
- ptimer->data = data;
init_timer(ptimer);
+ setup_timer(ptimer, fun, data);
}
static inline int rtllib_networks_allocate(struct rtllib_device *ieee)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
2015-05-18 14:44 [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment DHANAPAL, GNANACHANDRAN (G.)
@ 2015-05-18 16:05 ` Sudip Mukherjee
2015-05-18 16:26 ` Joe Perches
2015-05-18 17:49 ` Julia Lawall
1 sibling, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-05-18 16:05 UTC (permalink / raw)
To: DHANAPAL, GNANACHANDRAN (G.)
Cc: gregkh@linuxfoundation.org, lambert.quentin@gmail.com,
mdcasey@chabloom.com, julia.lawall@lip6.fr,
kolbeinnkarls@gmail.com, himangi774@gmail.com, joe@perches.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Babu, Viswanathan (V.)
On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> setup_timer is used for timer parameter setup rather than direct
> assignment
>
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
your From: name and Signed-off-by: names are not matching. They should
be same.
> ---
<snip>
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -59,9 +59,8 @@ EXPORT_SYMBOL(rt_global_debug_component);
>
> void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
> {
> - ptimer->function = fun;
> - ptimer->data = data;
> init_timer(ptimer);
> + setup_timer(ptimer, fun, data);
setup_timer is calling __setup_timer which is again calling __init_timer
here we already have an init_timer which is also calling __init_timer.
so now __init_timer gets executed two times for one timer.
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
2015-05-18 16:05 ` Sudip Mukherjee
@ 2015-05-18 16:26 ` Joe Perches
2015-05-18 16:42 ` Sudip Mukherjee
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2015-05-18 16:26 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: DHANAPAL, GNANACHANDRAN (G.), gregkh@linuxfoundation.org,
lambert.quentin@gmail.com, mdcasey@chabloom.com,
julia.lawall@lip6.fr, kolbeinnkarls@gmail.com,
himangi774@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Babu, Viswanathan (V.)
On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > setup_timer is used for timer parameter setup rather than direct
> > assignment
> >
> > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
>
> your From: name and Signed-off-by: names are not matching. They should
> be same.
If there's a specific "From: " in the _body_ of the email,
that's true, but the sender email "From: " header and the
Signed-off-by: line do not have to match.
A "From: " line in the email body should only be used when
the patch is from a different sender than the sign-off.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
2015-05-18 16:26 ` Joe Perches
@ 2015-05-18 16:42 ` Sudip Mukherjee
2015-05-31 0:26 ` gregkh
0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-05-18 16:42 UTC (permalink / raw)
To: Joe Perches
Cc: DHANAPAL, GNANACHANDRAN (G.), gregkh@linuxfoundation.org,
lambert.quentin@gmail.com, mdcasey@chabloom.com,
julia.lawall@lip6.fr, kolbeinnkarls@gmail.com,
himangi774@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Babu, Viswanathan (V.)
On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > setup_timer is used for timer parameter setup rather than direct
> > > assignment
> > >
> > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> >
> > your From: name and Signed-off-by: names are not matching. They should
> > be same.
>
> If there's a specific "From: " in the _body_ of the email,
> that's true, but the sender email "From: " header and the
> Signed-off-by: line do not have to match.
But Greg usually rejects these patches where the sender "From:" header
and Signed-off-by: doesnot match. Just for example:
https://lkml.org/lkml/2014/11/25/924
regards
sudip
>
> A "From: " line in the email body should only be used when
> the patch is from a different sender than the sign-off.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
2015-05-18 16:42 ` Sudip Mukherjee
@ 2015-05-31 0:26 ` gregkh
0 siblings, 0 replies; 6+ messages in thread
From: gregkh @ 2015-05-31 0:26 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Joe Perches, devel@driverdev.osuosl.org, mdcasey@chabloom.com,
Babu, Viswanathan (V.), lambert.quentin@gmail.com,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
himangi774@gmail.com, DHANAPAL, GNANACHANDRAN (G.),
kolbeinnkarls@gmail.com
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > > setup_timer is used for timer parameter setup rather than direct
> > > > assignment
> > > >
> > > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> > >
> > > your From: name and Signed-off-by: names are not matching. They should
> > > be same.
> >
> > If there's a specific "From: " in the _body_ of the email,
> > that's true, but the sender email "From: " header and the
> > Signed-off-by: line do not have to match.
> But Greg usually rejects these patches where the sender "From:" header
> and Signed-off-by: doesnot match. Just for example:
>
> https://lkml.org/lkml/2014/11/25/924
Yes, I can't take it where it doesn't match up.
Sometimes I miss it, but when it's pointed out, I will not accept it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
2015-05-18 14:44 [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment DHANAPAL, GNANACHANDRAN (G.)
2015-05-18 16:05 ` Sudip Mukherjee
@ 2015-05-18 17:49 ` Julia Lawall
1 sibling, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-05-18 17:49 UTC (permalink / raw)
To: DHANAPAL, GNANACHANDRAN (G.)
Cc: gregkh@linuxfoundation.org, lambert.quentin@gmail.com,
mdcasey@chabloom.com, julia.lawall@lip6.fr,
kolbeinnkarls@gmail.com, himangi774@gmail.com, joe@perches.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Babu, Viswanathan (V.)
> void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
> {
> - ptimer->function = fun;
> - ptimer->data = data;
> init_timer(ptimer);
> + setup_timer(ptimer, fun, data);
> }
setup_timer also subsumes init_timer. Check the definition. Probably you
can delete this function completely.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-31 0:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 14:44 [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment DHANAPAL, GNANACHANDRAN (G.)
2015-05-18 16:05 ` Sudip Mukherjee
2015-05-18 16:26 ` Joe Perches
2015-05-18 16:42 ` Sudip Mukherjee
2015-05-31 0:26 ` gregkh
2015-05-18 17:49 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.