From: Alex Williamson <alex.williamson@redhat.com>
To: Feng Wu <feng.wu@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, joro@8bytes.org, eric.auger@linaro.org
Subject: Re: [v5 09/19] vfio: Register/unregister irq_bypass_producer
Date: Mon, 13 Jul 2015 12:57:29 -0600 [thread overview]
Message-ID: <1436813849.1391.380.camel@redhat.com> (raw)
In-Reply-To: <1436780855-3617-10-git-send-email-feng.wu@intel.com>
On Mon, 2015-07-13 at 17:47 +0800, Feng Wu wrote:
> This patch adds the registration/unregistration of an
> irq_bypass_producer for MSI/MSIx on vfio pci devices.
>
> Signed-off-by: Feng Wu <feng.wu@intel.com>
> ---
> drivers/vfio/pci/vfio_pci_intrs.c | 19 +++++++++++++++++++
> drivers/vfio/pci/vfio_pci_private.h | 2 ++
> 2 files changed, 21 insertions(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index 1f577b4..4795606 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> @@ -305,6 +305,16 @@ static int vfio_msi_enable(struct vfio_pci_device *vdev, int nvec, bool msix)
> return 0;
> }
>
> +void vfio_pci_add_consumer(struct irq_bypass_producer *prod,
> + struct irq_bypass_consumer *cons)
> +{
> +}
> +
> +void vfio_pci_del_consumer(struct irq_bypass_producer *prod,
> + struct irq_bypass_consumer *cons)
> +{
> +}
> +
Yes, as Eric says, these should be static
> static int vfio_msi_set_vector_signal(struct vfio_pci_device *vdev,
> int vector, int fd, bool msix)
> {
> @@ -319,6 +329,7 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_device *vdev,
>
> if (vdev->ctx[vector].trigger) {
> free_irq(irq, vdev->ctx[vector].trigger);
> + irq_bypass_unregister_producer(&vdev->ctx[vector].producer);
> kfree(vdev->ctx[vector].name);
> eventfd_ctx_put(vdev->ctx[vector].trigger);
> vdev->ctx[vector].trigger = NULL;
> @@ -360,6 +371,14 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_device *vdev,
> return ret;
> }
>
> + INIT_LIST_HEAD(&vdev->ctx[vector].producer.node);
nit, INIT_LIST_HEAD isn't really needed, irq-bypass-manager shouldn't
trust incoming data here anyway.
> + vdev->ctx[vector].producer.token = trigger;
> + vdev->ctx[vector].producer.irq = irq;
> + vdev->ctx[vector].producer.add_consumer = vfio_pci_add_consumer;
> + vdev->ctx[vector].producer.del_consumer = vfio_pci_del_consumer;
> + ret = irq_bypass_register_producer(&vdev->ctx[vector].producer);
> + WARN_ON(ret);
This is only an acceleration path, so a dev_dbg() or dev_info() is
probably more appropriate. Same for kvm side.
> +
> vdev->ctx[vector].trigger = trigger;
>
> return 0;
> diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h
> index ae0e1b4..0e7394f 100644
> --- a/drivers/vfio/pci/vfio_pci_private.h
> +++ b/drivers/vfio/pci/vfio_pci_private.h
> @@ -13,6 +13,7 @@
>
> #include <linux/mutex.h>
> #include <linux/pci.h>
> +#include <linux/irqbypass.h>
>
> #ifndef VFIO_PCI_PRIVATE_H
> #define VFIO_PCI_PRIVATE_H
> @@ -29,6 +30,7 @@ struct vfio_pci_irq_ctx {
> struct virqfd *mask;
> char *name;
> bool masked;
> + struct irq_bypass_producer producer;
> };
>
> struct vfio_pci_device {
next prev parent reply other threads:[~2015-07-13 18:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 9:47 [v5 00/19] Add VT-d Posted-Interrupts support Feng Wu
2015-07-13 9:47 ` [v5 01/19] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-07-13 9:47 ` [v5 02/19] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-07-13 9:47 ` [v5 03/19] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
2015-07-13 9:47 ` [v5 04/19] KVM: Get Posted-Interrupts descriptor address from struct kvm_vcpu Feng Wu
2015-07-13 9:47 ` [v5 05/19] KVM: Add interfaces to control PI outside vmx Feng Wu
2015-07-13 9:47 ` [v5 06/19] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2015-07-13 9:47 ` [v5 07/19] KVM: make kvm_set_msi_irq() public Feng Wu
2015-07-13 9:47 ` [v5 08/19] vfio: Select IRQ_BYPASS_MANAGER for vfio PCI devices Feng Wu
2015-07-13 9:47 ` [v5 09/19] vfio: Register/unregister irq_bypass_producer Feng Wu
2015-07-13 12:55 ` Eric Auger
2015-07-13 18:57 ` Alex Williamson [this message]
2015-07-13 9:47 ` [v5 10/19] KVM, x86: Select IRQ_BYPASS_MANAGER for KVM_INTEL Feng Wu
2015-07-13 9:47 ` [v5 11/19] KVM: create kvm_irqfd.h Feng Wu
2015-07-13 9:47 ` [v5 12/19] KVM: eventfd: add irq bypass information in irqfd Feng Wu
2015-07-13 9:47 ` [v5 13/19] KVM: x86: Update IRTE for posted-interrupts Feng Wu
2015-07-13 9:47 ` [v5 14/19] KVM: x86: Add arch specific routines for irqbypass manager Feng Wu
2015-07-13 13:17 ` Eric Auger
2015-07-13 9:47 ` [v5 15/19] KVM: eventfd: add irq bypass consumer management Feng Wu
2015-07-13 13:16 ` Eric Auger
2015-07-13 13:47 ` Paolo Bonzini
2015-07-28 5:06 ` Wu, Feng
2015-07-13 9:47 ` [v5 16/19] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu
2015-07-13 13:09 ` Eric Auger
2015-07-13 9:47 ` [v5 17/19] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
2015-07-13 9:47 ` [v5 18/19] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
2015-07-13 9:47 ` [v5 19/19] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu
2015-07-13 13:19 ` [v5 00/19] Add VT-d Posted-Interrupts support Eric Auger
2015-07-14 1:08 ` Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436813849.1391.380.camel@redhat.com \
--to=alex.williamson@redhat.com \
--cc=eric.auger@linaro.org \
--cc=feng.wu@intel.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.