From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Auger <eric.auger@linaro.org>, Feng Wu <feng.wu@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: alex.williamson@redhat.com, joro@8bytes.org
Subject: Re: [v5 15/19] KVM: eventfd: add irq bypass consumer management
Date: Mon, 13 Jul 2015 15:47:23 +0200 [thread overview]
Message-ID: <55A3C16B.4040502@redhat.com> (raw)
In-Reply-To: <55A3BA2D.9070707@linaro.org>
13/07/2015 15:16, Eric Auger wrote:
>> >
>> > + irqfd->consumer.token = (void *)irqfd->eventfd;
>> > + kvm_arch_irq_consumer_init(&irqfd->consumer);
> what if the architecture does not implement kvm_arch_irq_consumer_init?
>
> Also you are using here this single function kvm_arch_irq_consumer_init
> to do some irq bypass manager settings + attaching your
> irqfd->arch_update cb which does not really relate to IRQ bypass
> manager. I think I preferred the approach where start/top/add/del were
> exposed separately ([RFC v2 5/6] KVM: introduce kvm_arch functions for
> IRQ bypass).
>
> Why not adding another kvm_arch_irq_routing_update then, not necessarily
> linked to irq bypass manager.
Yes, I also preferred the dummy kvm_arch_* functions to this approach
with an init function. You'd have to add dummy init functions anyway
for non-ARM, non-x86 architectures.
Paolo
next prev parent reply other threads:[~2015-07-13 13:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 9:47 [v5 00/19] Add VT-d Posted-Interrupts support Feng Wu
2015-07-13 9:47 ` [v5 01/19] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-07-13 9:47 ` [v5 02/19] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-07-13 9:47 ` [v5 03/19] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
2015-07-13 9:47 ` [v5 04/19] KVM: Get Posted-Interrupts descriptor address from struct kvm_vcpu Feng Wu
2015-07-13 9:47 ` [v5 05/19] KVM: Add interfaces to control PI outside vmx Feng Wu
2015-07-13 9:47 ` [v5 06/19] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2015-07-13 9:47 ` [v5 07/19] KVM: make kvm_set_msi_irq() public Feng Wu
2015-07-13 9:47 ` [v5 08/19] vfio: Select IRQ_BYPASS_MANAGER for vfio PCI devices Feng Wu
2015-07-13 9:47 ` [v5 09/19] vfio: Register/unregister irq_bypass_producer Feng Wu
2015-07-13 12:55 ` Eric Auger
2015-07-13 18:57 ` Alex Williamson
2015-07-13 9:47 ` [v5 10/19] KVM, x86: Select IRQ_BYPASS_MANAGER for KVM_INTEL Feng Wu
2015-07-13 9:47 ` [v5 11/19] KVM: create kvm_irqfd.h Feng Wu
2015-07-13 9:47 ` [v5 12/19] KVM: eventfd: add irq bypass information in irqfd Feng Wu
2015-07-13 9:47 ` [v5 13/19] KVM: x86: Update IRTE for posted-interrupts Feng Wu
2015-07-13 9:47 ` [v5 14/19] KVM: x86: Add arch specific routines for irqbypass manager Feng Wu
2015-07-13 13:17 ` Eric Auger
2015-07-13 9:47 ` [v5 15/19] KVM: eventfd: add irq bypass consumer management Feng Wu
2015-07-13 13:16 ` Eric Auger
2015-07-13 13:47 ` Paolo Bonzini [this message]
2015-07-28 5:06 ` Wu, Feng
2015-07-13 9:47 ` [v5 16/19] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu
2015-07-13 13:09 ` Eric Auger
2015-07-13 9:47 ` [v5 17/19] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
2015-07-13 9:47 ` [v5 18/19] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
2015-07-13 9:47 ` [v5 19/19] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu
2015-07-13 13:19 ` [v5 00/19] Add VT-d Posted-Interrupts support Eric Auger
2015-07-14 1:08 ` Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3C16B.4040502@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@linaro.org \
--cc=feng.wu@intel.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.