* [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined
@ 2015-07-22 14:38 Jan Beulich
2015-07-23 8:10 ` Ian Campbell
2015-07-23 11:51 ` Andrew Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2015-07-22 14:38 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Keir Fraser
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
This being an in-guest component, it shouldn't get to see (and even
less so use) tools-only public interfaces.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -31,6 +31,9 @@ SMBIOS_REL_DATE ?= $(shell date +%m/%d/%
CFLAGS += $(CFLAGS_xeninclude)
+# We mustn't use tools-only public interfaces.
+CFLAGS += -U__XEN_TOOLS__ -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
+
OBJS = hvmloader.o mp_tables.o util.o smbios.o
OBJS += smp.o cacheattr.o xenbus.o vnuma.o
OBJS += e820.o pci.o pir.o ctype.o
[-- Attachment #2: hvmloader-is-not-tools.patch --]
[-- Type: text/plain, Size: 673 bytes --]
hvmloader: don't build with __XEN_TOOLS__ defined
This being an in-guest component, it shouldn't get to see (and even
less so use) tools-only public interfaces.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -31,6 +31,9 @@ SMBIOS_REL_DATE ?= $(shell date +%m/%d/%
CFLAGS += $(CFLAGS_xeninclude)
+# We mustn't use tools-only public interfaces.
+CFLAGS += -U__XEN_TOOLS__ -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
+
OBJS = hvmloader.o mp_tables.o util.o smbios.o
OBJS += smp.o cacheattr.o xenbus.o vnuma.o
OBJS += e820.o pci.o pir.o ctype.o
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined
2015-07-22 14:38 [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined Jan Beulich
@ 2015-07-23 8:10 ` Ian Campbell
2015-07-23 11:51 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-07-23 8:10 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Andrew Cooper, Keir Fraser
On Wed, 2015-07-22 at 08:38 -0600, Jan Beulich wrote:
> This being an in-guest component, it shouldn't get to see (and even
> less so use) tools-only public interfaces.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
FWIW: Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> --- a/tools/firmware/hvmloader/Makefile
> +++ b/tools/firmware/hvmloader/Makefile
> @@ -31,6 +31,9 @@ SMBIOS_REL_DATE ?= $(shell date +%m/%d/%
>
> CFLAGS += $(CFLAGS_xeninclude)
>
> +# We mustn't use tools-only public interfaces.
> +CFLAGS += -U__XEN_TOOLS__
> -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
> +
> OBJS = hvmloader.o mp_tables.o util.o smbios.o
> OBJS += smp.o cacheattr.o xenbus.o vnuma.o
> OBJS += e820.o pci.o pir.o ctype.o
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined
2015-07-22 14:38 [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined Jan Beulich
2015-07-23 8:10 ` Ian Campbell
@ 2015-07-23 11:51 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2015-07-23 11:51 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Keir Fraser
On 22/07/15 15:38, Jan Beulich wrote:
> This being an in-guest component, it shouldn't get to see (and even
> less so use) tools-only public interfaces.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/tools/firmware/hvmloader/Makefile
> +++ b/tools/firmware/hvmloader/Makefile
> @@ -31,6 +31,9 @@ SMBIOS_REL_DATE ?= $(shell date +%m/%d/%
>
> CFLAGS += $(CFLAGS_xeninclude)
>
> +# We mustn't use tools-only public interfaces.
> +CFLAGS += -U__XEN_TOOLS__ -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
> +
> OBJS = hvmloader.o mp_tables.o util.o smbios.o
> OBJS += smp.o cacheattr.o xenbus.o vnuma.o
> OBJS += e820.o pci.o pir.o ctype.o
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-23 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 14:38 [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined Jan Beulich
2015-07-23 8:10 ` Ian Campbell
2015-07-23 11:51 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.