All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "xerofoify@gmail.com" <xerofoify@gmail.com>,
	"Berg, Johannes" <johannes.berg@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Spinadel, David" <david.spinadel@intel.com>,
	"Dreyfuss, Haim" <haim.dreyfuss@intel.com>,
	"Bondar, Alexander" <alexander.bondar@intel.com>,
	"ilw@linux.intel.com" <ilw@linux.intel.com>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"Stern, Avraham" <avraham.stern@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans
Date: Thu, 8 Oct 2015 08:30:22 +0000	[thread overview]
Message-ID: <1444293021.2899.46.camel@intel.com> (raw)
In-Reply-To: <1442967859-16347-1-git-send-email-xerofoify@gmail.com>

T24gVHVlLCAyMDE1LTA5LTIyIGF0IDIwOjI0IC0wNDAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6
DQo+IFRoaXMgZml4ZXMgaW5jb3JyZWN0IGZhbGx0aHJvdWdoIGluIHRoZSBzd2l0Y2ggc3RhdG1l
bnQgY2hlY2tpbmcNCj4gdGhlIHNjYW4gdHlwZSBwYXNzZWQgYnkgdGhlIGNhbGxlciB0byBpd2xf
bXZtX2NoZWNrX3J1bm5pbmdfc2NhbnMNCj4gZm9yIHRoZSBzd2l0Y2ggY2FzZSBJV0xfTVZNX1ND
QU5fU0NIRUQgdG8gcmV0dXJuIGRpcmVjdGx5IGFmdGVyDQo+IHRoZSBjYWxsIHRvIGl3bF9tdm1f
c2Nhbl9zdG9wIGluIG9yZGVyIHRvIGF2b2lkIGZhbGx0aHJvdWdoIGludG8NCj4gdGhlIG5leHQg
Y2FzZSBhbmQgaW5jb3JyZWN0bHkgcmV0dXJuIHplcm8gaW5kaWNhdGluZyBzdWNjZXNzIHRvDQo+
IHRoZSBjYWxsZXIgZXZlbiBpZiB0aGUgZnVuY3Rpb24gY2FsbCB0byBpd2xfbXZtX3NjYW5fc3Rv
cCBmYWlscy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE5pY2hvbGFzIEtyYXVzZSA8eGVyb2ZvaWZ5
QGdtYWlsLmNvbT4NCj4gLS0tDQoNCkFwcGxpZWQgdG8gb3VyIGludGVybmFsIHRyZWUgd2l0aCBh
IG1vZGlmaWVkIGNvbW1pdCBtZXNzYWdlLg0KDQpUaGFua3MhDQoNCi0tDQpMdWNhLg==

WARNING: multiple messages have this Message-ID (diff)
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "xerofoify@gmail.com" <xerofoify@gmail.com>,
	"Berg, Johannes" <johannes.berg@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Spinadel, David" <david.spinadel@intel.com>,
	"Dreyfuss, Haim" <haim.dreyfuss@intel.com>,
	"Bondar, Alexander" <alexander.bondar@intel.com>,
	"ilw@linux.intel.com" <ilw@linux.intel.com>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"Stern, Avraham" <avraham.stern@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans
Date: Thu, 8 Oct 2015 08:30:22 +0000	[thread overview]
Message-ID: <1444293021.2899.46.camel@intel.com> (raw)
In-Reply-To: <1442967859-16347-1-git-send-email-xerofoify@gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 763 bytes --]

On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote:
> This fixes incorrect fallthrough in the switch statment checking
> the scan type passed by the caller to iwl_mvm_check_running_scans
> for the switch case IWL_MVM_SCAN_SCHED to return directly after
> the call to iwl_mvm_scan_stop in order to avoid fallthrough into
> the next case and incorrectly return zero indicating success to
> the caller even if the function call to iwl_mvm_scan_stop fails.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---

Applied to our internal tree with a modified commit message.

Thanks!

--
Luca.ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

WARNING: multiple messages have this Message-ID (diff)
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "xerofoify@gmail.com" <xerofoify@gmail.com>,
	"Berg, Johannes" <johannes.berg@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Spinadel, David" <david.spinadel@intel.com>,
	"Dreyfuss, Haim" <haim.dreyfuss@intel.com>,
	"Bondar, Alexander" <alexander.bondar@intel.com>,
	"ilw@linux.intel.com" <ilw@linux.intel.com>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"Stern, Avraham" <avraham.stern@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans
Date: Thu, 8 Oct 2015 08:30:22 +0000	[thread overview]
Message-ID: <1444293021.2899.46.camel@intel.com> (raw)
In-Reply-To: <1442967859-16347-1-git-send-email-xerofoify@gmail.com>

On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote:
> This fixes incorrect fallthrough in the switch statment checking
> the scan type passed by the caller to iwl_mvm_check_running_scans
> for the switch case IWL_MVM_SCAN_SCHED to return directly after
> the call to iwl_mvm_scan_stop in order to avoid fallthrough into
> the next case and incorrectly return zero indicating success to
> the caller even if the function call to iwl_mvm_scan_stop fails.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---

Applied to our internal tree with a modified commit message.

Thanks!

--
Luca.

       reply	other threads:[~2015-10-08  8:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1442967859-16347-1-git-send-email-xerofoify@gmail.com>
2015-10-08  8:30 ` Coelho, Luciano [this message]
2015-10-08  8:30   ` [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans Coelho, Luciano
2015-10-08  8:30   ` Coelho, Luciano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444293021.2899.46.camel@intel.com \
    --to=luciano.coelho@intel.com \
    --cc=alexander.bondar@intel.com \
    --cc=avraham.stern@intel.com \
    --cc=david.spinadel@intel.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=haim.dreyfuss@intel.com \
    --cc=ilw@linux.intel.com \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.